RE: [PATCH v2 2/3] serial: sh-sci: Add support for separate TEI+DRI interrupts

2018-07-26 Thread Chris Brandt
Hi Geert, On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > > +static irqreturn_t sci_br_interrupt(int irq, void *ptr); > > You can avoid the forward declaration by moving the whole function here. OK. > > @@ -2809,6 +2845,8 @@ static int sci_init_single(struct platform_device > *dev, > >

Re: [PATCH v2 2/3] serial: sh-sci: Add support for separate TEI+DRI interrupts

2018-07-26 Thread Geert Uytterhoeven
Hi Chris, On Wed, Jul 25, 2018 at 4:39 PM Chris Brandt wrote: > Some SCIF versions mux error and break interrupts together and then provide > a separate interrupt ID for just TEI/DRI. > > Allow all 6 types of interrupts to be specified via platform data (or DT) > and for any signals that are