RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-25 Thread Chris Brandt
Hi Daniel, On Wednesday, January 25, 2017, Daniel Lezcano wrote: > > Then things work, but I'm back to managing the rollback code manually. > > > > > > Any other ideas on how to get the corresponding platform_device for a > > DT node? > > No :/ > > So up to you. > - CLOCKSOURCE_OF_DECLARE

RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-25 Thread Chris Brandt
Hi Geert, On Wednesday, January 25, 2017, Geert Uytterhoeven wrote: > > So I realized that in order to use builtin_platform, I can't have any > > of the functions in __init because the build system has no idea that I > > never plan on removing or probing again after boot. But, even if I > > take o

Re: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-25 Thread Daniel Lezcano
On Tue, Jan 24, 2017 at 08:19:50PM +, Chris Brandt wrote: > Hi Daniel, > > On Tuesday, January 24, 2017, Daniel Lezcano wrote: > > > > > +early_platform_init("earlytimer", &ostm_timer); > > > > > +subsys_initcall(ostm_init); module_exit(ostm_exit); > > > > > + > > > > > +MODULE_AUTHOR("Chris B

Re: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-25 Thread Geert Uytterhoeven
Hi Chris, On Tue, Jan 24, 2017 at 3:43 PM, Chris Brandt wrote: > On Tuesday, January 24, 2017, Daniel Lezcano wrote: >> > > > +early_platform_init("earlytimer", &ostm_timer); >> > > > +subsys_initcall(ostm_init); module_exit(ostm_exit); >> > > > + >> > > > +MODULE_AUTHOR("Chris Brandt"); >> > > >

Re: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-25 Thread Geert Uytterhoeven
On Tue, Jan 24, 2017 at 9:19 PM, Chris Brandt wrote: > On Tuesday, January 24, 2017, Daniel Lezcano wrote: >> > > > +early_platform_init("earlytimer", &ostm_timer); >> > > > +subsys_initcall(ostm_init); module_exit(ostm_exit); >> > > > + >> > > > +MODULE_AUTHOR("Chris Brandt"); >> > > > +MODULE_DE

RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-24 Thread Chris Brandt
Hi Daniel, On Tuesday, January 24, 2017, Daniel Lezcano wrote: > > > > +early_platform_init("earlytimer", &ostm_timer); > > > > +subsys_initcall(ostm_init); module_exit(ostm_exit); > > > > + > > > > +MODULE_AUTHOR("Chris Brandt"); > > > > +MODULE_DESCRIPTION("Renesas OSTM Timer Driver"); > > > > +

RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-24 Thread Chris Brandt
Hi Daniel, On Tuesday, January 24, 2017, Daniel Lezcano wrote: > > > > +early_platform_init("earlytimer", &ostm_timer); > > > > +subsys_initcall(ostm_init); module_exit(ostm_exit); > > > > + > > > > +MODULE_AUTHOR("Chris Brandt"); > > > > +MODULE_DESCRIPTION("Renesas OSTM Timer Driver"); > > > > +

Re: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-24 Thread Daniel Lezcano
On Tue, Jan 24, 2017 at 04:45:47AM +, Chris Brandt wrote: Hi Chris, [ ... ] > > > + bool "Renesas OSTM timer driver" if COMPILE_TEST > > > + depends on GENERIC_CLOCKEVENTS > > > + select CLKSRC_MMIO > > > + default SYS_SUPPORTS_RENESAS_OSTM > > > > - default SYS_SUPPORTS_RENESAS_OSTM > > >

RE: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-23 Thread Chris Brandt
Hello Daniel, Thank you for the review. Your suggestions were very helpful to me. I basically made all the changes, but I had some questions on the Kconfig and multi-line commenting. On Monday, January 23, 2017, Daniel Lezcano wrote: > > This patch adds a OSTM driver for the Renesas architectur

Re: [PATCH v3 2/2] clocksource: Add renesas-ostm timer driver

2017-01-23 Thread Daniel Lezcano
On Mon, Jan 23, 2017 at 08:54:23AM -0500, Chris Brandt wrote: > This patch adds a OSTM driver for the Renesas architecture. As it is a new driver, please give technical details for the log. Replace ioread/write by readl/writel in the code. > Signed-off-by: Chris Brandt > > --- > v2: > * chang