Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, On Thursday, 22 February 2018 09:38:46 EET Hans Verkuil wrote: > On 02/21/2018 09:16 PM, Laurent Pinchart wrote: > > On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote: > >> On 02/19/2018 11:28 PM, Niklas Söderlund wrote: > >>> Hi Hans, > >>> > >>> Thanks for your feedback. >

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, On Thursday, 22 February 2018 10:01:13 EET Hans Verkuil wrote: > On 02/21/2018 10:01 PM, Sakari Ailus wrote: > > On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote: > >> No, I'm sorry, for MC-based drivers this isn't correct. The media entity > >> that symbolizes the DMA

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On 02/21/2018 10:01 PM, Sakari Ailus wrote: > Hi Laurent and Hans, > > On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote: >> No, I'm sorry, for MC-based drivers this isn't correct. The media entity >> that >> symbolizes the DMA engine indeed has a sink pad, but it's a video node,

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On 02/21/2018 09:16 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote: >> On 02/19/2018 11:28 PM, Niklas Söderlund wrote: >>> Hi Hans, >>> >>> Thanks for your feedback. >>> >>> [snip] >>> Can you then fix v4l2-compliance to stop

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Laurent and Hans, On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote: > No, I'm sorry, for MC-based drivers this isn't correct. The media entity that > symbolizes the DMA engine indeed has a sink pad, but it's a video node, not a > subdev. It thus has no media bus format

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote: > On 02/19/2018 11:28 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback. > > > > [snip] > > > >> Can you then fix v4l2-compliance to stop testing colorspace > >> against 0xff > >> ? >

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Niklas, On 02/19/2018 11:28 PM, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback. > > [snip] > >> Can you then fix v4l2-compliance to stop testing colorspace >> against 0xff >> ? > > For now I can simply relax this test for subdevs with sources and sinks.

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, Thanks for your feedback. [snip] > > >>> Can you then fix v4l2-compliance to stop testing colorspace > > >>> against 0xff > > >>> ? > > >> > > >> For now I can simply relax this test for subdevs with sources and sinks. > > > > > > You also need to relax it for video nodes with MC

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, On Thursday, 15 February 2018 14:32:55 EET Hans Verkuil wrote: > On 15/02/18 13:06, Laurent Pinchart wrote: > > On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: > >> On 15/02/18 12:08, Laurent Pinchart wrote: > >>> On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On 15/02/18 13:32, Hans Verkuil wrote: > On 15/02/18 13:06, Laurent Pinchart wrote: >> Hi Hans, >> >> On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: >>> On 15/02/18 12:08, Laurent Pinchart wrote: On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: > On 14/02/18

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On 15/02/18 13:06, Laurent Pinchart wrote: > Hi Hans, > > On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: >> On 15/02/18 12:08, Laurent Pinchart wrote: >>> On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: On 14/02/18 16:16, Laurent Pinchart wrote: > On

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, On Thursday, 15 February 2018 13:56:44 EET Hans Verkuil wrote: > On 15/02/18 12:08, Laurent Pinchart wrote: > > On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: > >> On 14/02/18 16:16, Laurent Pinchart wrote: > >>> On Wednesday, 14 February 2018 12:36:43 EET Niklas

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On 15/02/18 12:08, Laurent Pinchart wrote: > Hi Hans, > > On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: >> On 14/02/18 16:16, Laurent Pinchart wrote: >>> On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: There is no way for drivers to validate a colorspace

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Hans, On Thursday, 15 February 2018 12:57:44 EET Hans Verkuil wrote: > On 14/02/18 16:16, Laurent Pinchart wrote: > > On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: > >> There is no way for drivers to validate a colorspace value, which could > >> be provided by user-space

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On 14/02/18 16:16, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: >> There is no way for drivers to validate a colorspace value, which could >> be provided by user-space by VIDIOC_S_FMT for example. Add a

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

Hi Niklas, Thank you for the patch. On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

On Wed, Feb 14, 2018 at 11:36:43AM +0100, Niklas Söderlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part of enum v4l2_colorspace. > >