Re: [PATCH v2 21/22] mmc: tmio: move {tmio_}mmc_of_parse() to tmio_mmc_host_alloc()

On Sat, Nov 25, 2017 at 01:24:56AM +0900, Masahiro Yamada wrote: > mmc_of_parse() parses various DT properties and sets capability flags > accordingly. However, drivers have no chance to run platform init > code depending on such flags because mmc_of_parse() is called from >

Re: [PATCH v2 22/22] mmc: tmio: remove dma_ops from tmio_mmc_host_probe() argument

On Sat, Nov 25, 2017 at 01:24:57AM +0900, Masahiro Yamada wrote: > Drivers need to set up various struct members for tmio_mmc_host before > calling tmio_mmc_host_probe(). Do likewise for host->dma_ops instead > of passing it as a function argument. > > Signed-off-by: Masahiro Yamada

Re: [PATCH v2 20/22] mmc: tmio: move clk_enable/disable out of tmio_mmc_host_probe()

On Sat, Nov 25, 2017 at 01:24:55AM +0900, Masahiro Yamada wrote: > The clock is enabled in the tmio_mmc_host_probe(). It also prevents > drivers from performing platform-specific settings before mmc_add_host() > because the register access generally requires a clock. > > Enable/disable the clock

[PATCH v6 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v6 2/9] include: media: Add Renesas CEU driver interface

Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

Hello, new version of CEU after Hans' review. Added his Acked-by to most patches and closed review comments. Running v4l2-compliance, I noticed a new failure introduced by the way I now calculate the plane sizes in set/try_fmt. This is the function used to update per-plane bytesperline and

[PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings

Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

Hi Sergei, On Tuesday, 16 January 2018 22:17:31 EET Sergei Shtylyov wrote: > On 01/16/2018 06:46 PM, Laurent Pinchart wrote: > >>> From: Sergei Shtylyov > >>> > >>> According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS > >>> must be enabled

[PATCH v6 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v6 8/9] media: i2c: tw9910: Remove soc_camera dependencies

Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies

Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v6 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v2] v4l: async: Protect against double notifier registrations

From: Kieran Bingham It can be easy to attempt to register the same notifier twice in mis-handled error cases such as working with -EPROBE_DEFER. This results in odd kernel crashes where the notifier_list becomes corrupted due to adding the same entry

Re: [PATCH v2 17/22] mmc: tmio: move TMIO_MASK_{READOP,WRITEOP} handling to correct place

On Sat, Nov 25, 2017 at 01:24:52AM +0900, Masahiro Yamada wrote: > This driver was largely extended by Renesas, but actually used by > several SoC vendors. The current code does not work for UniPhier > SoCs at least. Do you insist on this paragraph? All people working on the code so far tried

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

Hi Laurent, On Mon, Jan 15, 2018 at 7:01 PM, Laurent Pinchart wrote: > On Monday, 15 January 2018 19:09:53 EET Rob Herring wrote: >> On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: >> > The internal LVDS encoders now have their own DT bindings. Before

Re: [PATCH v2 18/22] mmc: tmio: remove useless TMIO_MASK_CMD handling in tmio_mmc_host_probe()

On Sat, Nov 25, 2017 at 01:24:53AM +0900, Masahiro Yamada wrote: > TMIO_MASK_CMD is properly enabled in tmio_mmc_start_command(). > > We have no reason to set it up in tmio_mmc_host_probe(). (If we > really wanted to set it in the probe, we would have to do likewise > when resuming.) > > Even

Re: [PATCH v2 19/22] mmc: tmio: ioremap memory resource in tmio_mmc_host_alloc()

On Sat, Nov 25, 2017 at 01:24:54AM +0900, Masahiro Yamada wrote: > The register region is ioremap'ed in the tmio_mmc_host_probe(), i.e. > drivers cannot get access to the hardware before mmc_add_host(). > > Actually, renesas_sdhi_core.c reads out the CTL_VERSION register to > complete the

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

Hi Geert, On Tuesday, 16 January 2018 10:56:10 EET Geert Uytterhoeven wrote: > On Mon, Jan 15, 2018 at 7:01 PM, Laurent Pinchart wrote: > > On Monday, 15 January 2018 19:09:53 EET Rob Herring wrote: > >> On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: > >>> The internal LVDS encoders now

Re: [PATCH v5 3/9] v4l: platform: Add Renesas CEU driver

Hi Hans, On Tuesday, 16 January 2018 11:46:42 EET Hans Verkuil wrote: > Hi Jacopo, > > Sorry for the late review, but here is finally is. > > BTW, can you provide the v4l2-compliance output (ideally with the -f option) > in the cover letter for v6? > > On 01/12/2018 03:04 PM, Jacopo Mondi

Re: [PATCH] [LOCAL] arm64: renesas_defconfig: Use a default 128MB of CMA

On Mon, Jan 15, 2018 at 12:59:16PM +, Kieran Bingham wrote: > Our media tests frequently need large areas of CMA. > Define the default allocation to be 128 MBytes to support > larger use-cases. > > Signed-off-by: Kieran Bingham > Acked-by: Laurent Pinchart

Re: [PATCH v5 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. > No modification to KConfig and Makefile as soc_camera framework > dependencies need to be removed first in next

Re: [PATCH v5 2/9] include: media: Add Renesas CEU driver interface

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add renesas-ceu header file. > > Do not remove the existing sh_mobile_ceu.h one as long as the original > driver does not go away. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Laurent Pinchart

Re: [PATCH v5 1/9] dt-bindings: media: Add Renesas CEU bindings

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > Signed-off-by: Jacopo Mondi > Reviewed-by: Rob Herring > Reviewed-by: Laurent Pinchart Acked-by:

[PATCH 4/4] ARM: dts: r8a7790: sort subnodes of root node

Sort subnodes of root node to aid maintenance. This patch should not introduce any functional change. Signed-off-by: Simon Horman --- arch/arm/boot/dts/r8a7790.dtsi | 104 - 1 file changed, 52 insertions(+), 52 deletions(-)

[PATCH 2/4] ARM: r8a7790: Add soc node

Add soc node to represent the bus and move all nodes with a base address into this node. This is consistent with handling of R-Car Gen3, RZ/G1, and R-Car V2H (R8A77920) SoCs upstream. It is intended to migrate other R-Car Gen2 SoCs to this scheme. The ordering is derived from simply moving each

[PATCH 3/4] ARM: r8a7790: sort subnodes of soc node

Sort the subnodes of the soc node to improve maintainability. The sort key is the addresss on the bus with instances of the same IP block grouped together. This patch should not introduce any functional change. Signed-off-by: Simon Horman ---

[PATCH 1/4] ARM: dts: r8a7790: consistently use single space after =

Consistently use a single space after a =. This patch removes instances where a tab is used instead. This patch should not introduce any functional change. Signed-off-by: Simon Horman --- arch/arm/boot/dts/r8a7790.dtsi | 72 +-

[PATCH 0/4] ARM: r8a7790: Add soc node

. The patchset also fixes some minor whitespace problems and sorts the DT nodes to improve maintainability. Based on renesas-devel-20180116-v4.15-rc8. As this patchset contains patches with large numbers of lines changed I have also pushed it to the topic/r8a7790-soc-node branch of my renesas tree

Re: [PATCH 05/10] ARM: dts: porter: Fix HDMI output routing

On Mon, Jan 15, 2018 at 10:25:34AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Monday, 15 January 2018 09:56:03 EET Simon Horman wrote: > > On Fri, Jan 12, 2018 at 02:58:53AM +0200, Laurent Pinchart wrote: > > > The HDMI encoder is connected to the RGB output of the DU, which is > > >

Re: [PATCH v5 8/9] media: i2c: tw9910: Remove soc_camera dependencies

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from tw9910 sensor driver. > - Handle clock and gpios > - Register async subdevice > - Remove soc_camera specific g/s_mbus_config operations > - Add kernel doc to driver interface header file > - Adjust build

Re: [PATCH v5 9/9] arch: sh: migor: Use new renesas-ceu camera driver

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Migo-R platform uses sh_mobile_ceu camera driver, which is now being > replaced by a proper V4L2 camera driver named 'renesas-ceu'. > > Move Migo-R platform to use the v4l2 renesas-ceu camera driver > interface and get rid of soc_camera defined

Re: [PATCH v5 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart Acked-by:

Re: [PATCH v5 3/9] v4l: platform: Add Renesas CEU driver

Hi Jacopo, Sorry for the late review, but here is finally is. BTW, can you provide the v4l2-compliance output (ideally with the -f option) in the cover letter for v6? On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Add driver for Renesas Capture Engine Unit (CEU). > > The CEU interface supports

Re: [PATCH v5 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. > No modification to KConfig and Makefile as soc_camera framework > dependencies need to be removed first in next

Re: [PATCH v5 6/9] media: i2c: ov772x: Remove soc_camera dependencies

On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from ov772x sensor driver. > - Handle clock and gpios > - Register async subdevice > - Remove soc_camera specific g/s_mbus_config operations > - Change image format colorspace from JPEG to SRGB as the two use

Re: [PATCH v5 6/9] media: i2c: ov772x: Remove soc_camera dependencies

Hi Hans, On Tuesday, 16 January 2018 12:08:17 EET Hans Verkuil wrote: > On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > > - Handle clock and gpios > > - Register async subdevice > > - Remove soc_camera specific g/s_mbus_config

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

On Tue, Jan 16, 2018 at 10:32 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday, 16 January 2018 16:35:26 EET Rob Herring wrote: >> On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: >> > On 01/15/18 12:29, Laurent Pinchart wrote: >> >> On Monday, 15

Re: [PATCH v5 3/9] v4l: platform: Add Renesas CEU driver

Hi Hans, On Tue, Jan 16, 2018 at 10:46:42AM +0100, Hans Verkuil wrote: > Hi Jacopo, > > Sorry for the late review, but here is finally is. > > BTW, can you provide the v4l2-compliance output (ideally with the -f option) > in the cover letter for v6? Sure, it was attacched to v3 I guess, since

Re: [PATCH 3/4] ARM: r8a7790: sort subnodes of soc node

On Tue, Jan 16, 2018 at 11:13:29AM +0100, Simon Horman wrote: > Sort the subnodes of the soc node to improve maintainability. > The sort key is the addresss on the bus with instances of the same > IP block grouped together. > > This patch should not introduce any functional change. > >

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: > On 01/15/18 12:29, Laurent Pinchart wrote: >> Hi Frank, >> >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: >>> On 01/15/18 11:22, Laurent Pinchart wrote: On Monday, 15 January 2018 21:12:44 EET

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

On Tue, Jan 16, 2018 at 2:56 AM, Geert Uytterhoeven wrote: > Hi Laurent, > > On Mon, Jan 15, 2018 at 7:01 PM, Laurent Pinchart > wrote: >> On Monday, 15 January 2018 19:09:53 EET Rob Herring wrote: >>> On Fri, Jan 12, 2018 at 5:14 PM,

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

Hi Rob, On Tuesday, 16 January 2018 16:35:26 EET Rob Herring wrote: > On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: > > On 01/15/18 12:29, Laurent Pinchart wrote: > >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: > >>> On 01/15/18 11:22, Laurent Pinchart wrote: > On

Re: [PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

Hi Sergei, On Saturday, 13 January 2018 11:25:31 EET Sergei Shtylyov wrote: > On 1/13/2018 1:15 AM, Laurent Pinchart wrote: > >>> According to the latest revisions of the R-Car gen3 manual, the LVDS > >>> mode must be set before the LVDS I/O pins are enabled, not after -- fix > >>> the gen3

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

Hi Sergei, On Saturday, 13 January 2018 11:33:55 EET Sergei Shtylyov wrote: > On 1/13/2018 2:10 AM, Laurent Pinchart wrote: > > From: Sergei Shtylyov > > > > According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS > > must be enabled and the

Re: iwg20d display driver

Hi Chris, On Wednesday, 3 January 2018 17:19:51 EET Chris Paterson wrote: > On Sent: 03 January 2018 13:34 Laurent Pinchart wrote: > > On Wednesday, 3 January 2018 12:09:48 EET Chris Paterson wrote: > >> Hello Laurent, > >> > >> Happy new year! > > > > Onnellista uutta vuotta to you too :) > >

Re: [PATCH v2] sata: sata_rcar: Reset SATA PHY when Salvator-X board resumes

On 01/16/2018 05:39 PM, Yoshihiro Kaneko wrote: From: Khiem Nguyen Because power of Salvator-X board is cut off in suspend, it needs to reset SATA PHY state in resume. Otherwise, SATA partition could not be accessed anymore. Signed-off-by: Khiem Nguyen

Re: [PATCH v2] sata: sata_rcar: Reset SATA PHY when Salvator-X board resumes

Hello! On 01/16/2018 05:39 PM, Yoshihiro Kaneko wrote: From: Khiem Nguyen Because power of Salvator-X board is cut off in suspend, it needs to reset SATA PHY state in resume. Otherwise, SATA partition could not be accessed anymore. Signed-off-by: Khiem

Re: [PATCH v2] sata: sata_rcar: Reset SATA PHY when Salvator-X board resumes

On 01/16/2018 07:25 PM, Sergei Shtylyov wrote: From: Khiem Nguyen Because power of Salvator-X board is cut off in suspend, it needs to reset SATA PHY state in resume. Otherwise, SATA partition could not be accessed anymore. Signed-off-by: Khiem Nguyen

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

On 01/16/2018 06:46 PM, Laurent Pinchart wrote: From: Sergei Shtylyov According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS must be enabled and the bias crcuit enabled after the LVDS I/O pins are Oops, this needs fixing (note the

Re: [PATCH v5 6/9] media: i2c: ov772x: Remove soc_camera dependencies

Hi Hans, On Tue, Jan 16, 2018 at 11:08:17AM +0100, Hans Verkuil wrote: > On 01/12/2018 03:04 PM, Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > > - Handle clock and gpios > > - Register async subdevice > > - Remove soc_camera specific g/s_mbus_config

[PATCH v2] sata: sata_rcar: Reset SATA PHY when Salvator-X board resumes

From: Khiem Nguyen Because power of Salvator-X board is cut off in suspend, it needs to reset SATA PHY state in resume. Otherwise, SATA partition could not be accessed anymore. Signed-off-by: Khiem Nguyen Signed-off-by: Hien