Re: GEN2: Initialization of VIN failed at upstream v4.8-rc2

2016-09-12 Thread Hiep Cao Minh
Hi Niklas, On 09/12/2016 08:09 PM, Niklas Söderlund wrote: Hi Hiep, On 2016-09-12 18:33:49 +0900, Hiep Cao Minh wrote: Hi Niklas As you know the information about initialization of VIN failed at upstream v4.8-rc2 from the report of "The failure summary report of GEN2 for Linux v4.8-rc2".

[renesas-drivers:topic/spi-slave-v2-integration 5/8] ERROR: "signal_wake_up_state" [drivers/spi/spi-sh-msiof.ko] undefined!

2016-09-12 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git topic/spi-slave-v2-integration head: 99f79882624a9a1c94c784d6359426069ed62c2e commit: 688a353f485dbed2c5c415b54170ebfa76677310 [5/8] [RFC] spi: sh-msiof: Add slave mode support config: i386-allmodconfig

Re: [PATCH 1/8] devicetree: binding: R-car Gen3 CMT0 and CMT1 bindings

2016-09-12 Thread Bui Duc Phuc
Dear Geert, I think the plan was to get rid of the renesas,cmt-48-* bindings, as they do not allow to differentiate between CMT0 and CMT1, which have different feature sets. Cfr. Magnus' series "clocksource: sh_cmt: DT binding rework V4" (https://lkml.org/lkml/2016/3/14/433). Magnus: What's

Re: [PATCH 5/8] clk: renesas: r8a7796: Add CMT clocks

2016-09-12 Thread Bui Duc Phuc
Dear Geert Thank you for your review. Reviewed-by: Geert Uytterhoeven (will queue in clk-renesas-for-v4.9) Thank you for helping me. BTW, I've dropped the spaces before the TABs (also in the r8a7795 patch). -- Regards, Bui Duc Phuc

Re: [PATCH 4/8] clk: renesas: r8a7795: Add CMT clocks

2016-09-12 Thread Bui Duc Phuc
Dear Geert Thank you for your review. Reviewed-by: Geert Uytterhoeven (will queue in clk-renesas-for-v4.9) -- Regards, Bui Duc Phuc

Re: [PATCH] PCI: rcar: Don't disable/unprepare clocks on prepare/enable failure

2016-09-12 Thread Bjorn Helgaas
On Wed, Aug 31, 2016 at 11:28:22AM +0200, Geert Uytterhoeven wrote: > If clk_prepare_enable() fails, we must not call clk_disable_unprepare() > in the error path. > > Signed-off-by: Geert Uytterhoeven Applied to pci/host-rcar for v4.9, thanks! > --- >

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep 2016,

[PATCH/RFC v2 5/7] spi: sh-msiof: Add slave mode support

2016-09-12 Thread Geert Uytterhoeven
From: Hisashi Nakamura Add slave mode support to the MSIOF driver, in both PIO and DMA mode. For now this only supports the transmission of messages with a size that is known in advance. Signed-off-by: Hisashi Nakamura

[PATCH/RFC v2 6/7] spi: slave: Add SPI slave handler reporting uptime at previous message

2016-09-12 Thread Geert Uytterhoeven
Add an example SPI slave handler responding with the uptime at the time of reception of the last SPI message. This can be used by an external microcontroller as a dead man's switch. Signed-off-by: Geert Uytterhoeven --- v2: - Resolve semantic differences in patch

[PATCH/RFC v2 4/7] spi: Document SPI slave controller support

2016-09-12 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- v2: - New. --- Documentation/spi/spi-summary | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/Documentation/spi/spi-summary b/Documentation/spi/spi-summary index

[PATCH/RFC v2 2/7] spi: core: Extract of_spi_parse_dt()

2016-09-12 Thread Geert Uytterhoeven
Extract the parsing of SPI slave-specific properties into its own function, so it can be reused later for SPI slave controllers. Signed-off-by: Geert Uytterhoeven --- v2: - New. --- drivers/spi/spi.c | 60 +-- 1 file

[PATCH/RFC v2 0/7] spi: Add slave mode support

2016-09-12 Thread Geert Uytterhoeven
rse_dt()" and "spi: Document SPI slave controller support", - Dropped "spi: spidev: Allow direct references in DT from SPI slave controllers". This patch series applies to v4.8-rc1..v4.8-rc6. It appplies to next-20160912 with some small context changes. For your c

[PATCH/RFC v2 1/7] spi: Document DT bindings for SPI controllers in slave mode

2016-09-12 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- v2: - Do not create a child node in SPI slave mode. Instead, add an "spi-slave" property, and put the mode properties in the controller node. --- Documentation/devicetree/bindings/spi/spi-bus.txt | 34

[PATCH/RFC v2 7/7] spi: slave: Add SPI slave handler controlling system state

2016-09-12 Thread Geert Uytterhoeven
Add an example SPI slave handler to allow remote control of system reboot, power off, halt, and suspend. Signed-off-by: Geert Uytterhoeven --- v2: - Use spi_async() instead of spi_read(), - Submit the next transfer from the previous transfer's completion

[PATCH/RFC v2 3/7] spi: core: Add support for registering SPI slave controllers

2016-09-12 Thread Geert Uytterhoeven
Add support for registering SPI slave controllers using the existing SPI master framework: - SPI slave controllers must set the SPI_CONTROLLER_IS_SLAVE flag in spi_master.flags, and should provide an additional callback "slave_abort" to abort an ongoing SPI transfer request. - SPI

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 03:52:08PM +0200, Julia Lawall wrote: > > > On Mon, 12 Sep 2016, Felipe Balbi wrote: > > > > > Hi, > > > > Jarkko Sakkinen writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > >> > > >> > > >> On Sun, 11 Sep

Re: [PATCH] ARM: dts: wheat: add DU support

2016-09-12 Thread Sergei Shtylyov
On 09/02/2016 12:29 AM, Sergei Shtylyov wrote: Define the Wheat board dependent part of the DU device node. Add the device nodes for the Analog Devices ADV7513 HDMI transmitters connected to DU0/1. Add the necessary subnodes to interconnect DU with HDMI transmitters/connectors.

[PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Chris Brandt
For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. Therefore a new flag has been created that will allow 32-bit reads/writes to the DATA_PORT register instead of 16-bit (because 16-bits accesses are not supported). Signed-off-by: Chris Brandt ---

[PATCH v3 3/3] mmc: sh_mobile_sdhi: Add r7s72100 support

2016-09-12 Thread Chris Brandt
Add support for r7s72100 SoC. Signed-off-by: Chris Brandt --- Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 1 + drivers/mmc/host/sh_mobile_sdhi.c | 7 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH v3 0/3] mmc: sh_mobile_sdhi: Add r7s72100 support

2016-09-12 Thread Chris Brandt
For the most part, the SDHI controller in the RZ/A1 (r7s72100) is the same as other Renesas SoC...except for the fact that the data port register was widened to 32-bits and the 16-bit accesses in the current tmio driver aren't going to cut it. Also, the tmio driver allows you to pass in what

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >> > >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Felipe Balbi
Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > > Constify local structures. > > > > > > > > The

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Jarkko Sakkinen
On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > > Constify local structures. > > > > > > The semantic patch that makes this change is as follows: > > >

RE: [PATCH v2 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Chris Brandt
Hello Sergei > BTW, you could use memcpy() and thus avoid all the loops and shifts, > see > ata_sff_data_xfer32() in drivers/ata/libata-sff.c. > > [...] > > MBR, Sergei That's a good idea. Thank you. I just tried it and it works good, so I'll get rid of the loops. Chris

Re: [PATCH 0/3] pinctrl: sh-pfc: r8a779[14]: Implement voltage switching for SDHI

2016-09-12 Thread Linus Walleij
On Thu, Sep 8, 2016 at 1:36 PM, Simon Horman wrote: > this series adds voltage switching for SDHI to sh-pfc for the r8a7791 and > r8a794 SoCs. It is based on work for the r8a7790 SoC by Wolfram Sang. > > The r8a7793 should be able to be trivially supported using the >

Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Geert Uytterhoeven
Hi Chris, On Mon, Sep 12, 2016 at 1:56 PM, Chris Brandt wrote: > On 9/11/12016, Geert Uytterhoeven wrote: >> > So would you say sd_ctrl_write16_rep should also be changed to be 'const >> u16 *buf'? >> > >> > Currently it is: >> > static inline void

RE: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Chris Brandt
Hi Geert, On 9/11/12016, Geert Uytterhoeven wrote: > > So would you say sd_ctrl_write16_rep should also be changed to be 'const > u16 *buf'? > > > > Currently it is: > > static inline void sd_ctrl_write16_rep(struct tmio_mmc_host *host, int > addr, > > u16 *buf, int count) > > { >

Re: GEN2: Initialization of VIN failed at upstream v4.8-rc2

2016-09-12 Thread Niklas Söderlund
Hi Hiep, On 2016-09-12 18:33:49 +0900, Hiep Cao Minh wrote: > Hi Niklas > > As you know the information about initialization of VIN failed at upstream > v4.8-rc2 > from the report of "The failure summary report of GEN2 for Linux v4.8-rc2". > "… > [ 5.589485] [] (of_node_put) from [] >

Re: [PATCH v2 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Sergei Shtylyov
Hello. On 9/12/2016 12:03 AM, Chris Brandt wrote: For the r7s72100 SOC, the DATA_PORT register was changed to be 32-bits wide. Therefore a new flag has been created that will allow 32-bit reads/writes to the DATA_PORT register instead of 16-bit (because 16-bits accesses are not supported).

Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > >

GEN2: Initialization of VIN failed at upstream v4.8-rc2

2016-09-12 Thread Hiep Cao Minh
Hi Niklas As you know the information about initialization of VIN failed at upstream v4.8-rc2 from the report of "The failure summary report of GEN2 for Linux v4.8-rc2". "… [ 5.589485] [] (of_node_put) from [] (rcar_vin_probe+0x1c4/0x2d0) [ 5.612949] [] (rcar_vin_probe) from []

Re: GEN2: Initialization of VSP1 failed at upstream v4.8-rc2

2016-09-12 Thread Hiep Cao Minh
Hi Geert, Thanks for your quick reply! As you know the information about Initialization of VSP1 failed at upstream v4.8-rc2 from the report of "The failure summary report of GEN2 for Linux v4.8-rc2". "[5.237049] vsp1: probe of fe92.vsp1 failed with error -38 [5.254664] vsp1:

Re: GEN2: Initialization of VSP1 failed at upstream v4.8-rc2

2016-09-12 Thread Geert Uytterhoeven
Hi Hiep, On Mon, Sep 12, 2016 at 10:57 AM, Hiep Cao Minh wrote: > As you know the information about Initialization of VSP1 failed at upstream > v4.8-rc2 > from the report of "The failure summary report of GEN2 for Linux v4.8-rc2". > "[5.237049] vsp1: probe of

Re: [PATCH v1.1 1/4] clk: shmobile: r8a7796: Add RAVB clock

2016-09-12 Thread Geert Uytterhoeven
On Mon, Sep 12, 2016 at 10:58 AM, Geert Uytterhoeven wrote: > On Tue, Sep 6, 2016 at 3:57 PM, Laurent Pinchart > wrote: >> Signed-off-by: Laurent Pinchart > > Reviewed-by: Geert

Re: [PATCH v1.1 1/4] clk: shmobile: r8a7796: Add RAVB clock

2016-09-12 Thread Geert Uytterhoeven
On Tue, Sep 6, 2016 at 3:57 PM, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven (will queue in clk-renesas-for-v4.9) Gr{oetje,eeting}s,

GEN2: Initialization of VSP1 failed at upstream v4.8-rc2

2016-09-12 Thread Hiep Cao Minh
Hi Laurent, As you know the information about Initialization of VSP1 failed at upstream v4.8-rc2 from the report of "The failure summary report of GEN2 for Linux v4.8-rc2". "[5.237049] vsp1: probe of fe92.vsp1 failed with error -38 [5.254664] vsp1: probe of fe928000.vsp1 failed

Re: [PATCH 23/26] sh_eth: constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Sergei Shtylyov wrote: > On 09/11/2016 04:06 PM, Julia Lawall wrote: > > For structure types defined in the same file or local header files, find > > top-level static structure declarations that have the following > > properties: > > 1. Never reassigned. > > Really? > > >

Re: [PATCH 00/26] constify local structures

2016-09-12 Thread Julia Lawall
On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents but: > > 1. You *can* use a static

Re: [PATCH v2 1/3] pinctrl: sh-pfc: Add PORT_GP_24 helper macro

2016-09-12 Thread Geert Uytterhoeven
On Mon, Sep 12, 2016 at 9:36 AM, Simon Horman wrote: > This follows the style of existing PORT_GP_X macros and > will be used by a follow-up patch for the r8a7791 SoC. > > Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven

Re: [PATCH 4/8] clk: renesas: r8a7795: Add CMT clocks

2016-09-12 Thread Geert Uytterhoeven
On Fri, Sep 9, 2016 at 1:43 PM, wrote: > From: Bui Duc Phuc > > This patch adds CMT module clocks for r8a7795 SoC. > > Signed-off-by: Bui Duc Phuc Reviewed-by: Geert Uytterhoeven (will queue in

Re: [PATCH v2] drm/bridge: adv7511: add support for the 2nd chip

2016-09-12 Thread Archit Taneja
On 09/06/2016 01:13 AM, Sergei Shtylyov wrote: The Renesas Wheat board has 2 ADV7513 chips on the same I2C bus, however the ADV751x driver only supports 1 chip as it tries to assign the packet/ EDID/CEC memory I2C devices to the fixed I2C addresses. Assign these I2C addresses at the fixed

Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Geert Uytterhoeven
Hi Chris, On Sun, Sep 11, 2016 at 9:50 PM, Chris Brandt wrote: > On 9/11/2016, Geert Uytterhoeven wrote: >> > --- a/drivers/mmc/host/tmio_mmc.h >> > +++ b/drivers/mmc/host/tmio_mmc.h >> >> > @@ -259,4 +265,10 @@ static inline void >> sd_ctrl_write32_as_16_and_16(struct

[PATCH v2 3/3] pinctrl: sh-pfc: r8a7794: Implement voltage switching for SDHI

2016-09-12 Thread Simon Horman
All the SHDIs can operate with either 3.3V or 1.8V signals, depending on negotiation with the card. Based on work by Wolfram Sang for the r8a7790. Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven Acked-by: Wolfram Sang

[PATCH v2 2/3] pinctrl: sh-pfc: r8a7791: Implement voltage switching for SDHI

2016-09-12 Thread Simon Horman
All the SHDIs can operate with either 3.3V or 1.8V signals, depending on negotiation with the card. Based on work by Wolfram Sang for the r8a7790. Cc: Wolfram Sang Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven

[PATCH v2 1/3] pinctrl: sh-pfc: Add PORT_GP_24 helper macro

2016-09-12 Thread Simon Horman
This follows the style of existing PORT_GP_X macros and will be used by a follow-up patch for the r8a7791 SoC. Signed-off-by: Simon Horman --- v2 * Rebase --- drivers/pinctrl/sh-pfc/sh_pfc.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git