Re: [PATCH 1/2] ARM: dts: iwg20d-q7: Add RTC support

[Simon Horman]

On Wed, Aug 09, 2017 at 11:02:30AM +0200, Simon Horman wrote:
> On Tue, Aug 08, 2017 at 02:04:24PM +0100, Biju Das wrote:
> > Define the iWave RainboW-G20D-Qseven board dependent part of the
> > RTC device node.
> > 
> > Signed-off-by: Biju Das 
> > ---
> >  arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 18 ++
> >  1 file changed, 18 insertions(+)
> 
> This has a compile-time dependency on
> "[PATCH  2/2] ARM: dts: r8a7743: Add I2C DT support"
> for the i2c2 node, right?

As I have now applied the above dependency I have
also applied this patch for v4.14.

Re: [PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support

[Simon Horman]

On Wed, Aug 09, 2017 at 09:23:05AM +, Biju Das wrote:
> 
> 
> > -Original Message-
> > From: Simon Horman [mailto:ho...@verge.net.au]
> > Sent: 09 August 2017 09:53
> > To: Biju Das 
> > Cc: Rob Herring ; Mark Rutland
> > ; Wolfram Sang ; Magnus
> > Damm ; Russell King ;
> > Chris Paterson ; devicet...@vger.kernel.org;
> > linux-renesas-soc@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> > Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support
> >
> > On Tue, Aug 08, 2017 at 12:24:09PM +0100, Biju Das wrote:
> > > Add the I2C[0-5] devices to the r8a7743 device tree.
> > >
> > > Signed-off-by: Biju Das 
> > > ---
> > > This patch has been tested against Linux-next tag 20170727 and renesas-dev
> > branch.
> > > This patch depends on
> > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg1700
> > > 8.html
> >
> > As per the patch at the link above it seems that these patches are targeted 
> > at
> > the renesas tree.  The best practice in that case is to base patches on the 
> > latest
> > devel branch. Please consider doing so in future.
> >
> > I would also slightly prefer if dependencies were referenced by name, in 
> > this
> > case:
> >
> > *  [PATCH 2/3] ARM: dts: r8a7743: Add APMU node and second CPU core
> >
> > or
> >
> > * [PATCH  0/3] Add SMP support
> >
> > Also including a link is fine by me.
> >
> >
> > It would also be useful if you described the dependency as a conflict 
> > (merge-
> > time), compile-time or run-time.
> 
> 
> Thanks Simon. I will take care this next time.
> 
> > As for the patch itself, it looks good to me.

As I believe the dependencies are apply-time and seemed easy to resolve
I have applied this patch for v4.14.

Re: [RFT] arm64: dts: renesas: salvator-common: enable SDR104 for SD cards

[Simon Horman]

On Tue, Aug 08, 2017 at 08:54:45PM +0200, Wolfram Sang wrote:
> 
> > As it is an "RFT" I'm happy to apply it if you repost
> > it or otherwise indicate that is what you would like to happen.
> 
> As discussed in a chat, I tried SDR104 with my SDIO WiFi cards:
> 
> H3:
> - one slot worked flawlessly
> - one slot could load FW but failed to read status
> (with SDR50: both slots work)
> 
> M3-W:
> - both slots could not load the firmware
> (with SDR50: one slot works, one fails to load FW)
> 
> The cards, however, were correctly identified as SDR104 and there were
> no tuning errors and no other SDHI related warnings.
> 
> Changing TDSEL in the PFC did not change anything.
> 
> The manual of the WiFi card (u-blox EMMY-W1) mentions a maximum line
> length of 100mm. Measuring a direct line from the SoC to the slots,
> I'd think we are very much on the edge of that. And given the length
> of the SDIO adapter, we are surely exceeding that :(
> 
> Maybe we should do more tests with more boards? On the other hand, it
> seems the WiFi card is running out of the specs.
> 
> So much for now. I'll sleep over it and try to get more data tomorrow.

Thanks. Unfortunately my H3 is out of arms length but I can arrange
some testing if it is helpful.

Is one possibility to enable it for the slots listed above that are now
thought to work but not for the other one?

The SDR50 failure on M3-W seems particularly troubling as that
has been enabled in upstream for a while, right?

[PATCH repost] serial: sh-sci: use of_property_read_bool()

[Sergei Shtylyov]

Use more compact of_property_read_bool() call for a boolean property
instead  of of_find_property() call in sci_parse_dt().

Signed-off-by: Sergei Shtylyov 

---
This patch is against the 'tty-next' branch of GregKH's 'tty.git' repo.

Reposting as the previous posting dropped Greg's and Jiri's emails...

 drivers/tty/serial/sh-sci.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: tty/drivers/tty/serial/sh-sci.c
===
--- tty.orig/drivers/tty/serial/sh-sci.c
+++ tty/drivers/tty/serial/sh-sci.c
@@ -3073,8 +3073,7 @@ static struct plat_sci_port *sci_parse_d
p->type = SCI_OF_TYPE(match->data);
p->regtype = SCI_OF_REGTYPE(match->data);
 
-   if (of_find_property(np, "uart-has-rtscts", NULL))
-   sp->has_rtscts = true;
+   sp->has_rtscts = of_property_read_bool(np, "uart-has-rtscts");
 
return p;
 }

[PATCH] serial: sh-sci: use of_property_read_bool()

[Sergei Shtylyov]

Use more compact of_property_read_bool() call for a boolean property
instead  of of_find_property() call in sci_parse_dt().

Signed-off-by: Sergei Shtylyov 

---
This patch is against the 'tty-next' branch of GregKH's 'tty.git' repo.

 drivers/tty/serial/sh-sci.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: tty/drivers/tty/serial/sh-sci.c
===
--- tty.orig/drivers/tty/serial/sh-sci.c
+++ tty/drivers/tty/serial/sh-sci.c
@@ -3073,8 +3073,7 @@ static struct plat_sci_port *sci_parse_d
p->type = SCI_OF_TYPE(match->data);
p->regtype = SCI_OF_REGTYPE(match->data);
 
-   if (of_find_property(np, "uart-has-rtscts", NULL))
-   sp->has_rtscts = true;
+   sp->has_rtscts = of_property_read_bool(np, "uart-has-rtscts");
 
return p;
 }

[PATCH 3/4] net: sh_eth: constify platform_device_id

[Arvind Yadav]

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by 
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav 
---
 drivers/net/ethernet/renesas/sh_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c 
b/drivers/net/ethernet/renesas/sh_eth.c
index d2dc0a8..d2e88a3 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -3402,7 +3402,7 @@ static const struct dev_pm_ops sh_eth_dev_pm_ops = {
 #define SH_ETH_PM_OPS NULL
 #endif
 
-static struct platform_device_id sh_eth_id_table[] = {
+static const struct platform_device_id sh_eth_id_table[] = {
{ "sh7619-ether", (kernel_ulong_t)_data },
{ "sh771x-ether", (kernel_ulong_t)_data },
{ "sh7724-ether", (kernel_ulong_t)_data },
-- 
2.7.4