rcar_gen3_phy_cable);
> + if (IS_ERR(channel->extcon))
> + return PTR_ERR(channel->extcon);
> +
> + ret = devm_extcon_dev_register(dev, channel->extcon);
> + if (ret < 0) {
> + dev_err(dev, "Failed to register extcon\n");
> + return ret;
> + }
> }
>
> /* devm_phy_create() will call pm_runtime_enable(dev); */
>
Looks good to me about extcon usgae.
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
Best Regards,
Chanwoo Choi
harles Keepax <ckee...@opensource.wolfsonmicro.com>
Cc: patc...@opensource.wolfsonmicro.com
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/extcon/devres.c |
Hi Peter,
2016-07-01 18:42 GMT+09:00 Peter Chen <peter.c...@nxp.com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Chanwoo Choi <cw00.c...@samsung.com>
> Cc: MyungJoo Ham <myungjoo@sa
Hi Peter,
Applied it.
Regards,
Chanwoo Choi
2016-07-01 18:41 GMT+09:00 Peter Chen <peter.c...@nxp.com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: MyungJoo Ham <myungjoo....@samsung.com>
&g
Hi Kishon,
On 2017년 01월 10일 17:16, Chanwoo Choi wrote:
> Hi Kishon,
>
> Could you review these patches or pick up them if there is no any comment?
If there are no comments, could you apply these patches?
>
> On 2016년 12월 30일 13:11, Chanwoo Choi wrote:
>> This
harles Keepax <ckee...@opensource.wolfsonmicro.com>
Cc: patc...@opensource.wolfsonmicro.com
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/extcon/devres.c|
Hi Sebastian,
On 2016년 12월 07일 12:05, Sebastian Reichel wrote:
> Hi Chanwoo,
>
> On Tue, Dec 06, 2016 at 09:26:14AM +0900, Chanwoo Choi wrote:
>> Could you please review and pick the patch3/4 for power-supply driver?
>
> Patches look fine. As I expect the merge windo
Hi Felipe,
These patches have already acked-by tag from you.
Could you please apply them if there is additional comment?
On 2016년 12월 30일 13:08, Chanwoo Choi wrote:
> This patches just replace the deprecated extcon API without any change
> of extcon operation and use the resource-m
Hi Kishon,
Could you review these patches or pick up them if there is no any comment?
On 2016년 12월 30일 13:11, Chanwoo Choi wrote:
> This patches just replace the deprecated extcon API without any change
> of extcon operation and use the resource-managed function for
> extcon_register
Hi Felipe,
2016-12-02 18:03 GMT+09:00 Felipe Balbi <ba...@kernel.org>:
>
> Hi,
>
> Chanwoo Choi <cw00.c...@samsung.com> writes:
>> Hi Felipe,
>>
>> On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>>
Hi Felipe,
On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>
> Hi,
>
> Chanwoo Choi <cw00.c...@samsung.com> writes:
>> This patch uses the resource-managed extcon API for
>> extcon_register_notifier()
>> and replaces the deprecated extcon API as fol
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/phy/phy-tahvo.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/driver
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/chipidea/co
This patch just uses the resource-managed extcon API when registering
the extcon notifier.
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/musb/sunxi.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/musb/sunxi.c b/drivers/us
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/power/supply/axp288_charg
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/phy/phy-msm-u
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/dwc3/dwc3-omap.c | 20 +++---
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Cc: Kishon Vijay Abraham I <kis...@ti.com>
Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
Cc: Chen-Yu Tsai <w...@csie.org>
Signed-off-by: Chanwoo Choi &
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/phy/phy-rcar-gen3-usb2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/driver
te_() -> extcon_get_state();
The each patch has not any dependency among patches. So, each maintainer
could pick up each patch without any problem.
Chanwoo Choi (12):
phy: rcar-gen3-usb2: Replace the deprecated extcon API
phy: sun4i-usb: Replace the deprecated extcon API
power_supply: axp288_c
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/phy/phy-qcom-8x16-usb.c | 13 ---
This patch replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/renesas_usbhs/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/rene
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/power/supply/qcom_smbb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pow
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
drivers/usb/phy/phy-omap-o
On 2016년 12월 06일 01:32, Bin Liu wrote:
> On Wed, Nov 30, 2016 at 09:45:03AM +0100, Maxime Ripard wrote:
>> On Wed, Nov 30, 2016 at 02:57:35PM +0900, Chanwoo Choi wrote:
>>> This patch just uses the resource-managed extcon API when registering
>>> the extcon notifier.
>
Hi Kishon,
Could you review and pick the patch1/2 for phy driver?
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 14:57, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_set_state_sync()
>
> Signed-off-by: Cha
Hi Sebastian,
Could you please review and pick the patch3/4 for power-supply driver?
Best Regards,
Chanwoo Choi
On 2016년 11월 30일 14:57, Chanwoo Choi wrote:
> This patch uses the resource-managed extcon API for extcon_register_notifier()
> and replaces the deprecated extcon API as fol
, 7 insertions(+), 31 deletions(-)
I agree. Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
<>
Hi Felipe,
On 2016년 12월 02일 18:03, Felipe Balbi wrote:
>
> Hi,
>
> Chanwoo Choi <cw00.c...@samsung.com> writes:
>> Hi Felipe,
>>
>> On 2016년 11월 30일 19:36, Felipe Balbi wrote:
>>>
>>> Hi,
>>>
>>> Chanwoo Choi <cw00.c..
te_() -> extcon_get_state();
Changes from v1:
- Rebase these patches based on v4.10-rc1.
- Drop the usb/power-supply/chipidea patches.
Chanwoo Choi (2):
phy: rcar-gen3-usb2: Replace the deprecated extcon API
phy: sun4i-usb: Replace the deprecated extcon API
drivers/phy/phy-rcar-gen3-usb2
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Cc: Kishon Vijay Abraham I <kis...@ti.com>
Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
Cc: Chen-Yu Tsai <w...@csie.org>
Signed-off-by: Chanwoo Choi &
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Acked-by: Felipe Balbi <felipe.ba...@lin
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/phy-rcar-gen3-usb2.c | 8
Hi Felipe,
On 2016년 12월 30일 11:46, Chanwoo Choi wrote:
> Hi Felipe,
>
> On 2016년 12월 02일 18:03, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Chanwoo Choi <cw00.c...@samsung.com> writes:
>>> Hi Felipe,
>>>
>>> On 2016년 11월 30일 19:36
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Acked-by: Felipe Balbi <felipe.ba...@lin
This patch uses the resource-managed extcon API for extcon_register_notifier()
and replaces the deprecated extcon API as following:
- extcon_get_cable_state_() -> extcon_get_state()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Acked-by: Felipe Balbi <felipe.ba...@lin
te_() -> extcon_get_state();
Changes from v1:
- Rebase these patches based on v4.10-rc1.
- Add acked-by tag from usb maintainer and reviewer.
- Drop the phy/power-supply/chipidea patches.
Chanwoo Choi (6):
usb: dwc3: omap: Replace the extcon API
usb: phy: msm: Replace the extcon API
usb: phy: om
This patch replaces the deprecated extcon API as following:
- extcon_set_cable_state_() -> extcon_set_state_sync()
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com>
---
drivers/usb/phy/phy-tahvo.c | 10 +-
1
Acked-by: Charles Keepax <ckee...@opensource.cirrus.com>
Acked-by: Lee Jones <lee.jo...@linaro.org>
Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com>
---
Changes from v1:
- Don't touch drivers/usb/renesas_usbhs/common.h.
- Add acked-by from Sebastian Reichel (for drivers/power/supply/)
- Add
external connector
Cc: Felipe Balbi <ba...@kernel.org>
Cc: Kishon Vijay Abraham I <kis...@ti.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Sebastian Reichel <s...@kernel.org>
Cc: Lee Jones <lee.jo...@linaro.org>
Signed-off-by: Chanwoo Choi <cw00.c...
Hi,
On 2017년 09월 29일 11:03, Yoshihiro Shimoda wrote:
> Hi,
>
>> From: Chanwoo Choi
>> Sent: Friday, September 29, 2017 9:02 AM
>>
> < snip >
>> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +-
> < snip >
>> drivers/usb/gadget/udc/
Dear Kishon,
Could you please review this patch?
After that, I'll make the immutable brand and then send the pull request
for power_supply, mfd, phy, usb and extcon framework.
On 2017년 10월 10일 19:17, Chanwoo Choi wrote:
> The extcon has two type of extcon devices as following.
> - '
Gently Ping.
Dear Kishon,
Could you please review this patch for 'drivers/phy/*'?
Regards,
Chanwoo Choi
On 2017년 10월 12일 12:40, Chanwoo Choi wrote:
> Dear Kishon,
>
> Could you please review this patch?
> After that, I'll make the immutable brand and then send the
Dear all,
I got the reviews from all maintainers related to this patch.
So, I make the immutable branch on extcon.git and then send
the pull request in order to prevent the possible merge conflict.
Best Regards,
Chanwoo Choi
Samsung Electronics
The following changes since commit
On 2018년 04월 13일 10:09, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 04월 10일 21:43, Wolfram Sang wrote:
>> Since commit eca0f13c836a ("extcon: int3496: Ignore incorrect
>> IoRestriction for ID pin"), the driver doesn't use GPIOF_* flags
>> anymore. We can thus
c
> @@ -20,7 +20,7 @@
>
> #include
> #include
> -#include
> +#include
> #include
> #include
> #include
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
dev);
> + struct s3c24xx_dclk *s3c24xx_dclk = dev_get_drvdata(dev);
>
> writel_relaxed(s3c24xx_dclk->reg_save, s3c24xx_dclk->base);
> return 0;
>
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
47 matches
Mail list logo
