Re: [PATCH v4 3/8] media: rcar_vin: Use correct pad number in try_fmt

2016-06-28 Thread Mauro Carvalho Chehab
Em Wed, 11 May 2016 16:02:51 +0200 Ulrich Hecht escreveu: > Fix rcar_vin_try_fmt's use of an inappropriate pad number when calling > the subdev set_fmt function - for the ADV7612, IDs should be non-zero. > > Signed-off-by: William Towle

Re: [PATCH v2 05/13] v4l: vsp1: Add FCP support

2016-06-17 Thread Mauro Carvalho Chehab
Em Tue, 26 Apr 2016 00:36:30 +0300 Laurent Pinchart escreveu: > On some platforms the VSP performs memory accesses through an FCP. When > that's the case get a reference to the FCP from the VSP DT node and > enable/disable it at runtime as needed. > >

[PATCH] [media] vsp1_drm.h: add missing prototypes

2016-02-19 Thread Mauro Carvalho Chehab
vsp1_du_atomic_flush(struct device *dev) ^ Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/media/platform/vsp1/vsp1_drm.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/vsp1/vsp1_drm.h b/drivers/media/platform/vsp1/vsp1_drm.h

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-18 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 10:28:35 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Tue, Mar 15, 2016 at 12:55:35PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 14:09:09 +0200 > > Sakari Ailus <sakari.ai...@iki.fi>

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Mauro Carvalho Chehab
(), > > media_create_intf_link() and media_devnode_create(). > > > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com> > > Suggested-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> > > What's the use case for calling the above functions in an atomic

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-14 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 12:52:54 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 07:13:58AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 09:22:37 +0200 > > Sakari Ailus <sakari.ai...@iki.fi>

Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context

2016-03-15 Thread Mauro Carvalho Chehab
Em Mon, 14 Mar 2016 14:09:09 +0200 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > On Mon, Mar 14, 2016 at 08:46:33AM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 14 Mar 2016 12:52:54 +0200 > > Sakari Ailus <sakari.ai...@iki.fi>

Re: [PATCH] [media] media: rename media unregister function

2016-03-19 Thread Mauro Carvalho Chehab
Em Fri, 18 Mar 2016 16:20:19 +0200 Sakari Ailus <sakari.ai...@linux.intel.com> escreveu: > Shuah Khan wrote: > > On 03/18/2016 08:12 AM, Javier Martinez Canillas wrote: > >> Hello Shuah, > >> > >> On 03/18/2016 11:01 AM, Shuah Khan wrote: > >

[PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-19 Thread Mauro Carvalho Chehab
that media_device_unregister() will do the right thing, if the media device is not fully initialized. Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/media/common/siano/smsdvb-main.c | 1 - drivers/media/media-device.c | 13 ++--- drivers/media/pci/saa7134/s

Re: [PATCH 5/5] [media] media-device: make media_device_cleanup() static

2016-03-19 Thread Mauro Carvalho Chehab
Em Wed, 16 Mar 2016 11:03:38 -0300 Javier Martinez Canillas <jav...@dowhile0.org> escreveu: > Hello Mauro, > > The patch looks mostly good to me, I just have a question below: > > On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab > <mche...@osg.sam

[PATCH] [media] vsp1: make vsp1_drm_frame_end static

2016-04-13 Thread Mauro Carvalho Chehab
nager in the WPF") Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/drivers/media/platform/vsp1/vsp1_drm.c index 22f67360b7

Re: V4L2 SDR compliance test?

2016-05-09 Thread Mauro Carvalho Chehab
Em Mon, 9 May 2016 13:59:52 + Ramesh Shanmugasundaram escreveu: > Hi Mauro, > > Thanks for the clarifications. > > > Ramesh Shanmugasundaram escreveu: > > > > > Hi Maintainers, All, > > > > > > Renesas

Re: [PATCH v2 2/4] v4l: Define a pixel format for the R-Car VSP1 1-D histogram engine

2016-09-06 Thread Mauro Carvalho Chehab
Hi Laurent, Em Wed, 17 Aug 2016 15:20:28 +0300 Laurent Pinchart escreveu: > The format is used on the R-Car VSP1 video queues that carry > 1-D histogram statistics data. > > Signed-off-by: Laurent Pinchart >

Re: [PATCH v2 2/4] v4l: Define a pixel format for the R-Car VSP1 1-D histogram engine

2016-09-06 Thread Mauro Carvalho Chehab
Em Tue, 06 Sep 2016 21:11:10 +0300 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > On Tuesday 06 Sep 2016 14:06:51 Mauro Carvalho Chehab wrote: > > Em Wed, 17 Aug 2016 15:20:28 +0300 Laurent Pinchart escreveu: > > > The format i

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

2016-09-19 Thread Mauro Carvalho Chehab
Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu: > Cropping on the WPF sink pad restricts the left and top coordinates to > 0-255. The same result can be obtained by cropping on the RPF without > any such restriction, this feature isn't

[PATCH] [media] vsp1: fix CodingStyle violations on multi-line comments

2016-09-19 Thread Mauro Carvalho Chehab
Several multi-line comments added at the vsp1 patch series violate the Kernel CodingStyle. Fix them. Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/platform/vsp1/vsp1_bru.c| 3 ++- drivers/media/platform/vsp1/vsp1_clu.c| 3 ++- drivers/media/pl

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

2016-09-19 Thread Mauro Carvalho Chehab
Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote: > > Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu: > > > Cropping on the W

Re: [PATCH] [media] vsp1: fix CodingStyle violations on multi-line comments

2016-09-19 Thread Mauro Carvalho Chehab
Em Mon, 19 Sep 2016 21:35:36 +0300 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > > On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote: > > Several multi-line comments added at the vsp1 patch

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

2016-09-19 Thread Mauro Carvalho Chehab
Em Mon, 19 Sep 2016 21:33:13 +0300 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > On Monday 19 Sep 2016 15:26:15 Mauro Carvalho Chehab wrote: > > Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu: > > > On Monday 19 Se

Re: [PATCH v3 1/8] v4l: Add metadata buffer type and format

2017-04-10 Thread Mauro Carvalho Chehab
Em Tue, 28 Feb 2017 17:56:41 +0200 Laurent Pinchart escreveu: > The metadata buffer type is used to transfer metadata between userspace > and kernelspace through a V4L2 buffers queue. It comes with a new > metadata capture capability and format

Re: [PATCH v3 1/8] v4l: Add metadata buffer type and format

2017-04-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Apr 2017 19:58:46 +0200 Hans Verkuil <hverk...@xs4all.nl> escreveu: > On 04/10/2017 07:23 PM, Mauro Carvalho Chehab wrote: > > Em Tue, 28 Feb 2017 17:56:41 +0200 > > Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> escreveu: > > >

Re: [PATCH v2.3] v4l: Clearly document interactions between formats, controls and buffers

2017-04-10 Thread Mauro Carvalho Chehab
Em Mon, 6 Mar 2017 16:14:41 +0200 Laurent Pinchart escreveu: > V4L2 exposes parameters that influence buffers sizes through the format > ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT, VIDIOC_S_FMT, and possibly > VIDIOC_G_SELECTION and VIDIOC_S_SELECTION).

Re: [PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API

2017-07-20 Thread Mauro Carvalho Chehab
t; > blend unit > > > * sinks, even if the configuration will be overwritten later by > > > - * vsp1_du_setup_rpf(). This ensures that the BRU configuration is set to > > > a well > > > - * defined state. > > > + * vsp1_du_setup_rpf(). This ensures that the blend unit configuration is > > > set to > > > + * a well defined state. > > > > I presume those comment updates for the BRU/ blend-unit configuration are > > actually for the next patch - but I don't think it matters here - and isn't > > worth the effort to move the hunks. > > Too late, I've fixed it already :-) Thanks for pointing it out. Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 07/14] v4l: vsp1: Add support for the BRS entity

2017-07-20 Thread Mauro Carvalho Chehab
> to be supported by the hardware but isn't implemented yet as it isn't > > the primary use case for the BRS. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 10/14] v4l: vsp1: Add support for multiple DRM pipelines

2017-07-20 Thread Mauro Carvalho Chehab
sp_drm_pipeline object that models one > display pipeline. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 01/14] v4l: vsp1: Fill display list headers without holding dlm spinlock

2017-07-20 Thread Mauro Carvalho Chehab
Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 03/14] v4l: vsp1: Don't set WPF sink pointer

2017-07-20 Thread Mauro Carvalho Chehab
Pinchart <laurent.pinchart+rene...@ideasonboard.com> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 09/14] v4l: vsp1: Add support for multiple LIF instances

2017-07-20 Thread Mauro Carvalho Chehab
y available on Gen2 hardware, isn't supported by the rest of the > > driver, and has no known use case, so this isn't an issue. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > > > This looks good. > > Reviewed-by: Kier

Re: [PATCH v2 02/14] v4l: vsp1: Don't recycle active list at display start

2017-07-20 Thread Mauro Carvalho Chehab
hart+rene...@ideasonboard.com> > > > > Ok, I had skipped this one as I was concerned about its effects in relation to > 11/14 but I see how that's working now. > > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 05/14] v4l: vsp1: Don't create links for DRM pipeline

2017-07-20 Thread Mauro Carvalho Chehab
directly. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > > > > A whole function removed ... always love code removal... > > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 11/14] v4l: vsp1: Add support for header display lists in continuous mode

2017-07-20 Thread Mauro Carvalho Chehab
ned-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 04/14] v4l: vsp1: Store source and sink pointers as vsp1_entity

2017-07-20 Thread Mauro Carvalho Chehab
rt+rene...@ideasonboard.com> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2.1 08/14] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances

2017-07-20 Thread Mauro Carvalho Chehab
vice info table. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH v2 3/3] drm: rcar-du: Repair vblank for DRM page flips using the VSP

2017-07-20 Thread Mauro Carvalho Chehab
ed > anymore, so we can stop enabling it. > > Fixes: d503a43ac06a ("drm: rcar-du: Register a completion callback with VSP1") > Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-20 Thread Mauro Carvalho Chehab
Em Wed, 19 Jul 2017 11:02:01 -0500 Rob Herring escreveu: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: > > On 07/18/2017 11:43 PM, Rob Herring wrote: > >> Now that we have a custom printf format specifier, convert users of > >>

Re: [PATCH 0/2] media: entity: add operation to help map DT node to media pad

2017-04-28 Thread Mauro Carvalho Chehab
Hi Niklas, Em Fri, 28 Apr 2017 00:33:21 +0200 Niklas Söderlund escreveu: > Hi, > > This small series add a new entity operation which will aid capture > drivers to map a port/endpoint in DT to a media graph pad. I looked > around and in my experience

Re: [PATCH v4 4/4] drm: rcar-du: Register a completion callback with VSP1

2017-05-18 Thread Mauro Carvalho Chehab
com> > Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> For all parts of this series that touch drivers/media: Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > ---

Re: [PATCH v2 1/2] v4l: vsp1: Add support for colorkey alpha blending

2017-06-07 Thread Mauro Carvalho Chehab
RM, from my side, feel free to merge this via DRM tree. Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > --- > drivers/media/platform/vsp1/vsp1_drm.c | 3 +++ > drivers/media/platform/vsp1/vsp1_rpf.c | 10 -- > drivers/media/platform/vsp1/vsp1_rwpf.h |

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

2017-06-08 Thread Mauro Carvalho Chehab
Em Mon, 29 May 2017 14:02:02 +0200 Wolfram Sang escreveu: > >Why "soc_camera:" in the subject? > > I used 'git log $file' and copied the most recent entry. Do I need to > resend? > No need to resend. I'll fix it when applying the patch. Btw, I'm seeing only patches

Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support

2017-06-08 Thread Mauro Carvalho Chehab
Em Thu, 8 Jun 2017 09:42:43 + Ramesh Shanmugasundaram escreveu: > > Subject: Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support > > > > Em Wed, 31 May 2017 09:44:53 +0100 > > Ramesh Shanmugasundaram

Re: [PATCH v4] v4l: subdev: tolerate null in media_entity_to_v4l2_subdev

2017-06-08 Thread Mauro Carvalho Chehab
Em Wed, 7 Jun 2017 10:52:07 +0100 Kieran Bingham escreveu: > From: Kieran Bingham > > Return NULL, if a null entity is parsed for it's v4l2_subdev > > Signed-off-by: Kieran Bingham Could

Re: [PATCH v6 3/7] media: i2c: max2175: Add MAX2175 support

2017-06-07 Thread Mauro Carvalho Chehab
Em Wed, 31 May 2017 09:44:53 +0100 Ramesh Shanmugasundaram escreveu: > +++ b/Documentation/media/v4l-drivers/max2175.rst > @@ -0,0 +1,60 @@ > +Maxim Integrated MAX2175 RF to bits tuner driver > + > + > +The

Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling

2017-09-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Sep 2017 19:18:40 +0200 Wolfram Sang escreveu: > Hi Mauro, > > > > +Linux I2C and DMA > > > +- > > > > I would use, instead: > > > > = > > Linux I2C and DMA > > = > > > > As this is the way we're starting

Re: [RFC PATCH v5 3/6] i2c: add docs to clarify DMA handling

2017-09-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Sep 2017 20:59:53 +0200 Wolfram Sang <wsa+rene...@sang-engineering.com> escreveu: > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Documentation looks OK on my eyes. So: Reviewed-by: Mauro Carvalho Chehab <mche...@s-opensource.com> > ---

Re: [PATCH 00/24] V4L2 kAPI cleanups and documentation improvements part 2

2017-10-09 Thread Mauro Carvalho Chehab
Em Mon, 9 Oct 2017 07:19:06 -0300 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > That's the second part of my V4L2 kAPI documentation improvements. > It is meant to reduce the gap between the kAPI media headers > and documentation, at least with regards to ker

Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling

2017-09-08 Thread Mauro Carvalho Chehab
Em Fri, 8 Sep 2017 10:56:40 +0200 Wolfram Sang escreveu: > Hi Mauro, > > thanks for your comments. Much appreciated! > > > There are also a couple of things here that Sphinx would complain. > > So, it could be worth to rename it to *.rst, while you're writing > > it, and

Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling

2017-09-09 Thread Mauro Carvalho Chehab
Em Sat, 9 Sep 2017 17:27:06 +0200 Wolfram Sang escreveu: > > Yes, but the statistics that 10% of I2C bus master drivers > > are DMA-safe is not true, if you take those into account ;-) > > > > Perhaps you could write it as (or something similar): > > > > At this time of

[PATCH 0/3] document types of hardware control for V4L2

2017-08-25 Thread Mauro Carvalho Chehab
On 2010, we introduced a new way to control complex V4L2 devices used on embedded systems, but this was never documented, nor it is possible for an userspace applicatin to detect the kind of control a device supports. This series fill the gap. Mauro Carvalho Chehab (3): media: open.rst

[PATCH 3/3] media: add V4L2_CAP_VDEV_CENTERED flag on vdev-centric drivers

2017-08-25 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mche...@osg.samsung.com> Those devices are controlled via their V4L2 device. Add a flag to indicate them as such. Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> ---

Re: [RFC PATCH v4 3/6] i2c: add docs to clarify DMA handling

2017-08-27 Thread Mauro Carvalho Chehab
Em Thu, 17 Aug 2017 16:14:46 +0200 Wolfram Sang escreveu: > Signed-off-by: Wolfram Sang > --- > Documentation/i2c/DMA-considerations | 50 > > 1 file changed, 50 insertions(+) > create

[PATCH 04/24] media: v4l2-mediabus: convert flags to enums and document them

2017-10-09 Thread Mauro Carvalho Chehab
-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/adv7180.c| 10 +- drivers/media/i2c/ml86v7667.c | 5 +- drivers/media/i2c/mt9m111.c| 8 +- drivers/media/i2c/ov6650.c

[PATCH 00/24] V4L2 kAPI cleanups and documentation improvements part 2

2017-10-09 Thread Mauro Carvalho Chehab
of those APIs (VB2 being likely the first candidate), but at least let's be sure that all V4L2 bits have kernel-doc markups. Mauro Carvalho Chehab (24): media: v4l2-dev.h: add kernel-doc to two macros media: v4l2-flash-led-class.h: add kernel-doc to two ancillary funcs media: v4l2-mediabus: use BIT

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

2017-11-23 Thread Mauro Carvalho Chehab
Hi Laurent, Em Thu, 16 Nov 2017 02:33:48 +0200 Laurent Pinchart escreveu: > Device unplug being asynchronous, it naturally races with operations > performed by userspace through ioctls or other file operations on video > device nodes. > > This leads

[PATCH 19/22] media: drivers: remove "/**" from non-kernel-doc comments

2017-11-29 Thread Mauro Carvalho Chehab
Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/dvb-frontends/sp887x.c | 6 +++--- drivers/media/dvb-frontends/tua6100.c | 2 +- drivers/media/dvb-frontends/zl10036.c | 8 drivers/media/i2c/ov5647.c

[PATCH 16/22] media: vsp1: add a missing kernel-doc parameter

2017-11-29 Thread Mauro Carvalho Chehab
Fix this warning: drivers/media/platform/vsp1/vsp1_dl.c:87: warning: No description found for parameter 'has_chain' Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH 5/8] media: v4l2-mediabus: convert flags to enums and document them

2017-12-18 Thread Mauro Carvalho Chehab
Verkuil <hans.verk...@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/adv7180.c| 10 +- drivers/media/i2c/ml86v7667.c | 5 +- drivers/media/i2c/mt9m111.c| 8 +- d

[PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-18 Thread Mauro Carvalho Chehab
easier to document it, as we don't need to document weird senseless structs. At drivers, this makes even clearer about the match criteria. Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/platform/a

[PATCH v2 5/8] media: v4l2-mediabus: convert flags to enums and document them

2017-12-19 Thread Mauro Carvalho Chehab
Verkuil <hans.verk...@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/i2c/adv7180.c| 10 +- drivers/media/i2c/ml86v7667.c | 5 +- drivers/media/i2c/mt9m111.c| 8 +- d

[PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-19 Thread Mauro Carvalho Chehab
e-electrons.com> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/platform/am437x/am437x-vpfe.c| 6 +++--- drivers/media/platform/atme

Re: [PATCH 5/8] media: v4l2-mediabus: convert flags to enums and document them

2017-12-19 Thread Mauro Carvalho Chehab
Em Tue, 19 Dec 2017 10:30:15 +0100 Philipp Zabel <p.za...@pengutronix.de> escreveu: > Hi Mauro, > > On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote: > > There is a mess with media bus flags: there are two sets of > > flags, one used by parall

Re: [PATCH 00/24] V4L2 kAPI cleanups and documentation improvements part 2

2017-12-18 Thread Mauro Carvalho Chehab
Em Mon, 9 Oct 2017 07:19:06 -0300 Mauro Carvalho Chehab <mche...@s-opensource.com> escreveu: > That's the second part of my V4L2 kAPI documentation improvements. > It is meant to reduce the gap between the kAPI media headers > and documentation, at least with regards to ker

Re: [PATCH v2 13/17] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-18 Thread Mauro Carvalho Chehab
Em Sat, 30 Sep 2017 01:05:24 +0300 Sakari Ailus <sakari.ai...@iki.fi> escreveu: > Hi Mauro, > > (Removing the non-list recipients.) > > On Fri, Sep 29, 2017 at 06:27:13AM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 28 Sep 2017 15:09:21 +0300 > > Sakari Ail

Re: [PATCH 04/24] media: v4l2-mediabus: convert flags to enums and document them

2017-12-18 Thread Mauro Carvalho Chehab
Em Wed, 11 Oct 2017 23:26:44 +0200 Pavel Machek <pa...@ucw.cz> escreveu: > On Mon 2017-10-09 07:19:10, Mauro Carvalho Chehab wrote: > > There is a mess with media bus flags: there are two sets of > > flags, one used by parallel and ITU-R BT.656 outputs, > &g

[PATCH v2 13/26] media: rcar: fix a debug printk

2017-11-01 Thread Mauro Carvalho Chehab
L2 OF not V4L2 fwnode API") Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> --- drivers/media/platform/rcar-vin/rcar-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rc

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

2017-12-12 Thread Mauro Carvalho Chehab
Em Thu, 23 Nov 2017 15:21:01 +0100 Greg Kroah-Hartman <gre...@linuxfoundation.org> escreveu: > On Thu, Nov 23, 2017 at 11:07:51AM -0200, Mauro Carvalho Chehab wrote: > > Hi Laurent, > > > > Em Thu, 16 Nov 2017 02:33:48 +0200 > > Laurent Pinchart <laure

Re: [PATCH] media: vsp1: cleanup a false positive warning

2018-05-04 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 16:37:23 +0200 Geert Uytterhoeven <ge...@linux-m68k.org> escreveu: > Hi Mauro, > > On Fri, May 4, 2018 at 2:13 PM, Mauro Carvalho Chehab > <mchehab+sams...@kernel.org> wrote: > > With the new vsp1 code changes introduced by changeset > > f81

Re: [PATCH] media: vsp1: cleanup a false positive warning

2018-05-07 Thread Mauro Carvalho Chehab
Em Mon, 07 May 2018 17:05:24 +0300 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 4 May 2018 15:13:58 EEST Mauro Carvalho Chehab wrote: > > With the new vsp1 code changes introduced by changes

[PATCH] media: vsp1: cleanup a false positive warning

2018-05-04 Thread Mauro Carvalho Chehab
be null (see line 180) This is a false positive, as, if pipe->bru is NULL, the brx var will be different, with ends by calling a code that will set pipe->bru to another value. Yet, cleaning this false positive is as easy as adding an explicit check if pipe->bru is NULL. Signed-off-by:

Re: [PATCH] v4l2-dev.h: fix symbol collision in media_entity_to_video_device()

2018-01-25 Thread Mauro Carvalho Chehab
Hi Niklas, Em Thu, 25 Jan 2018 01:34:30 +0100 Niklas Söderlund escreveu: > A recent change to the media_entity_to_video_device() macro breaks some > use-cases for the macro due to a symbol collision. Before the change > this worked: > > vdev =

Re: [PATCH v3 01/34] clk_ops: change round_rate() to return unsigned long

2018-01-03 Thread Mauro Carvalho Chehab
mplementations > that do not return an error code of < 0 will be left as-is. > > drivers/media/platform/omap3isp/isp.c | 4 ++-- Acked-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, Mauro

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-06 Thread Mauro Carvalho Chehab
Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF. > As ARCH_RENESAS implies OF, the latter can be dropped. > > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1

2018-03-06 Thread Mauro Carvalho Chehab
Em Tue, 06 Mar 2018 18:35:32 +0200 Laurent Pinchart <laurent.pinch...@ideasonboard.com> escreveu: > Hi Mauro, > > On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > > &