Re: [PATCH 4/8] clk: renesas: cpg-mssr: Add support for reset control

2017-01-20 Thread Philipp Zabel
optional? > This allows to reset SoC devices using the Reset Controller API. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Looks good to me, Acked-by: Philipp Zabel <p.za...@pengutronix.de> Just a small issue below, > --- > drivers/

Re: [PATCH v4 00/23] soc: renesas: Add R-Car RST driver for obtaining mode pin state

2016-10-21 Thread Philipp Zabel
A. Hi Geert, Am Freitag, den 21.10.2016, 15:17 +0200 schrieb Geert Uytterhoeven: > Hi Philipp, Mike, Stephen, Simon, Magnus, > (see questions *** below!) > > Currently the R-Car Clock Pulse Generator (CPG) drivers obtains the > state of the mode pins either by a call from the

Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-24 Thread Philipp Zabel
code did. > > This restores the display on r8a7740/armadillo. > > Fixes: 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial > power state to a separate function") > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Philipp Zabel &

Re: [PATCH] gpu: Convert to using %pOF instead of full_name

2017-07-19 Thread Philipp Zabel
er Martinez Canillas <jav...@osg.samsung.com> > Cc: Xinliang Liu <z.liuxinli...@hisilicon.com> > Cc: Rongrong Zou <zourongr...@gmail.com> > Cc: Xinwei Kong <kong.kongxin...@hisilicon.com> > Cc: Chen Feng <puck.c...@hisilicon.com> > Cc: CK Hu <ck...@media

Re: [PATCH v2 5/8] media: v4l2-mediabus: convert flags to enums and document them

2017-12-19 Thread Philipp Zabel
d, but, as both drivers > are obsolete and in the process of cleanings, I opted to just > keep the behavior, using an unsigned int inside those two > drivers. > > Acked-by: Hans Verkuil <hans.verk...@cisco.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> For imx-media, Acked-by: Philipp Zabel <p.za...@pengutronix.de> thanks Philipp

Re: [PATCH 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-19 Thread Philipp Zabel
i <s.nawro...@samsung.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Thanks, this does improve readability in the drivers. For imx-media, Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp > --- > drivers/media/platform/am437x/am437x

Re: [PATCH 5/8] media: v4l2-mediabus: convert flags to enums and document them

2017-12-19 Thread Philipp Zabel
Hi Mauro, On Mon, 2017-12-18 at 17:53 -0200, Mauro Carvalho Chehab wrote: > There is a mess with media bus flags: there are two sets of > flags, one used by parallel and ITU-R BT.656 outputs, > and another one for CSI2. > > Depending on the type, the same bit has different meanings. > > That's

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-22 Thread Philipp Zabel
Hi Geert, On Thu, 2018-02-22 at 09:50 +0100, Geert Uytterhoeven wrote: [...] > > > @@ -127,8 +134,15 @@ static int vfio_platform_get_reset(struct > > > vfio_platform_device *vdev) > > > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > > >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-21 Thread Philipp Zabel
Hi Geert, I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see below: On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the >

Re: [PATCH 5/5] drm: Don't pass clip to drm_atomic_helper_check_plane_state()

2018-01-23 Thread Philipp Zabel
t; v2: Convert armada, rcar, and sun4i as well > > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Brian Starkey <brian.star...@arm.com> > Cc: Mali DP Maintainers <mal...@foss.arm.com> > Cc: Daniel Vetter <daniel.vet...@intel.com> > Cc: Gustavo Padovan <gust...@

Re: [PATCH v2 2/2] vfio: platform: Add generic DT reset controller support

2018-04-11 Thread Philipp Zabel
t;No reset function found for device") if reset > controller support is disabled. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Philipp Zabel <p.za...@pengutronix.de> > --- > v2: > - Don't store error values in vdev->

Re: [PATCH v3 2/2] vfio: platform: Add generic DT reset support

2018-04-12 Thread Philipp Zabel
ex reset procedure can still > > > > > > provide > > > > > > a device-specific reset driver, as that takes precedence. > > > > > > > > > > > > Note that this functionality depends on CONFIG_RESET_CONTROLLER=y, >

Re: [PATCH v3 2/2] vfio: platform: Add generic DT reset support

2018-04-13 Thread Philipp Zabel
Hi Geert, On Thu, 2018-04-12 at 18:02 +0200, Geert Uytterhoeven wrote: > Hi Philipp, > > On Thu, Apr 12, 2018 at 4:10 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > On Thu, 2018-04-12 at 15:12 +0200, Geert Uytterhoeven wrote: > > > On Thu, Apr 12, 2

Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts

2018-02-27 Thread Philipp Zabel
behaviour doesn't > change when I start clear out the entire dynamic state with memset(). [...] > drivers/gpu/drm/imx/imx-ldb.c | 4 +- > drivers/gpu/drm/imx/parallel-display.c | 2 +- For imx-drm, Acked-by: Philipp Zabel <p.za...@pengutronix.de> regards Philipp

Re: [PATCH 1/2] dt-bindings: reset: rcar-rst: Document r8a774c0 rst

2018-09-14 Thread Philipp Zabel
ot;renesas,r8a774c0-rst" (RZ/G2E) > - "renesas,r8a7778-reset-wdt" (R-Car M1A) > - "renesas,r8a7779-reset-wdt" (R-Car H1) > - "renesas,r8a7790-rst" (R-Car H2) Acked-by: Philipp Zabel regards Philipp