Re: [PATCH] ata: sata_rcar: Add r8a77965 support

[Tejun Heo]

On Mon, Aug 06, 2018 at 08:05:06PM +0200, Wolfram Sang wrote:
> On Wed, Jul 25, 2018 at 09:16:55PM +0200, Wolfram Sang wrote:
> > Update the binding docs for Renesas R-Car M3-N. No driver changes are
> > needed.
> > 
> > Signed-off-by: Wolfram Sang 
> 
> Tejun, could you pick this also for 4.19?
> 
> Thanks for picking the other patches already!

Sure, applied to libata/for-4.19.

Thanks.

-- 
tejun

Re: [PATCH] ata: sata_rcar: really mask all interrupts on Gen2 and later

[Tejun Heo]

On Mon, Aug 06, 2018 at 12:40:05PM +0200, Wolfram Sang wrote:
> Since R-Car Gen2, a new bit has been introduced to the interrupt mask
> register. Update the code to handle it properly as well.
> 
> Signed-off-by: Wolfram Sang 

Applied to libata/for-4.19.

Thanks.

-- 
tejun

Re: [PATCH] ata: sata_rcar: exclude setting of PHY registers in Gen3

[Tejun Heo]

On Mon, Aug 06, 2018 at 12:42:00PM +0200, Wolfram Sang wrote:
> From: Masaharu Hayakawa 
> 
> According to documentation, setting of PHY registers is unnecessary with
> R-Car Gen3. The registers are not even described. So, don't initialize
> them.
> 
> Signed-off-by: Masaharu Hayakawa 
> [wsa: updated commit message]
> Signed-off-by: Wolfram Sang 

Applied to libata/for-4.19.

Thanks.

-- 
tejun

Re: [PATCH 1/2] ata: sata_rcar: Provide a short-hand for >dev

[Tejun Heo]

On Fri, Jul 20, 2018 at 02:27:38PM +0200, Geert Uytterhoeven wrote:
> No functional changes.
> 
> Signed-off-by: Geert Uytterhoeven 

Applied 1-2 to libata/for-4.19.

Thanks.

-- 
tejun

Re: [PATCH] ata: sata_rcar: Remove unused variable in sata_rcar_init_controller()

[Tejun Heo]

On Tue, Feb 13, 2018 at 01:43:23PM +0100, Geert Uytterhoeven wrote:
> drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller':
> drivers/ata/sata_rcar.c:821:8: warning: unused variable 'base' 
> [-Wunused-variable]
> 
> Fixes: da77d76b95a0e894 ("sata_rcar: Reset SATA PHY when Salvator-X board 
> resumes")
> Signed-off-by: Geert Uytterhoeven 

Applied to libata/for-4.16-fixes.

Thanks.

-- 
tejun

Re: [PATCH/RFT v3] sata_rcar: Reset SATA PHY when Salvator-X board resumes

[Tejun Heo]

On Mon, Feb 05, 2018 at 04:18:51AM +0900, Yoshihiro Kaneko wrote:
> From: Khiem Nguyen 
> 
> Because power of Salvator-X board is cut off in suspend,
> it needs to reset SATA PHY state in resume.
> Otherwise, SATA partition could not be accessed anymore.
> 
> Signed-off-by: Khiem Nguyen 
> Signed-off-by: Hien Dang 
> [reinit phy in sata_rcar_resume() function on R-Car Gen3 only]
> [factor out SATA module init sequence]
> [fixed the prefix for the subject]
> Signed-off-by: Yoshihiro Kaneko 

Applied to libata/for-4.16-fixes.

Thanks.

-- 
tejun

Re: [PATCH] ata: sata_rcar: add gen[23] fallback compatibility strings

[Tejun Heo]

On Tue, Jul 11, 2017 at 01:44:20PM +0200, Simon Horman wrote:
> Add fallback compatibility string for R-Car Gen 2 and 3.
> 
> In the case of Renesas R-Car hardware we know that there are generations of
> SoCs, e.g. Gen 1 and 2. But beyond that its not clear what the relationship
> between IP blocks might be. For example, I believe that r8a7790 is older
> than r8a7791 but that doesn't imply that the latter is a descendant of the
> former or vice versa.
> 
> We can, however, by examining the documentation and behaviour of the
> hardware at run-time observe that the current driver implementation appears
> to be compatible with the IP blocks on SoCs within a given generation.
> 
> For the above reasons and convenience when enabling new SoCs a
> per-generation fallback compatibility string scheme being adopted for
> drivers for Renesas SoCs.
> 
> Signed-off-by: Simon Horman 

Applied to libata/for-4.13-fixes.

Thanks.

-- 
tejun

Re: [PATCH/RFT] sata: rcar_sata: Reset SATA PHY on resume

[Tejun Heo]

On Tue, Apr 18, 2017 at 04:02:53PM +0900, Simon Horman wrote:
> In the case where power is cut on suspend the SATA PHY state needs to be
> suspended on resume.
  ^
  re-initialized?

> 
> This is the case on the Salvator-X board with the r8a7795 or r8a7796 SoC.
> In that environment it has been observed that SATA partitions cannot not be
> accessed on resume.
> 
> Based on work by Khiem Nguyen.
> 
> Cc: Khiem Nguyen 
> Signed-off-by: Simon Horman 
> ---
> * Compile and boot tested only

Can somebody verify this fix?

Thanks.

-- 
tejun

Re: [PATCH] ata: sata_rcar: Use ARCH_RENESAS

[Tejun Heo]

On Thu, Mar 03, 2016 at 10:28:50AM +0900, Simon Horman wrote:
> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE.
> 
> This is part of an ongoing process to migrate from ARCH_SHMOBILE to
> ARCH_RENESAS the motivation for which being that RENESAS seems to be a more
> appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs.
> 
> Signed-off-by: Simon Horman 

Applied to libata/for-4.6.

Thanks.

-- 
tejun

Re: rcar_sata DMA warnings on Salvator-X

[Tejun Heo]

Hello,

On Mon, Feb 29, 2016 at 02:44:16PM +0100, Geert Uytterhoeven wrote:
> sata_rcar ee30.sata: DMA-API: cpu touching an active dma mapped
> cacheline [cln=0x0090ff40]
> [ cut here ]
> WARNING: at lib/dma-debug.c:604
> Modules linked in:
> 
> CPU: 2 PID: 329 Comm: udevd Not tainted
...
> [] debug_dma_assert_idle+0x180/0x1d0
> [] wp_page_copy.isra.109+0xfc/0x57c
> [] handle_mm_fault+0x125c/0x1300
> [] do_page_fault+0x184/0x328
> [] do_mem_abort+0x40/0x9c

So, somehow udev has mmapped a page which is dma mapped and trying to
falut that in?

> Mapped at:
>  [] dma_entry_alloc+0x98/0xac
>  [] debug_dma_alloc_coherent+0x48/0xe0
>  [] dmam_alloc_coherent+0xa8/0xf8
>  [] ata_bmdma_port_start+0x40/0x5c
>  [] ata_host_start+0xf8/0x19c

And that region was originally allocated by ata_bmdma_port_start()?
The only thing which gets allocated there is the PRD table which is
the scatter-gather list for the DMA engine and has no reason to be
ever accessed from userland.  Any chance you can find out what udev is
doing at that point?

Thanks.

-- 
tejun

Re: rcar_sata DMA warnings on Salvator-X

[Tejun Heo]

On Thu, Feb 25, 2016 at 4:40 PM, Tejun Heo <t...@kernel.org> wrote:
> Is this the problem fixed by the following patch from Harvey?
>
>  
> http://lkml.kernel.org/g/CAMuHMdU0=_TJVfy=-zxwhkfjswh_fjulbrl8j9t60qs48wb...@mail.gmail.com

Oops, I meant

http://lkml.kernel.org/g/1456327003-16295-1-git-send-email-harvey.h...@imgtec.com

Thanks.

-- 
tejun

Re: rcar_sata DMA warnings on Salvator-X

[Tejun Heo]

Hello,

cc'ing Harvey.

On Wed, Feb 24, 2016 at 01:42:33PM +0100, Geert Uytterhoeven wrote:
> With CONFIG_DMA_API_DEBUG=y, I sometimes get the below warning
> on r8a7795/salvator-x. My tree is based on 
> renesas-drivers-2016-02-23-v4.5-rc5.
> 
> sata_rcar ee30.sata: DMA-API: cpu touching an active dma mapped
> cacheline [cln=0x0090fba0]
> [ cut here ]
> WARNING: at lib/dma-debug.c:604
> Modules linked in:
> 
> CPU: 3 PID: 1619 Comm: bash Tainted: GW
> 4.5.0-rc5-salvator-x-04682-g420edda42525a16f-dirty #541
> Hardware name: Renesas Salvator-X board based on r8a7795 (DT)
> task: ffc03bb30200 ti: ffc03b17 task.ti: ffc03b17
> PC is at debug_dma_assert_idle+0x180/0x1d0

Is this the problem fixed by the following patch from Harvey?

 
http://lkml.kernel.org/g/CAMuHMdU0=_TJVfy=-zxwhkfjswh_fjulbrl8j9t60qs48wb...@mail.gmail.com

Thanks.

-- 
tejun