Re: [PATCH v2] usb: gadget: function: printer: avoid wrong list handling in printer_write()

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> I'm not sure if you're still taking bug fixes for current -rc cycle, but if you are, please take this directly. If you're done with v4.17, please apply this on top of

RE: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write()

Hi, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > Hi, > >> From: Felipe Balbi, Sent: Monday, May 21, 2018 5:05 PM > >> seems like it would be better to just move this like before >> usb_ep_queue(): >> >> modified drivers/usb/gadg

RE: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write()

Hi, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > Hi, > >> From: Felipe Balbi, Sent: Monday, May 21, 2018 3:57 PM >> >> Hi, >> >> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: >> > The usb_ep_que

Re: [PATCH/RFC] usb: gadget: function: printer: avoid wrong list handling in printer_write()

Hi, Yoshihiro Shimoda writes: > The usb_ep_queue() in printer_write() is possible to call req->complete(). > In that case, since tx_complete() calls list_add(>list, >tx_reqs), > printer_write() should not call list_add(>list, >tx_reqs_active) > because the

RE: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

Hi, Biju Das <biju@bp.renesas.com> writes: > Hi, > >> -Original Message- >> From: devicetree-ow...@vger.kernel.org [mailto:devicetree- >> ow...@vger.kernel.org] On Behalf Of Felipe Balbi >> Sent: 17 October 2017 09:26 >> To: Biju Das <

Re: [PATCH] usb: renesas_usbhs: Add compatible string for r8a7743/5

Hi, Biju Das writes: > This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME] > (R8A7743/5) usbhs is identical to the R-Car Gen2 family. > > This doesn't change the driver, so it does nothing by itself. But it does > mean that checkpatch won't complain about

Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

ance > : Register/unregister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > > Cc: Felipe Balbi <ba...@kernel.org> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi

Re: [PATCH v2 3/3] usb: gadget: udc: renesas_usb3: add support for R-Car M3-W

Hi, Rob Herring writes: > On Fri, Aug 04, 2017 at 11:16:58AM +0900, Yoshihiro Shimoda wrote: >> This patch adds support for R-Car M3-W. This patch also adds R-Car >> Gen3 generic version's compatible and changes ".compatible" in >> the usb3_of_match from

RE: [PATCH 0/5] usb: gadget: udc: renesas_usb3: add DMAC support

Hi, Yoshihiro Shimoda writes: > Hi Felipe, > >> -Original Message- >> From: Yoshihiro Shimoda >> Sent: Wednesday, April 26, 2017 8:50 PM >> >> This patch set is based on the latest Feribe's usb.git / testing/next branch >> (the commit id =

Re: [PATCH v3 3/3] usb: gadget: udc: renesas_usb3: add support for usb role swap

Hi, Yoshihiro Shimoda writes: > This patch adds support for usb role swap via sysfs "role". > > For example: > 1) Connect a usb cable using 2 Salvator-X boards. > - For A-Device, the cable is connected to CN11 (USB3.0 ch0). > - For B-Device, the cable is

RE: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

Yoshihiro-san Yoshihiro Shimoda writes: >> >> Yoshihiro Shimoda writes: >> >> > Sadly, to change the role ("host" and "peripheral") of USB3.0 DRD >> >> > controller on R-Car Gen3, software has to set the DRD_CON register >> >>

RE: [PATCH 1/4] usb: gadget: udc: renesas_usb3: add sysfs "role" to set "b-device" mode

Hi, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > Hi Felipe-san, > >> From: Felipe Balbi, Sent: Tuesday, March 28, 2017 9:06 PM >> >> Hi, >> >> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: >> > Sadly, t

Re: [PATCH v2 1/6] usb: dwc3: omap: Replace the extcon API

i <cw00.c...@samsung.com> > Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> doesn't apply to testing/next. Please rebase -- balbi signature.asc Description: PGP signature

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > Hi Felipe, > > On 2016년 11월 30일 19:36, Felipe Balbi wrote: >> >> Hi, >> >> Chanwoo Choi <cw00.c...@samsung.com> writes: >>> This patch uses the resource-managed extcon API for >>

Re: [PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba.

Re: [PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba.

Re: [PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 08/12] usb: phy: msm: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 00/26] constify local structures

Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >>

RE: [PATCH 0/2] usb: renesas_usbhs: fix issues on specific situations

Yoshihiro Shimoda writes: > Hi Felipe, > > Would you review this patch set? both in my queue. -- balbi signature.asc Description: PGP signature

RE: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

Hi, Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: >> From: Felipe Balbi >> Sent: Wednesday, June 01, 2016 4:01 PM >> >> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: >> >> > I'm afraid but I found a regres

Re: [PATCH v2 0/2] usb: host: xhci: rcar: fix the quirks setting of XHCI_NO_64BIT_SUPPORT

Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > I'm afraid but I found a regression of xhci-rcar in v4.7-rc1. > This regression is caused by the following commit: > > commit b1c127ae990bccf0187d741c1695a61e54de1943 > Author: Felipe Balbi <felipe.ba...@linux.

Re: [PATCH v3] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

enable both CONFIG_USB_XHCI_PLATFORM > and CONFIG_USB_XHCI_RCAR. > > Fixes: 4ac8918f3a7 (usb: host: xhci-plat: add support for the R-Car H2 and M2 > xHCI controllers) > Cc: <sta...@vger.kernel.org> # v3.17+ > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com&g

RE: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Hi, Yoshihiro Shimoda writes: >> > Yoshihiro Shimoda writes: >> >> The firmware of R-Car USB 3.0 host controller will control the reset. >> >> So, if the xhci driver doesn't do firmware downloading (e.g. kernel >> >>

Re: [PATCH v2] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Hi, Yoshihiro Shimoda writes: > The firmware of R-Car USB 3.0 host controller will control the reset. > So, if the xhci driver doesn't do firmware downloading (e.g. kernel > configuration is CONFIG_USB_XHCI_PLATFORM=y and CONFIG_USB_XHCI_RCAR > is not set), the

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Hi, Yoshihiro Shimoda writes: >> > > And, kernel log is the following: >> > > >> > > [1.565605] xhci-hcd ee00.usb: xHCI Host Controller >> > > [1.570636] xhci-hcd ee00.usb: new USB bus registered, assigned >> > > bus number 5 >> > > [

Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Hi, Geert Uytterhoeven writes: > On Thu, Apr 21, 2016 at 12:27 PM, Yoshihiro Shimoda > wrote: >>> > [1.565605] xhci-hcd ee00.usb: xHCI Host Controller >>> > [1.570636] xhci-hcd ee00.usb: new USB bus registered, assigned

RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > Hi Felipe, > >> From: Felipe Balbi >> Sent: Thursday, April 21, 2016 7:05 PM >> >> Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: >> >> &

Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()

Yoshihiro Shimoda writes: > If kernel configuration is CONFIG_USB_XHCI_PLATFORM=y and > CONFIG_USB_XHCI_RCAR is not set, R-Car Gen2/3 will cause long wait > in xhci_reset() because such SoCs need specific initialization. where is the delay coming from exactly ?

Re: [PATCH v3 0/2] usb: host: xhci: add a new quirk and fix an issue for R-Car Gen2/3

> Yoshihiro Shimoda (2): > usb: host: xhci: add a new quirk XHCI_NO_64BIT_SUPPORT > usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB > phys for your entire series: Reviewed-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 2/2] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

Yoshihiro Shimoda writes: > [ text/plain ] > This patch fixes an issue that cannot work if R-Car Gen2/3 run on > above 4GB physical memory environment to use a quirk XHCI_CLEAR_AC64. > > Signed-off-by: Yoshihiro Shimoda > --- >

RE: [PATCH] usb: host: xhci-plat: fix cannot work if R-Car Gen2/3 run on above 4GB phys

Hi, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Mathias, > > Would you review this patch? > This patch could be applied into the latest usb.git / usb-next branch. > > Best regards, > Yoshihiro Shimoda > >> -Original Message- >> From: Yoshihiro

RE: [PATCH] usb: renesas_usbhs: gadget: fix giveback status code in usbhsg_pipe_disable()

Hi Yoshihiro, Yoshihiro Shimoda writes: > [ text/plain ] > Hi Felipe, > > Oops, I completely forgot this patch. > Would you review this patch? Or should I resend it? > I confirmed that this patch could be applied on your latest > testing/fixes branch. I don't