Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

| 12 +++- > drivers/net/ethernet/freescale/fec_main.c | 8 ++-- > drivers/net/ethernet/marvell/mvmdio.c | 5 + > drivers/net/ethernet/renesas/sh_eth.c | 11 +++ > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 5 +-

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

Hi Laurent, On 02-03-2017 15:38, Laurent Pinchart wrote: > Hi Jose, > > On Thursday 02 Mar 2017 14:50:02 Jose Abreu wrote: >> On 02-03-2017 13:41, Laurent Pinchart wrote: >>>> Hmm, this is kind of confusing. Why do you need a phy_ops and >>>> then a separat

Re: [PATCH v4 8/9] drm: bridge: dw-hdmi: Remove device type from platform data

Remove it. > > Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

Hi Laurent, On 02-03-2017 13:41, Laurent Pinchart wrote: > >> Hmm, this is kind of confusing. Why do you need a phy_ops and >> then a separate configure_phy function? Can't we just use phy_ops >> always? If its external phy then it would need to implement all >> phy_ops functions. > The phy_ops

Re: [PATCH v4 7/9] drm: bridge: dw-hdmi: Add support for custom PHY configuration

Hi Laurent, On 01-03-2017 22:39, Laurent Pinchart wrote: > From: Kieran Bingham > > The DWC HDMI TX controller interfaces with a companion PHY. While > Synopsys provides multiple standard PHYs, SoC vendors can also integrate > a custom PHY. > >

Re: [PATCH v4 5/9] drm: bridge: dw-hdmi: Fix the PHY power up sequence

oll loop > to the power off function. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 65 >

Re: [PATCH v4 6/9] drm: bridge: dw-hdmi: Create PHY operations

hart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 91 > > include/drm/bridge/dw_hdmi.h | 18 +++-

Re: [PATCH v4 4/9] drm: bridge: dw-hdmi: Fix the PHY power down sequence

ay. Retrying the read > five times with a 1ms to 2ms delay between each attempt should thus be > more than enough. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regar

Re: [PATCH v4 1/9] drm: bridge: dw-hdmi: Remove unused functions

Hi Laurent, On 01-03-2017 22:39, Laurent Pinchart wrote: > Most of the hdmi_phy_test_*() functions are unused. Remove them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regar

Re: [PATCH v4 2/9] drm: bridge: dw-hdmi: Move CSC configuration out of PHY code

Hi Laurent, On 01-03-2017 22:39, Laurent Pinchart wrote: > The color space converter isn't part of the PHY, move its configuration > out of PHY code. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synops

Re: [PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

Hi Laurent, Sorry for the delayed answer but I am quite busy at the moment. On 06-01-2017 01:48, Laurent Pinchart wrote: [snip] The TX_READY signal is documented in the i.MX6 datasheet as being a PHY output signal, but there seems to be no HDMI TX register from which its state

Re: [PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

Hi Laurent, On 05-01-2017 12:29, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: >> On 20-12-2016 11:45, Russell King - ARM Linux wrote: >>> On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >>>> Instea

Re: [PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

Hi Laurent, On 05-01-2017 11:44, Laurent Pinchart wrote: [snip] >>> I've tried moving SVSRET right before the reset and everything still seems >>> to work fine, so I'll submit a patch. >>> >>> Is the rest of the sequence correct ? When should SVSRET be deasserted >>> (the driver currently

Re: [PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

Hi Laurent, On 05-01-2017 00:15, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 15:01:52 Jose Abreu wrote: >> On 20-12-2016 13:11, Laurent Pinchart wrote: >>> On Tuesday 20 Dec 2016 11:39:21 Jose Abreu wrote: >>>> On 20-12-2016 01:33, Laurent

Re: [PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

Hi Laurent, On 20-12-2016 13:11, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 11:39:21 Jose Abreu wrote: >> On 20-12-2016 01:33, Laurent Pinchart wrote: >>> Detect the PHY type and use it to handle the PHY type-specific SVSRET >>> signal. >&g

Re: [PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

Hi Russell, On 20-12-2016 11:45, Russell King - ARM Linux wrote: > On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >> Instead of spreading version-dependent PHY power handling code around, >> group it in two functions to power the PHY on and off and use them >> through the

Re: [PATCH v2 16/29] drm: bridge: dw-hdmi: Detect PHY type at runtime

Hi Laurent, On 20-12-2016 01:33, Laurent Pinchart wrote: > Detect the PHY type and use it to handle the PHY type-specific SVSRET > signal. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 68 >

Re: [PATCH v2 15/29] drm: bridge: dw-hdmi: Handle overflow workaround based on device version

nt.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 46 > > 1 file changed, 33 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH v2 14/29] drm: bridge: dw-hdmi: Detect AHB audio DMA using correct register

rent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 6 +++--- > drivers/gpu/drm/bridge/dw-hdmi.h | 4 > 2 files changed, 7 insertions(+), 3 deletions(-) > >

Re: [PATCH v2 13/29] drm: bridge: dw-hdmi: Reject invalid product IDs

w register values. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 25 +++-- > drivers/gpu/drm/bridge/dw-hdmi.h | 8 > 2 f

Re: [PATCH 13/22] drm: bridge: dw-hdmi: Replace device type with platform quirks

Hi Laurent, On 05-12-2016 11:32, Laurent Pinchart wrote: > Hi Jose, > > On Monday 05 Dec 2016 10:50:19 Jose Abreu wrote: >> On 02-12-2016 15:43, Laurent Pinchart wrote: >>> On Friday 02 Dec 2016 14:24:01 Russell King - ARM Linux wrote: >>>> On Fri, Dec 0

Re: [PATCH 13/22] drm: bridge: dw-hdmi: Replace device type with platform quirks

Hi Laurent, On 02-12-2016 15:43, Laurent Pinchart wrote: > Hi Russell, > > On Friday 02 Dec 2016 14:24:01 Russell King - ARM Linux wrote: >> On Fri, Dec 02, 2016 at 01:43:28AM +0200, Laurent Pinchart wrote: >>> From: Kieran Bingham >>> >>> The dw-hdmi

Re: [PATCH 12/22] drm: bridge: dw-hdmi: Abstract the platform PHY configuration

Hi Laurent, On 01-12-2016 23:43, Laurent Pinchart wrote: > From: Kieran Bingham > > Platforms implement the dw-hdmi with a separate PHY entity. It is > configured over it's own I2C bus. To allow for different PHY's to be > configured from the dw-hdmi

Re: [PATCH 00/22] R-Car Gen3 HDMI output support

pu/drm/rcar-du/rcar_du_regs.h | 23 ++ > drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 105 ++ > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c| 17 +- > include/drm/bridge/dw_hdmi.h | 35 +- > 21 files changed, 765 insertions(+), 2

Re: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support

d this patch and everything seems ok. Should I give >> my tested-by? > Thank you for your test. I'm happy if it could have it. > > Mark, Thierry, Daniel > I wonder who can be maintainer for this patch ?? > > Best regards > --- > Kuninori Morimoto Tested-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu

Re: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support

Hi, On 24-06-2016 03:40, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current dw-hdmi is supporting sound via AHB bus, but it has > I2S audio feature too. This patch adds I2S audio support to dw-hdmi. > This HDMI I2S is supported by using ALSA SoC