[VSP-Tests PATCH 6/7] vsp-lib: Support late queuing of buffers in yavta

2018-12-04 Thread Kieran Bingham
Provide the pass-through option of --queue-late to vsp-runner, to request that yavta will queue frames after the stream has started. Signed-off-by: Kieran Bingham --- scripts/vsp-lib.sh | 4 1 file changed, 4 insertions(+) diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh index

[VSP-Tests PATCH 4/7] vsp-lib: trivial: Fix spelling of Reference

2018-12-04 Thread Kieran Bingham
Signed-off-by: Kieran Bingham --- scripts/vsp-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh index 56969606382f..cf15a045ea8c 100755 --- a/scripts/vsp-lib.sh +++ b/scripts/vsp-lib.sh @@ -95,7 +95,7 @@ vsp1_set_control

[VSP-Tests PATCH 2/7] tests: Provide copy test to validate 1xN streams

2018-12-04 Thread Kieran Bingham
-off-by: Kieran Bingham --- tests/vsp-unit-test-0025.sh | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vsp-unit-test-0025.sh diff --git a/tests/vsp-unit-test-0025.sh b/tests/vsp-unit-test-0025.sh new file mode 100755 index

[VSP-Tests PATCH 5/7] vsp-lib: Allow forcing pixel perfect comparisons

2018-12-04 Thread Kieran Bingham
Provide a means for the tester to request pixel perfect matches on tests. This can be either through setting the environment variable VSP_PIXEL_PERFECT, or by passing either '-p' or '--pixel-perfect' on the test command line. Signed-off-by: Kieran Bingham --- scripts/vsp-lib.sh | 11

[VSP-Tests PATCH 3/7] vsp-lib: Provide command line argument parsing

2018-12-04 Thread Kieran Bingham
Extend the vsp-lib to support command line parsing for all tests. The arguments parsed here should be common to all tests, and initially provide shell level verbose debug output, and the option to easily keep frames output by the VSP1. Signed-off-by: Kieran Bingham --- scripts/vsp-lib.sh | 34

[VSP-Tests PATCH 7/7] vsp-lib: Reset controls to defaults on each test run

2018-12-04 Thread Kieran Bingham
of every test during test_init() Signed-off-by: Kieran Bingham --- scripts/vsp-lib.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/scripts/vsp-lib.sh b/scripts/vsp-lib.sh index 3d2792707d24..33442816f208 100755 --- a/scripts/vsp-lib.sh +++ b/scripts/vsp-lib.sh @@ -94,6 +94,14

[VSP-Tests PATCH 1/7] tests: add pseudo platform test

2018-12-04 Thread Kieran Bingham
details in any test suite output for clarification of results. Signed-off-by: Kieran Bingham --- tests/vsp-unit-test-.sh | 20 1 file changed, 20 insertions(+) create mode 100755 tests/vsp-unit-test-.sh diff --git a/tests/vsp-unit-test-.sh b/tests/vsp-unit-test

[VSP-Tests PATCH 0/7] Reset controls and unloved patches

2018-12-04 Thread Kieran Bingham
un-reviewed or are still not yet integrated. Kieran Bingham (7): tests: add pseudo platform test tests: Provide copy test to validate 1xN streams vsp-lib: Provide command line argument parsing vsp-lib: trivial: Fix spelling of Reference vsp-lib: Allow forcing pixel perfect comparisons

Re: [GIT PULL FOR renesas-drivers] pinchartl-media/v4l2/vsp1/next

2018-09-14 Thread Kieran Bingham
Hi Geert, On 14/09/18 21:50, Kieran Bingham wrote: > Hi Geert, > > Please consider including this release in renesas-drivers. > > -- > Regards > > Kieran > > The following changes since commit 78cf8c842c111df656c63b5d04997ea4e40ef26a: > > media: drxj:

[GIT PULL FOR renesas-drivers] du/2018q3

2018-09-14 Thread Kieran Bingham
drm: rcar-du: Improve non-DPLL clock selection drm: rcar-du: Rename and document dpll_ch field drm: rcar-du: Write ESCR and OTAR as CRTC registers Kieran Bingham (7): MAINTAINERS: rcar-du: Add co-maintainer drm: rcar-du: Support interlaced video output through vsp1 dr

[GIT PULL FOR renesas-drivers] pinchartl-media/v4l2/vsp1/next

2018-09-14 Thread Kieran Bingham
) Kieran Bingham (5): MAINTAINERS: VSP1: Add co-maintainer media: vsp1: Remove artificial minimum width/height limitation media: vsp1: use periods at the end of comment sentences media: vsp1: Document max_width restriction on SRU media: vsp1: Document max_width restriction

Re: [PATCH 2/3] drm: rcar-du: Add pixel format support

2018-09-14 Thread Kieran Bingham
Hi Laurent, On 14/09/18 12:11, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > How about renaming the subject line to "Add support for missing pixel > formats" > ? > Ack. > On Friday, 31 August 2018 21:12:58 EEST Kieran

Salvator-XS-M3N SRU/HGT/COPY test fail

2018-08-31 Thread Kieran Bingham
Hi Laurent, I've had some interesting failures on the VSP1 tests on the M3-N board. - vsp-unit-test-0015.sh Testing SRU scaling from 1024x768 to 1024x768 in RGB24: fail Testing SRU scaling from 1024x768 to 2048x1536 in RGB24: fail Testing SRU scaling from 1024x768 to 1024x768 in YUV444M: fail

[VSP-Tests: PATCH v2] tests: Provide copy test to validate 1xN streams

2018-08-31 Thread Kieran Bingham
-off-by: Kieran Bingham --- tests/vsp-unit-test-0025.sh | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vsp-unit-test-0025.sh diff --git a/tests/vsp-unit-test-0025.sh b/tests/vsp-unit-test-0025.sh new file mode 100755 index

[VSP-Tests: PATCH] vsp-lib: Provide command line argument parsing

2018-08-31 Thread Kieran Bingham
Extend the vsp-lib to support command line parsing for all tests. The arguments parsed here should be common to all tests, and initially provide shell level verbose debug output, and the option to easily keep frames output by the VSP1. Signed-off-by: Kieran Bingham --- scripts/vsp-lib.sh | 34

[VSP-Tests: PATCH] tests: Provide copy test to validate 1xN streams

2018-08-31 Thread Kieran Bingham
-off-by: Kieran Bingham --- tests/vsp-unit-test-0025.sh | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vsp-unit-test-0025.sh diff --git a/tests/vsp-unit-test-0025.sh b/tests/vsp-unit-test-0025.sh new file mode 100755 index

[VSP-Tests: PATCH] tests: add pseudo platform test

2018-08-31 Thread Kieran Bingham
From: Kieran Bingham Provide an initial test which can run as part of the test suite. This test will report the platform and kernel version, along with the identified paths of required utilities. This will aid in ensuring that required tools are available on a running platform - and report

Re: Regarding VIN test(cvbs capture:- PAL resolution)

2018-08-29 Thread Kieran Bingham
Hi Biju, On 29/08/18 12:19, Biju Das wrote: > Hi Kieran, > > Thanks for the feedback. > >> Could you check to see the output of any of the following is correct: >> >> media-ctl -d /dev/media1 --get-v4l2 "'adv748x 4-0070 afe':0" >> .. (and 1,2,3,4,5,6 if necessary) >> media-ctl -d /dev/media1

Re: Regarding VIN test(cvbs capture:- PAL resolution)

2018-08-29 Thread Kieran Bingham
Hi Biju, On 29/08/18 11:41, Biju Das wrote: > Hi All, > >   > > I started testing vin on R-Car Gen3(CVBS  input from DVD player > connected to R-Car M3-W,kernel:-renesas-devel-20180827-4.19-rc1) > > based on the information present in https://elinux.org/R-Car/Tests:rcar-vin. > >   > > Looks

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-23 Thread Kieran Bingham
Hi Eugeniu, On 23/08/18 18:14, Eugeniu Rosca wrote: > Dear reviewers, > > On Thu, Aug 23, 2018 at 11:01:46AM +0200, Geert Uytterhoeven wrote: >> Hi Sergei, >> >> On Thu, Aug 23, 2018 at 10:56 AM Sergei Shtylyov >> wrote: >>> On 8/23/2018 11:52 AM, Geert Uytterhoeven wrote: >> According to

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Kieran Bingham
Hi Eugeniu, On 17/08/18 16:56, Eugeniu Rosca wrote: > Hello Kieran, > > On Fri, Aug 17, 2018 at 02:44:25PM +0100, Kieran Bingham wrote: >> Hi Eugeniu >> >> Thank you for the patch. >> >> On 12/08/18 14:31, Eugeniu Rosca wrote: >>> Document

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-17 Thread Kieran Bingham
support is inspired from below commits: > - v4.7 commit 308b7e4ba62e ("arm64: dts: r8a7795: Add CAN support") > - v4.11 commit 909c16252415 ("arm64: dts: r8a7796: Add CAN support") > - v4.12 commit bec0948e810f ("arm64: dts: r8a7796: Add reset control >

Re: [PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-17 Thread Kieran Bingham
Hi Eugeniu, On 06/08/18 21:14, Eugeniu Rosca wrote: > Hi Kieran, > > On Mon, Aug 06, 2018 at 12:11:22PM +0100, Kieran Bingham wrote: >> Hi Eugeniu, >> >> On 05/08/18 00:11, Eugeniu Rosca wrote: >>> According to R-Car Gen3 HW manual rev0.55E, R-Car M3-N has

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Kieran Bingham
. Rewrap text. I don't think you needed to say you rewrapped the text in the commit log - but it's fine :) > Signed-off-by: Eugeniu Rosca Reviewed-by: Kieran Bingham > --- > Changes in v2: > - [Kieran Bingham] Simplified commit description. Rewrapped text. > - [Sergei S

Re: [PATCH] arm64: dts: renesas: salvator-common: adv748x: Override secondary addresses

2018-08-10 Thread Kieran Bingham
Hi Simon, On 10/08/18 13:01, Simon Horman wrote: > On Tue, Aug 07, 2018 at 04:59:33PM +0100, Kieran Bingham wrote: >> Ensure that the ADV748x device addresses do not conflict, and group them >> together (visually in i2cdetect) > > Hi Kieran, > > could you help me ou

[PATCH] arm64: dts: renesas: salvator-common: adv748x: Override secondary addresses

2018-08-07 Thread Kieran Bingham
Ensure that the ADV748x device addresses do not conflict, and group them together (visually in i2cdetect) Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas

Re: [GIT PULL FOR renesas-drivers] gmsl/for-renesas-drivers

2018-08-07 Thread Kieran Bingham
Hi Geert On 07/08/18 13:04, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, Aug 7, 2018 at 1:25 PM Kieran Bingham > wrote: >> Please consider including this release in renesas-drivers. >> >> This brings in our GMSL developments for inclusion in renesas-drivers,

[GIT PULL FOR renesas-drivers] gmsl/for-renesas-drivers

2018-08-07 Thread Kieran Bingham
: i2c: max9286: [POC] Power down GPIO lines to enable the V3M cameras (2018-08-07 12:08:12 +0100) Jacopo Mondi (1): dt-bindings: media: i2c: Add bindings for IMI RDACM20 Kieran Bingham (6): Merge remote-tracking branch

Re: [PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-06 Thread Kieran Bingham
Hi Eugeniu, On 05/08/18 00:11, Eugeniu Rosca wrote: > According to R-Car Gen3 HW manual rev0.55E, R-Car M3-N has two CAN rev 0.55E sounds like rather an old version of this document. Do you have access to the later rev1.00 release? (Not an issue for this patch itself, I can confirm that

Re: [PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-06 Thread Kieran Bingham
Hi Eugeniu On 05/08/18 00:11, Eugeniu Rosca wrote: > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > checkpatch complained that the new compatible string > "renesas,can-r8a77965" is not documented. Fix the warning. > Thanks to the correct ordering of your patches, (you

Re: [PATCH 04/14] arm64: dts: renesas: r8a7795-es1: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-06 Thread Kieran Bingham
On 06/08/18 11:45, Kieran Bingham wrote: > Hi Laurent, Eugeniu, > > On 06/08/18 11:42, Laurent Pinchart wrote: >> Hi Eugeniu, >> >> Thank you for the patch. >> >> On Sunday, 5 August 2018 02:11:04 EEST Eugeniu Rosca wrote: >>> Following t

Re: [PATCH 04/14] arm64: dts: renesas: r8a7795-es1: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-06 Thread Kieran Bingham
Hi Laurent, Eugeniu, On 06/08/18 11:42, Laurent Pinchart wrote: > Hi Eugeniu, > > Thank you for the patch. > > On Sunday, 5 August 2018 02:11:04 EEST Eugeniu Rosca wrote: >> Following the recent change in dt-bindings [1], switch from >> "renesas,h3ulcb" to "renesas,ulcb" compatible string. >>

[PATCH] [HACK] serial: sh-sci: Hard code SCIF clocks

2018-06-15 Thread Kieran Bingham
Hard code the clock rates for the SCI_FCK clock to allow development of serial passthrough within virtualisation environments without clock support. Signed-off-by: Kieran Bingham --- drivers/tty/serial/sh-sci.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff

[PATCH] media: vsp1: Document vsp1_dl_body refcnt

2018-05-28 Thread Kieran Bingham
In commit 2d9445db0ee9 ("media: vsp1: Use reference counting for bodies"), a new field was introduced to the vsp1_dl_body structure to account for usage tracking of the body. Document the newly added field in the kerneldoc. Signed-off-by: Kieran Bingham <kieran.bing...@ide

Re: [PATCH 2/2] tests: suspend/resume: Increase number of processed frames

2018-05-21 Thread Kieran Bingham
On 21/05/18 10:09, Laurent Pinchart wrote: > Hi Kieran, > > On Monday, 21 May 2018 11:58:44 EEST Kieran Bingham wrote: >> On 21/05/18 09:51, Laurent Pinchart wrote: >>> On Monday, 21 May 2018 11:16:05 EEST Kieran Bingham wrote: >>>> On 19/05/18 21:34, Laure

Re: [PATCH 2/2] tests: suspend/resume: Increase number of processed frames

2018-05-21 Thread Kieran Bingham
On 21/05/18 09:51, Laurent Pinchart wrote: > Hi Kieran, > > On Monday, 21 May 2018 11:16:05 EEST Kieran Bingham wrote: >> Hi Laurent, >> >> Thank you for the patch, >> >> On 19/05/18 21:34, Laurent Pinchart wrote: >>> The suspend/resume test starts

Re: [PATCH 2/2] tests: suspend/resume: Increase number of processed frames

2018-05-21 Thread Kieran Bingham
pf_packing function to ease future changes. Great idea, to make it easy to update and re-use. > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > tests/vsp-unit-test-0020.sh | 15

Re: [PATCH v11 01/10] media: v4l: vsp1: Release buffers for each video node

2018-05-18 Thread Kieran Bingham
On 18/05/18 21:53, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 18 May 2018 23:41:54 EEST Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> >> >> Commit 372b2b039

[PATCH v11 04/10] media: vsp1: Protect bodies against overflow

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The body write function relies on the code never asking it to write more than the entries available in the list. Currently with each list body containing 256 entries, this is fine, but we can reduce this number greatly saving

[PATCH v11 05/10] media: vsp1: Provide a body pool

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Each display list allocates a body to store register values in a dma accessible buffer from a dma_alloc_wc() allocation. Each of these results in an entry in the IOMMU TLB, and a large number of display list allocations adds pr

[PATCH v11 09/10] media: vsp1: Adapt entities to configure into a body

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Currently the entities store their configurations into a display list. Adapt this such that the code can be configured into a body directly, allowing greater flexibility and control of the content. All users of vsp1_dl_list

[PATCH v11 07/10] media: vsp1: Use reference counting for bodies

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-a

[PATCH v11 08/10] media: vsp1: Refactor display list configure operations

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The entities provide a single .configure operation which configures the object into the target display list, based on the vsp1_entity_params selection. Split the configure function into three parts, '.configure_

[PATCH v11 10/10] media: vsp1: Move video configuration to a cached dlb

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> We are now able to configure a pipeline directly into a local display list body. Take advantage of this fact, and create a cacheable body to store the configuration of the pipeline in the video object. vsp1_video_pipeli

[PATCH v11 03/10] media: vsp1: Reword uses of 'fragment' as 'body'

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Throughout the codebase, the term 'fragment' is used to represent a display list body. This term duplicates the 'body' which is already in use. The datasheet references these objects as a body, therefore replace all me

[PATCH v11 06/10] media: vsp1: Convert display lists to use new body pool

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Adapt the dl->body0 object to use an object from the body pool. This greatly reduces the pressure on the TLB for IPMMU use cases, as all of the lists use a single allocation for the main body. The CLU and LUT objects pre

[PATCH v11 00/10] vsp1: TLB optimisation and DL caching

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Each display list currently allocates an area of DMA memory to store register settings for the VSP1 to process. Each of these allocations adds pressure to the IPMMU TLB entries. We can reduce the pressure by pre-allocating

[PATCH v11 02/10] media: vsp1: Move video suspend resume handling to video object

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> The suspend and resume handlers are only utilised by video pipelines, yet the functions currently reside in the vsp1_pipe object. This causes an issue with resume, as the functions incorrectly call vsp1_pipeline_run() di

[PATCH v11 01/10] media: v4l: vsp1: Release buffers for each video node

2018-05-18 Thread Kieran Bingham
From: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Commit 372b2b0399fc ("media: v4l: vsp1: Release buffers in start_streaming error path") introduced a helper to clean up buffers on error paths, but inadvertently changed the code such that only the output WPF buff

Re: [PATCH v10 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-18 Thread Kieran Bingham
Hi Laurent, On 17/05/18 20:57, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 17 May 2018 20:24:01 EEST Kieran Bingham wrote: >> We are now able to configure a pipeline directly into a local display >> list body. Take advanta

[PATCH v10 2/8] media: vsp1: Protect bodies against overflow

2018-05-17 Thread Kieran Bingham
buffer overflows. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c |

[PATCH v10 0/8] vsp1: TLB optimisation and DL caching

2018-05-17 Thread Kieran Bingham
00,210,230,240: pass Testing histogram HGT with hue areas 240,20,60,80,100,120,140,160,180,200,210,220: pass - vsp-unit-test-0024.sh Test requires unavailable feature set `rpf.0 rpf.1 brs wpf.0': skipped 168 tests: 147 passed, 0 failed, 3 skipped Kieran Bingham (8): media: vsp1: Reword uses of

[PATCH v10 5/8] media: vsp1: Use reference counting for bodies

2018-05-17 Thread Kieran Bingham
Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v10 7/8] media: vsp1: Adapt entities to configure into a body

2018-05-17 Thread Kieran Bingham
, vsp1_dl_list_get_body0() is provided to access the internal body0 from the display list. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> [Don't remove blank line unnecessarily] Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off

[PATCH v10 3/8] media: vsp1: Provide a body pool

2018-05-17 Thread Kieran Bingham
by allocating multiple display list bodies in a single allocation, and providing these to the display list through a 'body pool'. A pool can be allocated by the display list manager or entities which require their own body allocations. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.

[PATCH v10 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-17 Thread Kieran Bingham
dl->bodies[x]->num_entries 39 / max 128 dl->bodies[x]->num_entries 40 / max 128 dl->bodies[x]->num_entries 47 / max 128 dl->bodies[x]->num_entries 48 / max 128 dl->bodies[x]->num_entries 4914 / max 4914 dl->bodies[x]->num_entries 55 / max 128 d

[PATCH v10 4/8] media: vsp1: Convert display lists to use new body pool

2018-05-17 Thread Kieran Bingham
ore the hardware has committed a previous set of tables. Bodies are no longer 'freed' in interrupt context, but instead released back to their respective pools. This allows us to remove the garbage collector in the DLM. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v10 6/8] media: vsp1: Refactor display list configure operations

2018-05-17 Thread Kieran Bingham
the configuration of each parameter class into separate display list bodies. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> [Blank line reformatting, remote unneeded local variable initialization] Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideason

[PATCH v10 1/8] media: vsp1: Reword uses of 'fragment' as 'body'

2018-05-17 Thread Kieran Bingham
. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_clu.c | 10

Re: [PATCH v7 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-17 Thread Kieran Bingham
Hi Laurent, On 17/05/18 15:35, Laurent Pinchart wrote: > Hi Kieran, > > On Monday, 30 April 2018 20:48:03 EEST Kieran Bingham wrote: >> On 07/04/18 01:23, Laurent Pinchart wrote: >>> On Thursday, 8 March 2018 02:05:31 EEST Kieran Bingham wrote: >>>> We

Re: [PATCH v9 6/8] media: vsp1: Refactor display list configure operations

2018-05-17 Thread Kieran Bingham
Hi Laurent, Thanks for the review, On 17/05/18 10:41, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 3 May 2018 16:35:45 EEST Kieran Bingham wrote: >> The entities provide a single .configure operation which configures the >> obj

Re: [PATCH] drm: rcar-du: Fix rcar_du_of_init() stub

2018-05-15 Thread Kieran Bingham
acy DT to create LVDS encoder > nodes") > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_of.h | 2 +- > 1 file changed, 1 inser

Re: [PATCH v2 1/2] Revert "media: rcar-vin: enable field toggle after a set number of lines for Gen3"

2018-05-15 Thread Kieran Bingham
he offending commit before a proper fix can be added in a follow-up > patch. > > This reverts commit 015060cb7795eac34454696cc9c9f8b76926a401. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Kieran Bingham <kieran.bingham+rene...@ideas

Re: [PATCH v2 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-15 Thread Kieran Bingham
in > media controller mode") > Reported-by: Jacopo Mondi <jacopo+rene...@jmondi.org> > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/

Re: [GIT PULL FOR renesas-drivers] drm/du/m3n

2018-05-14 Thread Kieran Bingham
On 14/05/18 13:52, Geert Uytterhoeven wrote: > Hi Kieran, > > On Sat, May 12, 2018 at 10:09 AM, Kieran Bingham > <kieran.bingham+rene...@ideasonboard.com> wrote: >> Please consider including this release in renesas-drivers. >> >> -- >> Regards >

[GIT PULL FOR renesas-drivers] drm/du/m3n

2018-05-12 Thread Kieran Bingham
Kieran Bingham (9): drm: rcar-du: of: Include header to define prototypes drm: rcar-du: Use NULL for table initialisation dt-bindings: display: renesas: du: Increase indent in output table dt-bindings: display: renesas: du: Document the r8a77965 bindings

Re: [PATCH v2] media: i2c: adv748x: Fix pixel rate values

2018-05-12 Thread Kieran Bingham
> > [Niklas: Update AFE fixed pixel rate] > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Does this still require changes to the CSI2 driver to be synchronised? (or does it not

Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Hi Laurent, On 03/05/18 12:13, Laurent Pinchart wrote: > Hi Kieran, >>> + } else { >>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_Y, mem.addr[0]); >>> + vsp1_rpf_write(rpf, dlb, VI6_RPF_SRCM_ADDR_C0, mem.addr[1]); >>> + vsp1_rpf_write(rpf, dlb,

[PATCH v4 06/11] media: vsp1: Provide VSP1 feature helper macro

2018-05-03 Thread Kieran Bingham
throughout the driver. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1.h | 2 ++ drivers/media/platform/vsp1/vsp1_drv.c | 16 drivers/media/platform/vsp1/vsp1_wpf.c | 6 +++--- 3 files changed, 13 insertions(

[PATCH v4 02/11] media: vsp1: Remove packed attributes from aligned structures

2018-05-03 Thread Kieran Bingham
and negatively impacts performance, so we remove the attributes entirely. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2 - Remove attributes entirely --- drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v4 11/11] drm: rcar-du: Support interlaced video output through vsp1

2018-05-03 Thread Kieran Bingham
Use the newly exposed VSP1 interface to enable interlaced frame support through the VSP1 lif pipelines. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 + drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 +++ 2 files chan

[PATCH v4 03/11] media: vsp1: Rename dl_child to dl_next

2018-05-03 Thread Kieran Bingham
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham <kieran.bingham+r

[PATCH v4 08/11] media: vsp1: Add support for extended display list headers

2018-05-03 Thread Kieran Bingham
Extended display list headers allow pre and post command lists to be executed by the VSP pipeline. This provides the base support for features such as AUTO_FLD (for interlaced support) and AUTO_DISP (for supporting continuous camera preview pipelines. Signed-off-by: Kieran Bingham <kieran.bing

[PATCH v4 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

2018-05-03 Thread Kieran Bingham
Header mode display lists are now supported on all WPF outputs. To support extended headers and auto-fld capabilities for interlaced mode handling only header mode display lists can be used. Disable the headerless display list configuration, and remove the dead code. Signed-off-by: Kieran

[PATCH v4 09/11] media: vsp1: Provide support for extended command pools

2018-05-03 Thread Kieran Bingham
allocation to reduce pressure on the TLB, and provide convenient re-usable command objects for the entities to utilise. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2: - Fix spelling typo in commit message - constify, and staticify the instant

[PATCH v4 04/11] media: vsp1: Remove unused display list structure field

2018-05-03 Thread Kieran Bingham
The vsp1 reference in the vsp1_dl_body structure is not used. Remove it. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers

[PATCH v4 05/11] media: vsp1: Clean up DLM objects on error

2018-05-03 Thread Kieran Bingham
If there is an error allocating a display list within a DLM object the existing display lists are not free'd, and neither is the DL body pool. Use the existing vsp1_dlm_destroy() function to clean up on error. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- d

[PATCH v4 01/11] media: vsp1: drm: Fix minor grammar error

2018-05-03 Thread Kieran Bingham
The pixel format is 'unsupported'. Fix the small debug message which incorrectly declares this. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v4 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham

[PATCH v4 00/11] R-Car DU Interlaced support through VSP1

2018-05-03 Thread Kieran Bingham
/ - staticify cmd pool functions (Thanks kbuild-bot) - media: vsp1: Support Interlaced display pipelines - fix erroneous BIT value which enabled interlaced - fix field handling at frame_end interrupt Kieran Bingham (11): media: vsp1: drm: Fix minor grammar error media: vsp1: Remove packed

[PATCH v9 6/8] media: vsp1: Refactor display list configure operations

2018-05-03 Thread Kieran Bingham
the configuration of each parameter class into separate display list bodies. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- The checkpatch warning: WARNING: function definition argument 'struct vsp1_dl_list *' should also have an identifier name has been i

[PATCH v9 7/8] media: vsp1: Adapt entities to configure into a body

2018-05-03 Thread Kieran Bingham
, vsp1_dl_list_get_body0() is provided to access the internal body0 from the display list. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- v9: - Pass the DL through configure_partition

[PATCH v9 8/8] media: vsp1: Move video configuration to a cached dlb

2018-05-03 Thread Kieran Bingham
dl->bodies[x]->num_entries 39 / max 128 dl->bodies[x]->num_entries 40 / max 128 dl->bodies[x]->num_entries 47 / max 128 dl->bodies[x]->num_entries 48 / max 128 dl->bodies[x]->num_entries 4914 / max 4914 dl->bodies[x]->num_entries 55 / max 128 d

[PATCH v9 5/8] media: vsp1: Use reference counting for bodies

2018-05-03 Thread Kieran Bingham
Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v9 2/8] media: vsp1: Protect bodies against overflow

2018-05-03 Thread Kieran Bingham
buffer overflows. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- v3: - adapt for new 'body' terminology - simplify WARN_ON macro usage --- drivers/media/platform/vsp1/vsp1_dl.c | 7 +++

[PATCH v9 3/8] media: vsp1: Provide a body pool

2018-05-03 Thread Kieran Bingham
by allocating multiple display list bodies in a single allocation, and providing these to the display list through a 'body pool'. A pool can be allocated by the display list manager or entities which require their own body allocations. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.

[PATCH v9 4/8] media: vsp1: Convert display lists to use new body pool

2018-05-03 Thread Kieran Bingham
ore the hardware has committed a previous set of tables. Bodies are no longer 'freed' in interrupt context, but instead released back to their respective pools. This allows us to remove the garbage collector in the DLM. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>

[PATCH v9 0/8] vsp1: TLB optimisation and DL caching

2018-05-03 Thread Kieran Bingham
eas 10,20,50,60,100,110,150,160,200,210,230,240: pass Testing histogram HGT with hue areas 240,20,60,80,100,120,140,160,180,200,210,220: pass - vsp-unit-test-0024.sh Test requires unavailable feature set `rpf.0 rpf.1 brs wpf.0': skipped 168 tests: 147 passed, 0 failed, 3 skipped Kieran Bingham (8): medi

[PATCH v9 1/8] media: vsp1: Reword uses of 'fragment' as 'body'

2018-05-03 Thread Kieran Bingham
. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- Changes since v7: - Fix indentation - Reword vsp1_dl_list_add_body() documentation Changes since v6: - Clean up th

Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Hi Reviewers ... Comments inline ... On 03/05/18 09:44, Kieran Bingham wrote: > Calculate the top and bottom fields for the interlaced frames and > utilise the extended display list command feature to implement the > auto-field operations. This allows the DU to update the VSP2

[PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines

2018-05-03 Thread Kieran Bingham
Calculate the top and bottom fields for the interlaced frames and utilise the extended display list command feature to implement the auto-field operations. This allows the DU to update the VSP2 registers dynamically based upon the currently processing field. Signed-off-by: Kieran Bingham

[PATCH v3 03/11] media: vsp1: Rename dl_child to dl_next

2018-05-03 Thread Kieran Bingham
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display list chain referencing the nodes as children, when in reality they are siblings. Update the terminology to 'dl_next' to be consistent with the vsp1_video_pipeline_run() usage. Signed-off-by: Kieran Bingham <kieran.bingham+r

[PATCH v3 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

2018-05-03 Thread Kieran Bingham
Header mode display lists are now supported on all WPF outputs. To support extended headers and auto-fld capabilities for interlaced mode handling only header mode display lists can be used. Disable the headerless display list configuration, and remove the dead code. Signed-off-by: Kieran

[PATCH v3 02/11] media: vsp1: Remove packed attributes from aligned structures

2018-05-03 Thread Kieran Bingham
and negatively impacts performance, so we remove the attributes entirely. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2 - Remove attributes entirely drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v3 05/11] media: vsp1: Clean up DLM objects on error

2018-05-03 Thread Kieran Bingham
If there is an error allocating a display list within a DLM object the existing display lists are not free'd, and neither is the DL body pool. Use the existing vsp1_dlm_destroy() function to clean up on error. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- d

[PATCH v3 09/11] media: vsp1: Provide support for extended command pools

2018-05-03 Thread Kieran Bingham
allocation to reduce pressure on the TLB, and provide convenient re-usable command objects for the entities to utilise. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2: - Fix spelling typo in commit message - constify, and staticify the instant

[PATCH v3 04/11] media: vsp1: Remove unused display list structure field

2018-05-03 Thread Kieran Bingham
The vsp1 reference in the vsp1_dl_body structure is not used. Remove it. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers

[PATCH v3 01/11] media: vsp1: drm: Fix minor grammar error

2018-05-03 Thread Kieran Bingham
The pixel format is 'unsupported'. Fix the small debug message which incorrectly declares this. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 00/11] R-Car DU Interlaced support through VSP1

2018-05-03 Thread Kieran Bingham
: Support Interlaced display pipelines - fix erroneous BIT value which enabled interlaced - fix field handling at frame_end interrupt Kieran Bingham (11): media: vsp1: drm: Fix minor grammar error media: vsp1: Remove packed attributes from aligned structures media: vsp1: Rename dl_child

[PATCH v3 11/11] drm: rcar-du: Support interlaced video output through vsp1

2018-05-03 Thread Kieran Bingham
Use the newly exposed VSP1 interface to enable interlaced frame support through the VSP1 lif pipelines. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 + drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 +++ 2 files chan

  1   2   3   4   5   6   7   8   9   >