Re: [PATCH] clk: vc5: Add suspend/resume support

2018-12-05 Thread Laurent Pinchart
Hi Marek, On Wednesday, 5 December 2018 14:29:22 EET Marek Vasut wrote: > On 12/05/2018 06:21 AM, Laurent Pinchart wrote: > > On Wednesday, 5 December 2018 01:48:01 EET Marek Vasut wrote: > >> On 12/04/2018 09:52 PM, Stephen Boyd wrote: > >>> Quoting Ma

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

2018-12-04 Thread Laurent Pinchart
Hi Marek, On Wednesday, 5 December 2018 03:10:18 EET Marek Vasut wrote: > On 12/03/2018 11:48 PM, Laurent Pinchart wrote: > > On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: > >> On 12/03/2018 10:48 PM, Laurent Pinchart wrote: > >>> On Monday, 3 De

Re: [PATCH] clk: vc5: Add suspend/resume support

2018-12-04 Thread Laurent Pinchart
>> + > >> + regcache_cache_only(vc5->regmap, false); > >> + ret = regcache_sync(vc5->regmap); > >> + if (ret != 0) { > >> + dev_err(dev, "Failed to restore register map: %d\n", > >> ret); > >> + return ret; > >> + } > > > > Simplify to > > > > if (ret) > > > > dev_err() > > > > retun ret; > > > >> + > >> + return 0; > >> +} > >> +#endif > >> + > >> > >> static const struct vc5_chip_info idt_5p49v5923_info = { > >> > >> .model = IDT_VC5_5P49V5923, > >> .clk_fod_cnt = 2, -- Regards, Laurent Pinchart

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

2018-12-03 Thread Laurent Pinchart
Hi Marek, On Tuesday, 4 December 2018 00:24:32 EET Marek Vasut wrote: > On 12/03/2018 10:48 PM, Laurent Pinchart wrote: > > On Monday, 3 December 2018 17:12:41 EET Geert Uytterhoeven wrote: > >> As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate >

Re: [PATCH 2/2] arm64: dts: renesas: r8a7796: salvator-xs: Convert to new LVDS DT bindings

2018-12-03 Thread Laurent Pinchart
-off-by: Geert Uytterhoeven > --- > Compile-tested only. I can't test the patch either but it looks fine to me. Reviewed-by: Laurent Pinchart I assume you will send this directly to Simon, so I don't plan to take the patch in my tree. > --- > arch/arm64/boot/dts/renesas/r8a7796-salv

Re: [PATCH 1/2] ARM: dts: stout: Convert to new LVDS DT bindings

2018-12-03 Thread Laurent Pinchart
patch either but it looks fine to me. Reviewed-by: Laurent Pinchart I assume you will send this directly to Simon, so I don't plan to take the patch in my tree. > --- > arch/arm/boot/dts/r8a7790-stout.dts | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) >

Re: Issue with enabling VSP source on rcar gen2 koelsch board

2018-11-29 Thread Laurent Pinchart
l. > > Now as part of RZ/G1N vsp upstreaming, I rebased to latest branch from > renesas-dev , and executed the same test case > > Only test cases in vsp test suite is working. the vspd test case is broken. Could you please post the tests output and log ? > So I am wondering how do we expose the r-car gen2 SoC feature "VSPD" to > the end user? Isn't the VSPD already exposed to the user as a V4L2 device on Gen2 ? -- Regards, Laurent Pinchart

Re: [PATCH 00/13] clk: renesas: Miscellaneous fixes

2018-11-29 Thread Laurent Pinchart
ck/r8a7796-cpg-mssr.h | 2 +- > include/dt-bindings/clock/r8a77995-cpg-mssr.h | 5 +++-- > 10 files changed, 18 insertions(+), 15 deletions(-) -- Regards, Laurent Pinchart

Re: [PATCH 09/13] clk: renesas: r8a77995: Correct parent clock of DU

2018-11-29 Thread Laurent Pinchart
ssr: Add R8A77995 support") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart The patch has no effect on the DU operation as the rcar-du driver hardcodes a different clock source for the dot clock. However, after hacking the driver to hardcode usage of this clock, oper

Re: [PATCH 08/13] clk: renesas: r8a77990: Correct parent clock of DU

2018-11-29 Thread Laurent Pinchart
hi Kihara > Fixes: 3570a2af473789c5 ("clk: renesas: cpg-mssr: Add support for R-Car E3") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/clk/renesas/r8a77990-cpg-mssr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > &

Re: Issue with enabling VSP source on rcar gen2 koelsch board

2018-11-28 Thread Laurent Pinchart
sole_lock(), console_trylock() and console_unlock() (kernel/printk/printk.c). -- Regards, Laurent Pinchart

Re: [PATCH] drm: rcar-du: Re-update the DSYSR register value for start/stop

2018-11-22 Thread Laurent Pinchart
Hello Hoan, On Tuesday, 23 October 2018 04:01:19 EET Hoan wrote: > On 2018/10/22 20:23, Laurent Pinchart wrote: > > On Monday, 22 October 2018 09:30:54 EEST Nguyen An Hoan wrote: > >> From: Hoan Nguyen An > >> > >> From previous commit 0521ccb "

Re: [PATCH] drm: rcar-du: fix probe error when DRM_RCAR_DW_HDMI disabled

2018-11-22 Thread Laurent Pinchart
down the road. > } > > ret = drm_encoder_init(rcdu->ddev, encoder, _funcs, -- Regards, Laurent Pinchart

Re: HDMI doesn't work on ULCB board

2018-11-11 Thread Laurent Pinchart
ation, enabled CONFIG_COMMON_CLK_VC5, and my > > Salvator-XS H3 boots fine. > > I'm deeply sorry, it was my fault. > I'm using ES1.x board, but I used XS dtb I've done worse mistakes, and many times, so I can't blame you :-) I'm glad it works now. -- Regards, Laurent Pinchart

Re: HDMI doesn't work on ULCB board

2018-11-10 Thread Laurent Pinchart
mp query. > > ** stop here ** I'm afraid I can't reproduce this. I checked out renesas-drivers-2018-10-09- v4.19-rc7, applied the fix I've submitted, took your configuration, enabled CONFIG_COMMON_CLK_VC5, and my Salvator-XS H3 boots fine. -- Regards, Laurent Pinchart

Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

2018-11-07 Thread Laurent Pinchart
a > > > > Signed-off-by: Takeshi Kihara > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Laurent Pinchart > > Thanks, > > This looks fine to me but I will wait to see if there are other reviews > before applying. > > Reviewed-by: Simon Horman I think you can go ahead and apply it. -- Regards, Laurent Pinchart

Re: HDMI doesn't work on ULCB board

2018-11-06 Thread Laurent Pinchart
Hi Morimoto-san, On Tuesday, 6 November 2018 16:30:35 EET Laurent Pinchart wrote: > On Thursday, 18 October 2018 05:12:14 EET Kuninori Morimoto wrote: > > Hi Vladimir, Laurent > > > > I'm testing ULCB board, and I noticed that HDMI doen't work on it. > > > >

Re: HDMI doesn't work on ULCB board

2018-11-06 Thread Laurent Pinchart
1.879100] ---[ end trace ec07bda5b9bd7ef1 ]--- I'm now investigating it. -- Regards, Laurent Pinchart

Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

2018-11-05 Thread Laurent Pinchart
driver fails to probe. > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 > device nodes") Signed-off-by: Koji Matsuoka > Signed-off-by: Takeshi Kihara > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts

Re: [PATCH v2 6/8] arm64: dts: r8a77990: Add VIN and CSI-2 device nodes

2018-10-30 Thread Laurent Pinchart
Hi Jacopo, On Tuesday, 30 October 2018 12:14:31 EET jacopo mondi wrote: > On Mon, Sep 10, 2018 at 05:12:30PM +0300, Laurent Pinchart wrote: > > On Wednesday, 5 September 2018 18:29:43 EEST Jacopo Mondi wrote: > >> From: Koji Matsuoka > >> > >> Add device nod

Re: [PATCH] drm: rcar-du: Re-update the DSYSR register value for start/stop

2018-10-22 Thread Laurent Pinchart
: DSYSR_DRES); > + rcar_du_group_write(rgrp, DSYSR, > + (rcar_du_group_read(rgrp, DSYSR) & ~(DSYSR_DRES | > DSYSR_DEN)) | > + (start ? DSYSR_DEN : DSYSR_DRES)); > } > > void rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start) -- Regards, Laurent Pinchart

Re: HDMI doesn't work on ULCB board

2018-10-19 Thread Laurent Pinchart
robed > [2.045763] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). > [2.052441] [drm] No driver support for vblank timestamp query. > /* here kernel stop */ I will have a look. -- Regards, Laurent Pinchart

Re: [PATCH] ARM: dts: r8a779[01]: Disable unconnected LVDS encoders

2018-10-17 Thread Laurent Pinchart
Hello, On Wednesday, 17 October 2018 20:48:01 EEST Laurent Pinchart wrote: > The LVDS0 encoder on Koelsh and Porter, and the LVDS1 encoder on Lager, > are enabled in DT but have no device connected to their output. This > result in spurious messages being printed to the k

[PATCH] ARM: dts: r8a779[01]: Disable unconnected LVDS encoders

2018-10-17 Thread Laurent Pinchart
it by disabling the encoders. Fixes: 15a1ff30d8f9 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings") Fixes: e5c3f4707f39 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings") Reported-by: Simon Horman Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7790-lager.dt

[PATCH] MAINTAINERS: Remove Laurent Pinchart as Renesas pinctrl maintainer

2018-10-16 Thread Laurent Pinchart
Geert Uytterhoeven has long taken over and I'm not involved anymore with the Renesas pinctrl driver. Remove myself from the maintainers list. Signed-off-by: Laurent Pinchart --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 69373eb328d4

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-10-01 Thread Laurent Pinchart
Hi Daniel, On Monday, 1 October 2018 09:52:20 EEST Daniel Vetter wrote: > On Fri, Sep 28, 2018 at 06:30:35PM +0300, Laurent Pinchart wrote: > > On Friday, 28 September 2018 18:05:18 EEST Laurent Pinchart wrote: > > > On Thursday, 27 September 2018 09:34:18 EEST Soup

[PATCH v3 1/4] arm64: dts: renesas: r8a77990: Add display output support

2018-09-25 Thread Laurent Pinchart
The R8A77990 (E3) platform has one RGB output and two LVDS outputs connected to the DU. Add the DT nodes for the DU, LVDS encoders and supporting VSP and FCP. Signed-off-by: Laurent Pinchart Tested-by: Jacopo Mondi --- Changes since v2: - Fixed VSPI clock index --- arch/arm64/boot/dts/renesas

[PATCH v3 4/4] arm64: dts: renesas: r8a77995: draak: Enable HDMI display output

2018-09-25 Thread Laurent Pinchart
-off-by: Laurent Pinchart Tested-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 98 +- 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index

[PATCH v3 2/4] arm64: dts: renesas: r8a77995: Add LVDS support

2018-09-25 Thread Laurent Pinchart
From: Kieran Bingham The r8a77995 D3 platform has 2 LVDS channels connected to the DU. Signed-off-by: Kieran Bingham [uli: moved lvds* into the soc node, added PM domains, resets] Signed-off-by: Ulrich Hecht Reviewed-by: Laurent Pinchart Tested-by: Jacopo Mondi --- arch/arm64/boot/dts

[PATCH v3 0/4] R-Car D3/E3 display DT enablement

2018-09-25 Thread Laurent Pinchart
arm64: dts: renesas: r8a77995: Add LVDS support Laurent Pinchart (2): arm64: dts: renesas: r8a77990: Add display output support arm64: dts: renesas: r8a77990: ebisu: Enable VGA and HDMI outputs Ulrich Hecht (1): arm64: dts: renesas: r8a77995: draak: Enable HDMI display output arch/arm64/boot/d

[PATCH v3 3/4] arm64: dts: renesas: r8a77990: ebisu: Enable VGA and HDMI outputs

2018-09-25 Thread Laurent Pinchart
board, hook them up in DT. Signed-off-by: Laurent Pinchart Tested-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 162 + 1 file changed, 162 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas

[PATCH] pinctrl: sh-pfc: r8a77990: Add PWM pins, groups and functions

2018-09-19 Thread Laurent Pinchart
The R8A77990 (E3) SoC has 7 PWM outputs, add pins, groups and functions for all of them. Signed-off-by: Laurent Pinchart --- drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 180 ++ 1 file changed, 180 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c b

Re: [PATCH/RFT v2 0/8] arm64: dts: renesas: Ebisu: Add HDMI and CVBS input

2018-09-17 Thread Laurent Pinchart
s: r8a77990: Add VIN and CSI-2 device nodes > > Takeshi Kihara (1): > arm64: dts: r8a77990: Add I2C device nodes > > .../devicetree/bindings/media/rcar_vin.txt | 1 + > .../bindings/media/renesas,rcar-csi2.txt | 1 + > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 +++ > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 202 + > drivers/media/platform/rcar-vin/rcar-core.c| 20 ++ > drivers/media/platform/rcar-vin/rcar-csi2.c| 9 + > drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 250 ++ > 7 files changed, 569 insertions(+) -- Regards, Laurent Pinchart

Re: [PATCH v2 6/8] arm64: dts: r8a77990: Add VIN and CSI-2 device nodes

2018-09-17 Thread Laurent Pinchart
Hi Jacopo, On Monday, 10 September 2018 17:12:30 EEST Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wednesday, 5 September 2018 18:29:43 EEST Jacopo Mondi wrote: > > From: Koji Matsuoka > > > > Add device nodes for VIN4, VIN5 and

Re: [GIT PULL FOR renesas-drivers] D3 and E3 HDMI output support

2018-09-17 Thread Laurent Pinchart
Hi Geert, Simon, there's a question for your below. On Monday, 17 September 2018 10:53:33 EEST Geert Uytterhoeven wrote: > On Sat, Sep 15, 2018 at 4:44 PM Laurent Pinchart wrote: > > The following changes since commit 6e1637c91742570ff873433ed27227933b792af4: > > drm: rcar-du

Re: [PATCH v2 13/16] arm64: dts: renesas: r8a77990: Add display output support

2018-09-17 Thread Laurent Pinchart
Hi Simon, On Monday, 17 September 2018 11:47:15 EEST Laurent Pinchart wrote: > On Monday, 17 September 2018 11:14:20 EEST Simon Horman wrote: > > On Mon, Sep 17, 2018 at 09:50:55AM +0200, Simon Horman wrote: > > > On Fri, Sep 14, 2018 at 12:10:43PM +0300, Laur

[GIT PULL FOR renesas-drivers] D3 and E3 HDMI output support

2018-09-15 Thread Laurent Pinchart
: r8a77995: Add LVDS support Laurent Pinchart (14): arm64: dts: renesas: r8a77990: Add display output support arm64: dts: renesas: r8a77990: ebisu: Enable VGA and HDMI outputs pinctrl: sh-pfc: r8a77990: Add DU pins, groups and function dt-bindings: display: renesas: du

Re: [PATCH v2 8/8] arm64: dts: renesas: ebisu: Add HDMI and CVBS input

2018-09-10 Thread Laurent Pinchart
; > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 +++ > 1 file changed, 86 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > b/arch/arm64/boot/

Re: [PATCH v2 6/8] arm64: dts: r8a77990: Add VIN and CSI-2 device nodes

2018-09-10 Thread Laurent Pinchart
o keep the nodes sorted by address > + compatible = "renesas,r8a77990-csi2", > "renesas,rcar-gen3-csi2"; > + reg = <0 0xfeaa 0 0x1>; 0x1 seems pretty large to me. Apart from that, Reviewed-by:

Re: [PATCH v2 4/8] media: rcar-csi2: Add R8A77990 support

2018-09-10 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 5 September 2018 18:29:41 EEST Jacopo Mondi wrote: > Add support for R-Car E3 R8A77965 to R-Car CSI-2 driver. > Based on the experimental patch from Magnus Damm. > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart >

Re: [PATCH v2 3/8] media: dt-bindings: rcar-csi2: Add R8A77990

2018-09-10 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 5 September 2018 18:29:40 EEST Jacopo Mondi wrote: > Add compatible string for R-Car E3 R8A77990 to the list of supported SoCs. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart > --- &

Re: [PATCH v2 2/8] media: rcar-vin: Add support for R-Car R8A77990

2018-09-10 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 5 September 2018 18:29:39 EEST Jacopo Mondi wrote: > Add R-Car E3 R8A77990 SoC to the rcar-vin supported ones. > Based on the experimental patch from Magnus Damm. > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart >

Re: [PATCH v2 1/8] media: dt-bindings: rcar-vin: Add R8A77990 support

2018-09-10 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wednesday, 5 September 2018 18:29:38 EEST Jacopo Mondi wrote: > Add compatible string for R-Car E3 R8A77990 to the list of SoCs supported by > rcar-vin driver. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Rob Herring Reviewed-by: L

Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support

2018-09-06 Thread Laurent Pinchart
Hello, On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote: > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote: > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote: > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push >

Re: [PATCH v2 7/8] arm64: dts: r8a77990: Add I2C device nodes

2018-09-05 Thread Laurent Pinchart
t; Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Tested-by: Laurent Pinchart Simon, could you take this in your tree for v4.20 without waiting for the whole series to be ready ? > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 123 +++

Re: vsps and channel indices (was: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a77980: add FCPVD/VSPD/DU/LVDS support)

2018-08-29 Thread Laurent Pinchart
ree... > > > > Based on the original (and large) patch by Vladimir Barinov. > > > > Signed-off-by: Vladimir Barinov > > Signed-off-by: Sergei Shtylyov > > Reviewed-by: Laurent Pinchart > > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8

[PATCH v2] pinctrl: sh-pfc: r8a77990: Add DU pins, groups and function

2018-08-28 Thread Laurent Pinchart
This patch adds DU pins, groups and function for the R8A77990 (E3) SoC. Signed-off-by: Laurent Pinchart --- Changes since v1: - Add DU_CLKIN0 --- drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 110 ++ 1 file changed, 110 insertions(+) diff --git a/drivers/pinctrl/sh

Re: [PATCH] pinctrl: sh-pfc: r8a77990: Add DU pins, groups and function

2018-08-28 Thread Laurent Pinchart
Hi Geert, On Tuesday, 28 August 2018 11:41:00 EEST Geert Uytterhoeven wrote: > On Thu, Aug 23, 2018 at 9:09 AM Laurent Pinchart wrote: > > This patch adds DU pins, groups and function for the R8A77990 (E3) SoC. > > > > Signed-off-by: Laurent Pinchart > >

Re: [RFT 0/8] arm64: dts: renesas: Ebisu: Add HDMI and CVBS input

2018-08-28 Thread Laurent Pinchart
gt;> On 2018-08-25 02:54:44 +0300, Laurent Pinchart wrote: > >>>> On Monday, 20 August 2018 13:16:34 EEST Jacopo Mondi wrote: > >>>>> Hello renesas list, > >>>>> > >>>>> this series add supports for the HDMI and CVBS input to R-

Re: [PATCH 1/2] arm64: dts: r8a77965: add FDP1 device nodes

2018-08-28 Thread Laurent Pinchart
Hi Simon, On Monday, 27 August 2018 15:57:05 EEST Simon Horman wrote: > On Fri, Aug 24, 2018 at 11:45:52AM +0300, Laurent Pinchart wrote: > > On Friday, 24 August 2018 07:52:28 EEST Nguyen An Hoan wrote: > > > From: Hoan Nguyen An > > > > You're missing a commit me

Re: [RFT 0/8] arm64: dts: renesas: Ebisu: Add HDMI and CVBS input

2018-08-24 Thread Laurent Pinchart
| 86 > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 202 + > drivers/media/platform/rcar-vin/rcar-core.c| 20 + > drivers/media/platform/rcar-vin/rcar-csi2.c| 9 + > drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 504 ++ > 7 files changed, 823 insertions(+) -- Regards, Laurent Pinchart

Re: [PATCH 2/2] clk: renesas: r8a77965: Add FDP clock

2018-08-24 Thread Laurent Pinchart
clock is correct. As it doesn't matter too much given that the parent clock doesn't need to be controlled, and the FDP driver doesn't care about the clock frequency, we can start with this without any problem. Reviewed-by: Laurent Pinchart > DEF_MOD("scif5",202

Re: [PATCH 1/2] arm64: dts: r8a77965: add FDP1 device nodes

2018-08-24 Thread Laurent Pinchart
age is still a good practice that we try to enforce through the kernel. For instance, looking at git history for r8a7796, you could use "The r8a77965 has a single FDP1 instance." > Signed-off-by: Hoan Nguyen An Apart from that, Reviewed-by: Laurent Pinchart Simon, could you update th

[PATCH] pinctrl: sh-pfc: r8a77990: Add DU pins, groups and function

2018-08-23 Thread Laurent Pinchart
This patch adds DU pins, groups and function for the R8A77990 (E3) SoC. Signed-off-by: Laurent Pinchart --- drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 101 ++ 1 file changed, 101 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c b/drivers/pinctrl/sh

Re: [RFC/RTF] drm: rcar-du: lvds: Handle LVDS interface reset

2018-08-21 Thread Laurent Pinchart
+490,12 @@ static int rcar_lvds_probe(struct platform_device > *pdev) return PTR_ERR(lvds->clock); > } > > + lvds->rst = devm_reset_control_get_optional_exclusive(>dev, NULL); > + if (IS_ERR(lvds->rst)) { > + dev_err(>dev, "failed to get reset\n"); > + return PTR_ERR(lvds->rst); > + } > + > drm_bridge_add(>bridge); > > return 0; -- Regards, Laurent Pinchart

Re: [PATCH 2/3] drm: rcar-du: Rename var to a more precise name

2018-08-20 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Monday, 30 July 2018 20:20:13 EEST Jacopo Mondi wrote: > Rename the 'value' variable, only used to for writing to DMSR register to a > more precise 'dmsr' name. > > Signed-off-by: Laurent Pinchart > Signed-off-by: Jacopo Mondi I think thi

[PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys support

2018-08-19 Thread Laurent Pinchart
The Salvator-X and XS boards have a 4 lines DIP switch and 3 push buttons connected to SoC GPIOs, meant to be used as general-purpose test keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP switch to keys 1-4 and the push buttons to keys A-C. Signed-off-by: Laurent Pinchart

Re: [PATCH v3 2/2] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support

2018-08-13 Thread Laurent Pinchart
0>; > + thc63lvd1024_in: endpoint { > + remote-endpoint = <_out>; > + }; > + }; > + > + port@2 { > + reg = <2>;

Re: [V2]Fix RCAR-V3H SoC wrong IPSR9/10 registers

2018-08-09 Thread Laurent Pinchart
be reviewed without the reviewer having to manually paste the patch in the e-mail and add quote characters. -- Regards, Laurent Pinchart

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Laurent Pinchart
d ULCB in DT, while the V3 board are called SK. I wonder if we should unify that or if it's too late. > and if we had such compatible driver/soc, it needs to match to all ulcb. > In reality, maybe we don't create such compatible driver, though. > But, I don't know, I can follow to maintainer opinion. -- Regards, Laurent Pinchart

Re: [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize

2018-08-06 Thread Laurent Pinchart
On Monday, 6 August 2018 17:37:45 EEST Laurent Pinchart wrote: > On Monday, 6 August 2018 17:07:51 EEST Geert Uytterhoeven wrote: > > Hi all, > > > > This RFC patch series was sparked by noticing that commit 2d4dd0da45401c7a > > Where can that commit be found ?

Re: [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports"

2018-08-06 Thread Laurent Pinchart
Hi Geert, On Monday, 6 August 2018 17:34:34 EEST Geert Uytterhoeven wrote: > On Mon, Aug 6, 2018 at 4:16 PM Laurent Pinchart wrote: > > On Monday, 6 August 2018 17:07:54 EEST Geert Uytterhoeven wrote: > >> This reverts commit dfc80387aefb78161f83732804c6d01c89c24595. &

Re: [PATCH/RFC 0/4] sh-sci : Do not derive regshift from regsize

2018-08-06 Thread Laurent Pinchart
e > > Yoshinori Sato (1): > [RFC] sh-sci: Use a separate sci_port for earlycon > > arch/sh/kernel/cpu/sh3/setup-sh770x.c | 1 + > arch/sh/kernel/cpu/sh4/setup-sh7750.c | 3 +- > arch/sh/kernel/cpu/sh4/setup-sh7760.c | 10 +--- > drivers/tty/serial/sh-sci.c | 68 +-- > include/linux/serial_sci.h| 1 + > 5 files changed, 49 insertions(+), 34 deletions(-) -- Regards, Laurent Pinchart

Re: [PATCH/RFC 3/4] Revert "serial: sh-sci: Compute the regshift value for SCI ports"

2018-08-06 Thread Laurent Pinchart
gt; - > if (regtype == SCIx_SH4_SCIF_REGTYPE) > if (sci_port->reg_size >= 0x20) > port->regshift = 1; > diff --git a/include/linux/serial_sci.h b/include/linux/serial_sci.h > index c0e795d95477daea..eebb12fc473f49a2 100644 > --- a/include/linux/serial_sci.h > +++ b/include/linux/serial_sci.h > @@ -57,6 +57,7 @@ struct plat_sci_port { > /* >* Platform overrides if necessary, defaults otherwise. >*/ > + unsigned char regshift; > unsigned char regtype; > > struct plat_sci_port_ops*ops; -- Regards, Laurent Pinchart

Re: [PATCH 04/14] arm64: dts: renesas: r8a7795-es1: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-06 Thread Laurent Pinchart
Hi Kieran, On Monday, 6 August 2018 13:49:59 EEST Kieran Bingham wrote: > On 06/08/18 11:45, Kieran Bingham wrote: > > On 06/08/18 11:42, Laurent Pinchart wrote: > >> On Sunday, 5 August 2018 02:11:04 EEST Eugeniu Rosca wrote: > >>> Following the recent change i

Re: [PATCH 04/14] arm64: dts: renesas: r8a7795-es1: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-06 Thread Laurent Pinchart
explained in my review of 02/14, I think "shimafuji,kingfisher" should include the SoC name. This brings up the topic of how to describe boards that are made of an SoC "module" board plugged into an expansion "motherboard". > }; -- Regards, Laurent Pinchart

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-06 Thread Laurent Pinchart
"renesas,r8a7791" >- iWave Systems RZ/G1C Single Board Computer (iW-RainboW-G23S) > @@ -105,7 +105,7 @@ Boards: >- Lager (RTP0RC7790SEB00010S) > compatible = "renesas,lager", "renesas,r8a7790" >- M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) > -compatible = "renesas,m3ulcb", "renesas,r8a7796" > +compatible = "renesas,ulcb", "renesas,r8a7796" >- Marzen (R0P7779A00010S) > compatible = "renesas,marzen", "renesas,r8a7779" >- Porter (M2-LCDP) -- Regards, Laurent Pinchart

Re: [PATCH 01/14] arm64: dts: renesas: Cut redundant in *-ulcb*.dts

2018-08-06 Thread Laurent Pinchart
m64/boot/dts/renesas/r8a7796-ulcb-kf.dts similarity index 94% > rename from arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts > rename to arch/arm64/boot/dts/renesas/r8a7796-ulcb-kf.dts > index de2390f009e7..faa32c28eef7 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7796-ulcb-kf.dts > @@ -9,7 +9,7 @@ > * kind, whether express or implied. > */ > > -#include "r8a7796-m3ulcb.dts" > +#include "r8a7796-ulcb.dts" > #include "ulcb-kf.dtsi" > > / { > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts > b/arch/arm64/boot/dts/renesas/r8a7796-ulcb.dts similarity index 100% > rename from arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dts > rename to arch/arm64/boot/dts/renesas/r8a7796-ulcb.dts -- Regards, Laurent Pinchart

Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17

2018-07-31 Thread Laurent Pinchart
Hi Geert, On Tuesday, 31 July 2018 16:48:48 EEST Geert Uytterhoeven wrote: > On Wed, Jul 11, 2018 at 11:16 PM Laurent Pinchart wrote: > > On Thursday, 5 July 2018 13:55:00 EEST Geert Uytterhoeven wrote: > >> On Thu, Jun 14, 2018 at 1:36 PM Simon Horman wrote: > >>

Re: [PATCH] dmaengine: rcar-dmac: Make rcar_dmac_of_xlate() more robust

2018-07-27 Thread Laurent Pinchart
) { > + pr_info("%s: invalid MID/RID 0x%x... for %pOF\n", __func__, > + dma_spec->args[0], dma_spec->np); > return NULL; > + } > > /* Only slave DMA channels can be allocated via DT */ > dma_cap_zero(mask); -- Regards, Laurent Pinchart

Re: [PATCH v5 0/2] R-Car DU: Convert DT to new DU and LVDS bindings

2018-07-26 Thread Laurent Pinchart
Hi Simon, On Wednesday, 6 June 2018 11:44:22 EEST Simon Horman wrote: > On Tue, Jun 05, 2018 at 12:51:04PM +0300, Laurent Pinchart wrote: > > Hello, > > > > This small patch series contains the last two remaining patches from > > "[PATCH v4 00/16] R-Car DU: Co

Re: [PATCH] iommu/ipmmu-vmsa: Clarify supported platforms

2018-07-25 Thread Laurent Pinchart
; > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > drivers/iommu/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index 568ae81b0e99b67b..c69dc0b29b5df37f 100644

Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17

2018-07-11 Thread Laurent Pinchart
ld return before printing that message due to if (!of_device_is_available(entity)) { dev_dbg(rcdu->dev, "connected entity %pOF is disabled, skipping\n", entity); return -ENODEV; } as the LVDS encoder

Re: [PATCH v2] dmaengine: rcar-dmac: convert to SPDX identifiers

2018-07-05 Thread Laurent Pinchart
2 DMA Controller Driver > * > * Copyright (C) 2014 Renesas Electronics Inc. > * > * Author: Laurent Pinchart > - * > - * This is free software; you can redistribute it and/or modify > - * it under the terms of version 2 of the GNU General Public License as > - * published by the Free Software Foundation. > */ > > #include -- Regards, Laurent Pinchart

Re: [PATCH] dmaengine: rcar-dmac: convert to SPDX identifiers

2018-07-03 Thread Laurent Pinchart
Hi Vinod, On Tuesday, 3 July 2018 09:20:08 EEST Vinod wrote: > On 03-07-18, 08:49, Laurent Pinchart wrote: > > Hi Morimoto-san, > > > > Thank you for the patch. > > > > On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote: > > > From: Kuninori

Re: [PATCH] dmaengine: rcar-dmac: convert to SPDX identifiers

2018-07-02 Thread Laurent Pinchart
troller Driver > - * > - * Copyright (C) 2014 Renesas Electronics Inc. > - * > - * Author: Laurent Pinchart > - * > - * This is free software; you can redistribute it and/or modify > - * it under the terms of version 2 of the GNU General Public License as > - * published by the

Re: [PATCH] dmaengine: rcar-dmac: clear channel register when error

2018-07-02 Thread Laurent Pinchart
> + rcar_dmac_write(dmac, RCAR_DMACHCLR, 1 << chan->index); > + rcar_dmac_chcr_de_barrier(chan); > reinit = true; > goto spin_lock_end; > } -- Regards, Laurent Pinchart

[PROTO] [VIRTIO] [PATCH 1/2] Add virtio gpu device specification.

2018-06-29 Thread Laurent Pinchart
and is therefore fully compatible with +the qemu stdvga (see \href{http://git.qemu-project.org/?p=qemu.git;a=blob;f=docs/specs/standard-vga.txt;hb=HEAD}{docs/specs/standard-vga.txt} in the qemu source tree). -- Regards, Laurent Pinchart

[PROTO] [VIRTIO] [PATCH 2/2] virtio-gpu: Support host-allocated backing storage

2018-06-29 Thread Laurent Pinchart
for the host to allocate resource backing storage and map it to the guest. The allocated memory can then be used directly by the host-side display device, removing the need for memory copy operations. Signed-off-by: Laurent Pinchart --- virtio-gpu.tex | 48 1

[PROTO] [VIRTIO] [PATCH 0/2] Improve display performances when VIRGL is not available

2018-06-29 Thread Laurent Pinchart
that option is viable remains to be analyzed, but feedback would already be welcome. Gerd Hoffmann (1): Add virtio gpu device specification. Laurent Pinchart (1): virtio-gpu: Support host-allocated backing storage content.tex| 2 + virtio-gpu.tex | 529

Re: [PATCH] arm64: dts: renesas: Fix VSPD registers range

2018-06-08 Thread Laurent Pinchart
Hi Sergei, (CC'ing Olof) On Friday, 8 June 2018 19:41:01 EEST Sergei Shtylyov wrote: > On 06/08/2018 03:21 PM, Laurent Pinchart wrote: > > The VSPD and FCPVD nodes have overlapping register ranges, as the FCPVD > > devices are mapped in the memory range usually used by the VSP

Re: [PATCH v2 0/5] Add R8A77980/Condor/V3HSK LVDS/HDMI support

2018-06-08 Thread Laurent Pinchart
1/5 to 4/5 all together. > [5/5] arm64: dts: renesas: condor/v3hsk: add DU/LVDS/HDMI support -- Regards, Laurent Pinchart

Re: [PATCH v2 4/5] arm64: dts: renesas: r8a77980: add LVDS support

2018-06-08 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Thursday, 7 June 2018 23:23:06 EEST Sergei Shtylyov wrote: > Define the generic R8A77980 part of the LVDS device node. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77

Re: [PATCH v2 1/5] arm64: dts: renesas: r8a77980: add FCPVD support

2018-06-08 Thread Laurent Pinchart
: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77980.dtsi |8 > 1 file changed, 8 insertions(+) > > Index: renesas/arch/

Re: [PATCH v2 3/5] arm64: dts: renesas: r8a77980: add DU support

2018-06-08 Thread Laurent Pinchart
y: Sergei Shtylyov Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 30 ++ > 1 file changed, 30 insertions(+) > > Index: renesas/arch/arm

Re: [PATCH v2 2/5] arm64: dts: renesas: r8a77980: add VSPD support

2018-06-08 Thread Laurent Pinchart
-domains = < R8A77980_PD_ALWAYS_ON>; > > + resets = < 623>; > > + renesas,fcp = <>; > > + }; > > + > > fcpvd0: fcp@fea27000 { > > compatible = "renesas,fcpv"; > > reg = <0 0xfea27000 0 0x200>; -- Regards, Laurent Pinchart

Re: [PATCH 2/2] arm64: dts: renesas: r8a77995: Fix VSP registers range

2018-06-08 Thread Laurent Pinchart
Hi Geert, On Friday, 8 June 2018 14:53:28 EEST Geert Uytterhoeven wrote: > On Fri, Jun 8, 2018 at 1:18 PM Laurent Pinchart wrote: > > The R8A77995 VSP and FCP nodes have overlapping register ranges, as the > > SoC integrates the FCP devices in the memory range usually used by

[PATCH] arm64: dts: renesas: Fix VSPD registers range

2018-06-08 Thread Laurent Pinchart
64: dts: renesas: r8a77995: add VSP instances") Fixes: 85cb3229218a ("arm64: dts: renesas: r8a77965: Add VSP instances") Reported-by: Simon Horman Reported-by: Geert Uytterhoeven Signed-off-by: Laurent Pinchart --- Changes since v1: - Fix H3, M3-W and M3-N in addition to V3H and D3

[PATCH 1/2] arm64: dts: renesas: r8a77970: Fix VSP registers range

2018-06-08 Thread Laurent Pinchart
77970: add VSPD support") Reported-by: Simon Horman Reported-by: Geert Uytterhoeven Signed-off-by: Laurent Pinchart --- arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/d

[PATCH 2/2] arm64: dts: renesas: r8a77995: Fix VSP registers range

2018-06-08 Thread Laurent Pinchart
77995: add VSP instances") Reported-by: Simon Horman Reported-by: Geert Uytterhoeven Signed-off-by: Laurent Pinchart --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm6

[PATCH v5 2/2] arm64: dts: renesas: Convert to new LVDS DT bindings

2018-06-05 Thread Laurent Pinchart
The internal LVDS encoder now has DT bindings separate from the DU. Port the r8a7795 and r8a7796 device trees over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v4: - Squashed the r8a7795 and r8a7796 changes together Changes since v3: - Added power-domains and resets

[PATCH v5 1/2] ARM: dts: rcar-gen2: Convert to new DU DT bindings

2018-06-05 Thread Laurent Pinchart
The DU DT bindings have been updated to drop the reg-names property. Update the r8a7792 and r8a7794 device trees accordingly. Signed-off-by: Laurent Pinchart --- Changes since v4: - Fixed typo in commit message - Squashed the r8a7792 and r8a7794 changes together --- arch/arm/boot/dts/r8a7792

[PATCH v5 0/2] R-Car DU: Convert DT to new DU and LVDS bindings

2018-06-05 Thread Laurent Pinchart
Hello, This small patch series contains the last two remaining patches from "[PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver". Apart from the individual SoC patches being squashed together as requested by the ARM-SoC maintainers there's nothing special here. Laurent P

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-05-28 Thread Laurent Pinchart
Hi Simon, On Monday, 28 May 2018 12:39:17 EEST Simon Horman wrote: > On Fri, May 25, 2018 at 01:23:53PM +0300, Laurent Pinchart wrote: > > On Friday, 25 May 2018 13:13:20 EEST Simon Horman wrote: > >> On Thu, May 24, 2018 at 11:00:52AM +0300, Laurent Pinchart wrote: >

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-26 Thread Laurent Pinchart
On Saturday, 26 May 2018 19:16:54 EEST Laurent Pinchart wrote: > Hi Dimitri, And sorry for the spelling mistake :-/ > Thank you for the patch. > > I'll review this in details, but as this patch is based on the "[PATCH/RFC > 1/4] drm: Add colorkey properties" patch I've

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-26 Thread Laurent Pinchart
ane > properties related to the color keying to cover various HW capabilities. > > This patch is based on the initial work done by Laurent Pinchart, most of > credits for this patch goes to him. > > Signed-off-by: Dmitry Osipenko <dig...@gmail.com> > --- > drivers/gpu/

Re: [PATCH 4/8] drm/rcar-du: fix merge conflict for state->alpha

2018-05-25 Thread Laurent Pinchart
car_du_vsp.c > @@ -322,7 +322,7 @@ rcar_du_vsp_plane_atomic_duplicate_state(struct > drm_plane *plane) return NULL; > > __drm_atomic_helper_plane_duplicate_state(plane, >state); > - copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha; > + copy->state.alpha = plane->state->alpha; > > return >state; > } -- Regards, Laurent Pinchart

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-05-25 Thread Laurent Pinchart
Hi Simon, On Friday, 25 May 2018 13:13:20 EEST Simon Horman wrote: > On Thu, May 24, 2018 at 11:00:52AM +0300, Laurent Pinchart wrote: > > On Wednesday, 21 February 2018 18:39:25 EEST Simon Horman wrote: > >> On Wed, Feb 21, 2018 at 01:10:30AM +0200, Laurent Pinchart wrote: [sn

[PATCH] v4l: vsp1: Fix YCbCr planar formats pitch calculation

2018-05-24 Thread Laurent Pinchart
oji Matsuoka <koji.matsuoka...@renesas.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/dri

[PATCH] v4l: vsp1: Update LIF buffer thresholds

2018-05-24 Thread Laurent Pinchart
the driver to use the recommended values for optimal operation. Based on a BSP patch from Koji Matsuoka <koji.matsuoka...@renesas.com>, with Gen2 and V3H/V3M updates. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp

  1   2   3   4   5   6   7   8   9   10   >