Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-14 Thread Philippe Ombredanne
- /dev/null >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> @@ -0,0 +1,495 @@ >> +// SPDX-License-Identifier: GPL-2. This should be GPL-2.0 too. -- Cordially Philippe Ombredanne

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

2018-01-23 Thread Philippe Ombredanne
On Fri, Jan 12, 2018 at 2:38 PM, jacopo mondi <jac...@jmondi.org> wrote: > Hi Philippe, Laurent, Geert, > > On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote: >> On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi <jacopo+rene...@jmondi.org> >> w

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

2018-01-12 Thread Philippe Ombredanne
nstead: > +MODULE_LICENSE("GPL v2"); ... to match your > +// SPDX-License-Identifier: GPL-2.0 I know this can be confusing, but updating the MODULE_LICENSE tags definitions in module.h to match SPDX tags is unlikely to happen as it would create mayhem for everyone and every module loader relying on this established convention. -- Cordially Philippe Ombredanne

Re: [PATCH v2 6/9] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-12-29 Thread Philippe Ombredanne
version 2 as > + * published by the Free Software Foundation. > + */ Do you mind using a simpler SPDX identifier instead of this long legalese boilerplate? This is documented in Thomas doc patches. This applies to your entire patch set of course. Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH v1 07/10] v4l: i2c: Copy ov772x soc_camera sensor driver

2017-12-13 Thread Philippe Ombredanne
bute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ You may want to use the new SPDX ids as documented in Thomas doc patches instead of the loner legalese? -- Cordially Philippe Ombredanne