Hi Laurent,
On Sun, Aug 25, 2019 at 09:06:03PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> How about changing the subject to "drm: rcar-du: Document DT backward
> compatibility" ?
>
> On Sun, Aug 25, 2019 at 04:01:35PM +0200, Jac
V2 of this patch splits the DTS changes from the updating of the DU driver
comment as suggested by Laurent and Geert.
Patches based on renesas-devel-2019-08-21.
Thanks
j
Jacopo Mondi (2):
arm64: dts: renesas: Add LIF channel indices to vsps property
drm: rcar-du: kms: Expand comment in
Exand comment in the 'vsps' parsing routine to specify why the LIF
channel index is defaulted to 0 in case the second cell of the property
is not specified.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 6 +-
1 file
aulting it to 0 if not specified.
Align all device tree files by specifying the LIF channel index as
prescribed by the bindings documentation.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a774a1.dtsi| 2 +-
arch/arm64/boot/dts/renesas/r8a779
Hi Laurent,
On Fri, Aug 23, 2019 at 03:12:09AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Thu, Aug 22, 2019 at 09:56:00PM +0200, Jacopo Mondi wrote:
> > According to the Renesas R-Car DU bindings documentation, the 'vsps'
>
mpatibility with non-standard DTB
found in the wild.
Signed-off-by: Jacopo Mondi
---
Patch based on Geert's latest renesas-devel master branch
---
arch/arm64/boot/dts/renesas/r8a774a1.dtsi| 2 +-
arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r8a7796.dtsi
because of lack of hardware or some deeper reason?
>
> Beause, I don't have such hardware
Tested on Salvator-XS M3-N.
Tested-by: Jacopo Mondi
Thanks
j
>
> Best regards
> ---
> Kuninori Morimoto
signature.asc
Description: PGP signature
Hi Laurent,
On Sat, May 11, 2019 at 09:16:18PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Wed, May 08, 2019 at 07:34:20PM +0200, Jacopo Mondi wrote:
> > Add device tree bindings documentation for the Renesas R-Car Display
> > U
Hi Laurent,
thanks for the comments
On Sat, May 11, 2019 at 09:23:30PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Wed, May 08, 2019 at 07:34:21PM +0200, Jacopo Mondi wrote:
> > Document the newly added 'cmms' property which ac
Save a reference to the CMM unit associated with the CRTC and set it up
at rcar_du_crtc_setup() time, just after having enabled the compositor.
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 38 --
drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2
Enable the CMM units present in the group through the display unit
extensional function control group register DEFR7.
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_group.c | 8
drivers/gpu/drm/rcar-du/rcar_du_regs.h | 5 +
2 files changed, 13 insertions(+)
diff
Add CMM units to Renesas R-Car M3-W device tree and reference them from
the Display Unit they are connected to.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas
Add clock defintions for CMM units on Renesas R-Car Gen3 M3-W.
Signed-off-by: Jacopo Mondi
---
drivers/clk/renesas/r8a7796-cpg-mssr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c
b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 12c455859f2c
welcome suggestions on how to expose
the CMM tables and controls with DRM/KMS properties, which in my opinion should
be done on top of this series.
Not-Yet-Signed-off-by: Jacopo Mondi
Thanks
j
Jacopo Mondi (9):
dt-bindings: display: renesas,cmm: Add R-Car CMM documentation
dt-bindings: disp
Add device tree bindings documentation for the Renesas R-Car Display
Unit Color Management Module.
CMM is the image enhancement module available on each R-Car DU video
channel.
Signed-off-by: Jacopo Mondi
---
.../bindings/display/renesas,cmm.txt | 24 +++
1 file
the DRM/KMS properties
framework.
As of now, the driver is only useful to demonstrate the integration with
the DU driver.
Not-Yet-Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/Kconfig | 7 +++
drivers/gpu/drm/rcar-du/Makefile | 1 +
drivers/gpu/drm/rcar-du/rcar_du_cmm.c | 78
Implement device tree parsing to collect the available CMM units and
store them in the group to be later enabled at start up time.
Define a new feature to let each SoC claim support for CMM.
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 4 ++
drivers/gpu/drm/rcar
R-Car M3-W provides a CMM for each of it's DU output channel. Add CMM as
a supported feature for the SoC.
Temporary commit to be later expanded to all Gen3 SoCs V3H/M apart.
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++-
1 file changed, 2 insertions(
Document the newly added 'cmms' property which accepts a list of phandle
and channel index pairs that point to the CMM units available for each
Display Unit output video channel.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/display/renesas,du.txt | 4
1 file
Hi Laurent,
On Tue, Apr 23, 2019 at 05:46:51PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Tue, Apr 23, 2019 at 03:55:08PM +0200, Jacopo Mondi wrote:
> > On Thu, Mar 28, 2019 at 09:07:20AM +0200, Laurent Pinchart wrote:
> > > Add support for the V4L2_PIX_FMT_RGBA5
gt; + .planes = 1,
> + }, {
> + .fourcc = DRM_FORMAT_BGRX5551,
> + .v4l2 = V4L2_PIX_FMT_BGRX555,
> + .bpp = 16,
> + .planes = 1,
I have compared the format definitions and they seems fine to me!
Reviewed-by: Jacopo
gt; + .planes = 1,
> + }, {
> + .fourcc = DRM_FORMAT_BGRX,
> + .v4l2 = V4L2_PIX_FMT_BGRX444,
> + .bpp = 16,
> + .planes = 1,
Compared the DRM and V4L2 format definitions, they look sane to me!
Reviewed-by: Jacopo
.v4l2 = V4L2_PIX_FMT_RGBX32,
> + .bpp = 32,
> + .planes = 1,
Compared the format definitions between DRM and V4L2 and they seems to
match to me.
Reviewed-by: Jacopo Mondi
Thanks
j
> }, {
> .fourcc = DRM_FORMAT_BGRA,
> .v4l2 = V4L2_PIX_FMT_ARGB32,
> --
> Regards,
>
> Laurent Pinchart
>
signature.asc
Description: PGP signature
r abgg
ggra bggg
But I have not find any better combination from table 23.10 that would
result in the desired 'gggr abgg' ordering.
> +#define V4L2_PIX_FMT_BGRX555 v4l2_fourcc('B', 'X', '1', '5') /* 16
> BG
P_LWS |
I assume s/V4L2_PIX_FMT_ABGR444/VI6_FMT_ABGR_/
The other entries looks fine to me (by comparing the destination pixel
format with the input one with the DSWAP flags applied).
With the above fixed:
Reviewed-by: Jacopo Mondi
Thanks
j
> + VI6_RPF_DSWAP_P_WDS,
> +
Hi Laurent,
On Thu, Apr 18, 2019 at 09:06:45AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Thu, Apr 04, 2019 at 07:39:05PM +0200, Jacopo Mondi wrote:
> > HI Laurent,
> > if you help me out understanding the bit swapping procedure in VSP
> > I would be more con
> Changes since v1:
>
> - Fixed the BGRA555 and BGRX555 formats
With this fixed (happy my wrong comment lead to an actual fix :p )
Reviewed-by: Jacopo Mondi
Thanks
j
> ---
> .../media/uapi/v4l/pixfmt-packed-rgb.rst | 138 ++
> include/uapi/linux/vid
Hi Kieran,
On Fri, Apr 12, 2019 at 04:57:45PM +0100, Kieran Bingham wrote:
> Hi Jacopo,
>
> On 12/04/2019 15:45, Jacopo Mondi wrote:
> > Hi Kieran,
> >
> > On Fri, Apr 12, 2019 at 03:15:46PM +0100, Kieran Bingham wrote:
> >> Hi Jacopo,
> >>
> >&g
gned-off-by: Takeshi Kihara
[reworded commit message, sent upstream]
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 9763d108e183.
me you've been carrying this patch in your tree for your RSKRZA1
recent developments.
Acked-by: Jacopo Mondi
Thanks
j
> Signed-off-by: Geert Uytterhoeven
> ---
> To be queued in sh-pfc-for-v5.2.
>
> drivers/pinctrl/pinctrl-rza1.c | 18 ++
> 1 file c
Hi Laurent
On Fri, Mar 08, 2019 at 08:00:28PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Fri, Mar 08, 2019 at 06:32:59PM +0100, Jacopo Mondi wrote:
> > On Thu, Mar 07, 2019 at 01:23:36AM +0200, Laurent Pinchart wrote:
> > > Set a drm_bridge_timings in the drm_brid
HI Laurent,
On Fri, Mar 08, 2019 at 07:57:39PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Fri, Mar 08, 2019 at 05:49:25PM +0100, Jacopo Mondi wrote:
> > On Thu, Mar 07, 2019 at 01:23:35AM +0200, Laurent Pinchart wrote:
> > > The THC63LVD1024 LVDS decoder can oper
Hi Laurent,
On Fri, Mar 08, 2019 at 08:12:39PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Fri, Mar 08, 2019 at 06:20:23PM +0100, Jacopo Mondi wrote:
> > On Thu, Mar 07, 2019 at 01:23:41AM +0200, Laurent Pinchart wrote:
> > > In dual-link mode the LVDS0 encoder
Hi Kangjie,
thanks for the patch.
On Sat, Mar 09, 2019 at 01:14:24AM -0600, Kangjie Lu wrote:
> In case of_match_device cannot find a match, the check returns
> -EINVAL to avoid a potential NULL pointer dereference
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/media/platform/renesas-ceu.c | 5
Hi Laurent,
On Thu, Mar 07, 2019 at 01:23:36AM +0200, Laurent Pinchart wrote:
> Set a drm_bridge_timings in the drm_bridge, and use it to report the
> input bus mode (single-link or dual-link). The other fields of the
> timings structure are kept to 0 as they do not apply to LVDS buses.
>
> Signed
Hi Laurent,
On Thu, Mar 07, 2019 at 01:23:41AM +0200, Laurent Pinchart wrote:
> In dual-link mode the LVDS0 encoder transmits even-numbered pixels, and
> sends odd-numbered pixels to the LVDS1 encoder for transmission on a
> separate link.
>
> To implement support for this mode of operation, deter
Hi Laurent,
On Thu, Mar 07, 2019 at 01:23:35AM +0200, Laurent Pinchart wrote:
> The THC63LVD1024 LVDS decoder can operate in two modes, single-link or
> dual-link. In dual-link mode both input ports are used to carry even-
> and odd-numbered pixels separately. Document this in the DT bindings,
> a
Hi Laurent,
thanks, this matches section 37.1.1 of v1.50 datasheet
Reviewed-by: Jacopo Mondi
Thanks
j
On Thu, Mar 07, 2019 at 01:23:39AM +0200, Laurent Pinchart wrote:
> The D3 and E3 SoCs have different pixel clock frequency limits for the
> LVDS encoder than the other SoCs in th
around this.
> + rcar_lvds_write(lvds, LVDCR0, lvdcr0);
I have verified this against the latest v1.50 datasheet, and it
matches what's reported in section 37.3.7 so please add my:
Reviewed-by: Jacopo Mondi
I would like just to add that the same section prescribes a pre
Hi Sakari,
thanks for the review
On Thu, Mar 07, 2019 at 05:19:29PM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> Thanks for writing the documentation for this!
>
> The text is nice and informative; I have a few suggestions below.
>
> On Tue, Mar 05, 2019 at 07:51:38PM +010
Hi Sakari and Niklas,
On Thu, Mar 07, 2019 at 11:47:26AM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Mar 05, 2019 at 07:51:19PM +0100, Jacopo Mondi wrote:
> > Hello,
> >third version of multiplexed stream support patch series.
> >
> > V2 sent by
Hi Laurent,
On Fri, Mar 08, 2019 at 01:29:38PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Thu, Mar 07, 2019 at 11:35:11AM +0100, Jacopo Mondi wrote:
> > On Wed, Mar 06, 2019 at 09:15:21PM +0200, Laurent Pinchart wrote:
> > > On Wed, Mar 06, 2019 at 12:26:59PM +
Hi Sakari,
On Thu, Mar 07, 2019 at 02:56:10PM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Mar 05, 2019 at 07:51:50PM +0100, Jacopo Mondi wrote:
> > Now that the rcar-csi2 subdevice supports internal routing, add an
> > has_route() operation used during graph t
Hi Ian, Sakari,
On Thu, Mar 07, 2019 at 10:27:36AM +, Ian Arkver wrote:
> On 07/03/2019 10:09, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > On Tue, Mar 05, 2019 at 07:51:31PM +0100, Jacopo Mondi wrote:
> > > From: Sakari Ailus
> > >
> > > Add
Hi Laurent,
On Wed, Mar 06, 2019 at 09:15:21PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Wed, Mar 06, 2019 at 12:26:59PM +0100, Jacopo Mondi wrote:
> > When both the media links between AFE and HDMI and the two TX CSI-2 outputs
> > gets disabled, the routing regist
Hi Laurent!
On Wed, Mar 06, 2019 at 03:13:55PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Wed, Mar 06, 2019 at 11:03:32AM +0100, Jacopo Mondi wrote:
> > On Sat, Mar 02, 2019 at 06:17:25PM +0200, Laurent Pinchart wrote:
> > > The R-Car DU driver assumes that a bridg
preventing writing 0 to
ADV748X_IO_10 register, which gets only updated when links are enabled
again.
Fixes: 9423ca350df7 ("media: adv748x: Implement TX link_setup callback")
Signed-off-by: Jacopo Mondi
---
The issue presents itself only on some HDMI transmitters, and went unnoticed
Hi Laurent,
On Sat, Mar 02, 2019 at 06:17:25PM +0200, Laurent Pinchart wrote:
> The R-Car DU driver assumes that a bridge is always connected to the DU
> output. This is valid for the LVDS and HDMI outputs, but the DPAD
> outputs can be connected directly to a panel, in which case no bridge is
> a
HI Laurent,
On Tue, Mar 05, 2019 at 10:04:58PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Mon, Mar 04, 2019 at 01:35:36PM +0100, Jacopo Mondi wrote:
> > On Fri, Feb 22, 2019 at 02:18:11PM +0200, Laurent Pinchart wrote:
> > > On Mon, Feb 18, 2019 at 10:21:07AM +
Now that the adv748x subdevice supports internal routing, add an
has_route() operation used during media graph traversal.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/adv748x/adv748x-afe.c | 26 +
1 file changed, 26 insertions(+)
diff --git a/drivers/media/i2c
From: Sakari Ailus
Add CSI-2 bus specific configuration to the frame descriptors. This allows
obtaining the virtual channel and data type information for each stream
the transmitter is sending.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
---
include
transmitting the
stream.
Signed-off-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/adv748x/adv748x-csi2.c | 65
1 file changed, 65 insertions(+)
diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c
b/drivers/media/i2c/adv748x/adv748x-csi2.c
index
Söderlund
Signed-off-by: Jacopo Mondi
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 53 +
1 file changed, 53 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c
b/drivers/media/platform/rcar-vin/rcar-csi2.c
index f9cc99ba00bc..cc7077b40f18 100644
--- a
instead of the entity as an argument
for the graph walk operations. The actual graph traversal algorithm change
is in further patches.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Jacopo Mondi
---
Documentation/media/kapi/mc-core.rst
Add documentation for VIDIOC_SUBDEV_G/S_ROUTING ioctl and add
description of multiplexed media pads and internal routing to the
V4L2-subdev documentation section.
Signed-off-by: Jacopo Mondi
---
Documentation/media/uapi/v4l/dev-subdev.rst | 90 +++
Documentation/media/uapi/v4l/user
Reviewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-mc.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-mc.c
b/drivers/media/v4l2-core/v4l2-mc.c
s now meaningful to have different
formats on the different source pads. Make source formats independent
off each other and disallowing a format on the multiplexed sink pad.
Signed-off-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
---
drivers/media/platform/rcar-vin/rcar-csi2.c
Reviewed-by: Jacopo Mondi
---
Documentation/media/kapi/mc-core.rst | 7 ++-
drivers/media/media-entity.c | 46 ++
drivers/media/platform/exynos4-is/media-dev.c | 20
drivers/media/platform/omap3isp/ispvideo.c| 17 +++
drivers/media/platform/vsp1
: Niklas Söderlund
- Make __media_entity_next_routed_pad() return NULL and adjust the
iterator to handle that
Signed-off-by: Jacopo Mondi
---
include/media/media-entity.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/include/media/media-entity.h b/include/media
apturing images transmitted on different
virtual channels.
Series available at:
git://jmondi.org/linux v4l2-mux/media-master-v5.0/v3
Thanks
j
Jacopo Mondi (4):
media: entity: Add iterator helper for entity pads
media: Documentation: Add GS_ROUTING documentation
adv748x: afe: Implement has_r
From: Sakari Ailus
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
- Make the bus type a named enum
Signed-off-by: Jacopo Mondi
---
include/media/v4l2-subdev.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
.get_frame_desc().
Signed-off-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/adv748x/adv748x-csi2.c | 31 +++-
drivers/media/i2c/adv748x/adv748x.h | 1 +
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c
b
Add an iterator helper to easily cycle through all pads in an entity and
use it in media-entity and media-device code where appropriate.
Signed-off-by: Jacopo Mondi
---
drivers/media/media-device.c | 13 ++---
drivers/media/media-entity.c | 11 ++-
include/media/media-entity.h
.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Tested-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-subdev.c | 220 --
1 file changed, 206 insertions(+), 14 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c
b/drivers/media/v4l2-core/v4l2-subdev.c
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/adv748x/adv748x-csi2.c | 22 ++
1 file changed, 6 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c
b/drivers/media/i2c/adv748x/adv748x-csi2.c
index 25798d723174..1abe34183d7d 100644
--- a
From: Sakari Ailus
The stream field identifies the stream this frame descriptor applies to in
routing configuration across a multiplexed link.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
---
include/media/v4l2-subdev.h | 2 ++
1 file changed, 2
From: Sakari Ailus
The existing link format validation failure debug message in media-entity.c
helped to poinpoint the point of failure but provided no additional
information what's wrong. Tell the user exactly why the validation failed.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
.
Signed-off-by: Jacopo Mondi
---
drivers/media/platform/rcar-vin/rcar-csi2.c | 35 +
1 file changed, 35 insertions(+)
diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c
b/drivers/media/platform/rcar-vin/rcar-csi2.c
index cc7077b40f18..6c46bcc0ee83 100644
--- a/drivers
Söderlund
- Expand and refine documentation.
- Make the 'routes' pointer a __u64 __user pointer so that a compat32
version of the ioctl is not required.
- Add struct v4l2_subdev_krouting to be used for subdevice operations.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4
From: Sakari Ailus
A single entity may contain multiple pipelines. Only add pads that were
connected to the pad through which the entity was reached to the pipeline.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
ff-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/adv748x/adv748x-afe.c | 65 +
1 file changed, 65 insertions(+)
diff --git a/drivers/media/i2c/adv748x/adv748x-afe.c
b/drivers/media/i2c/adv748x/adv748x-afe.c
index dbbb1e4d6363..3f770f71413f 100644
From: Sakari Ailus
With the addition of the has_route() media entity operation, all pads of an
entity are no longer interconnected. The S_ROUTING IOCTL for sub-devices can
be used to enable and disable routes for an entity. The consequence is that
the routing information has to be taken into acco
From: Laurent Pinchart
This is a wrapper around the media entity has_route operation.
Signed-off-by: Laurent Pinchart
Signed-off-by: Michal Simek
Signed-off-by: Sakari Ailus
Signed-off-by: Jacopo Mondi
---
drivers/media/media-entity.c | 19 +++
include/media/media-entity.h
Reviewed-by: Jacopo Mondi
---
drivers/media/media-entity.c | 44 ++--
1 file changed, 27 insertions(+), 17 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index 8e0ca8b1cfa2..3304e76bbafa 100644
--- a/drivers/media/media
.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
- Update documentation to use 'pads'
- Use the media pad iterator in media_entity.c
- Update rcar-dma.c to use the new per-pad stream count
Signed-off-by: Jacopo Mondi
---
drivers/media/medi
Ailus
Signed-off-by: Jacopo Mondi
---
include/media/media-entity.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/media/media-entity.h b/include/media/media-entity.h
index e806356b1512..675bc27b8b3c 100644
--- a/include/media/media-entity.h
+++ b/include/media/media-entity.h
t;local_pad" to convey the fact
the route to be checked is internal to the entity.
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Signed-off-by: Jacopo Mondi
---
drivers/media/media-entity.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/me
From: Sakari Ailus
The pipeline has been moved from the entity to the pads; reflect this in
the media pipeline function API.
Signed-off-by: Sakari Ailus
Signed-off-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Jacopo Mondi
---
Documentation/media/kapi/mc-core.rst
: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/media-entity.c | 53 ++--
include/media/media-entity.h | 8 +++---
2 files changed, 30 insertions(+), 31 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index
From: Niklas Söderlund
Prepare to implement frame descriptors to support multiplexed streams by
adding a function to map pixelcode to CSI-2 datatype. This is needed to
properly be able to fill out the struct v4l2_mbus_frame_desc.
Signed-off-by: Niklas Söderlund
Reviewed-by: Jacopo Mondi
From: Sakari Ailus
Signed-off-by: Sakari Ailus
Reviewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
Reviewed-by: Jacopo Mondi
---
drivers/media/media-entity.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index
Hi Laurent,
On Fri, Feb 22, 2019 at 02:18:11PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Mon, Feb 18, 2019 at 10:21:07AM +0100, Jacopo Mondi wrote:
> > On Tue, Jan 22, 2019 at 05:20:30PM +0200, Laurent Pinchart wrote:
> > > On Tue, Jan 22, 2019 at 05:15:06PM +
Hi Sakari,
thanks for your suggestions.
On Fri, Feb 22, 2019 at 01:04:29PM +0200, Sakari Ailus wrote:
> Hi Jacopo,
[snip]
> > On the previous example, I thought about GMSL-like devices, that can
> > output the video streams received from different remotes in a
> > separate virtual channel, a
Hi Sakari,
On Fri, Feb 22, 2019 at 01:49:36AM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Thu, Feb 21, 2019 at 03:59:20PM +0100, Jacopo Mondi wrote:
> > Hi Sakari, Laurent, Niklas,
> >(another) quick question, but a different one :)
> >
> > On Wed, Jan 16,
Hi Sakari,
On Fri, Feb 22, 2019 at 12:31:32AM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Thu, Feb 21, 2019 at 03:39:40PM +0100, Jacopo Mondi wrote:
> > Hi Sakari,
> >one quick question
> >
> > On Fri, Nov 02, 2018 at 12:31:30AM +0100, Niklas Söderlund wr
Hi Sakari,
one quick question
On Fri, Nov 02, 2018 at 12:31:30AM +0100, Niklas Söderlund wrote:
> From: Laurent Pinchart
>
> Signed-off-by: Laurent Pinchart
> Signed-off-by: Michal Simek
>
> - Add sink and source streams for multiplexed links
> - Copy the argument back in case of an error. T
Hi Sakari, Laurent, Niklas,
(another) quick question, but a different one :)
On Wed, Jan 16, 2019 at 01:51:45AM +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Fri, Nov 02, 2018 at 12:31:30AM +0100, Niklas Söderlund wrote:
> > From: Laurent Pinchart
> >
> > Sign
Hi Niklas,
On Fri, Nov 02, 2018 at 12:31:39AM +0100, Niklas Söderlund wrote:
> Once the CSI-2 subdevice of the ADV748X becomes aware of multiplexed
> streams the format of the source pad is of no value as it carries
> multiple streams. Prepare for this by explicitly denying setting a
> format on a
Hi Laurent, Sakari,
On Wed, Jan 16, 2019 at 01:53:03AM +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Fri, Nov 02, 2018 at 12:31:31AM +0100, Niklas Söderlund wrote:
> > From: Sakari Ailus
> >
> > Implement compat IOCTL handling for VIDIOC_SUBDEV_G_ROUTING and
> >
Hi Laurent, Sakari,
On Tue, Jan 22, 2019 at 05:20:30PM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Tue, Jan 22, 2019 at 05:15:06PM +0200, Sakari Ailus wrote:
> > On Wed, Jan 16, 2019 at 12:57:43AM +0200, Laurent Pinchart wrote:
> > >>
> > >> This way the pads are always passed to the has_ro
Hi Niklas,
ah, ups, this was maybe the patch the other one I just reviewed was
based on... sorry, I missed this one :)
On Sat, Feb 16, 2019 at 11:56:38PM +0100, Niklas Söderlund wrote:
> Later versions of the datasheet updates the reset procedure to more
> closely resemble the standby mode.
Hi Niklas,
where is this patch supposed to be applied on?
I tried master, media master, renesas-drivers and your rcar-csi2 and
v4l2/mux branches, but it fails on all of them :(
What am I doing wrong?
On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> Allow the hardware to to
Hi Sakari,
thanks for the patches
On Fri, Nov 02, 2018 at 12:31:19AM +0100, Niklas Söderlund wrote:
> From: Sakari Ailus
>
> This moves the pipe and stream_count fields from struct media_entity to
> struct media_pad. Effectively streams become pad-specific rather than
> being stream specific,
Hello,
as I anticipated to Sakari I would like to revive this series,
so I've started from V2 and I'm trying to close comments to re-submit.
In the meantime, I might have some more questions...
On Fri, Nov 02, 2018 at 12:31:17AM +0100, Niklas Söderlund wrote:
> From: Sakari Ailus
>
> Instead o
;
> > Thanks for your patch.
> >
> > On 2019-01-10 15:02:10 +0100, Jacopo Mondi wrote:
> > > The ADV748x chip supports routing AFE output to either TXA or TXB.
> > > In order to support run-time configuration of video stream path, create an
> > > additional
Hi Niklas,
On Mon, Jan 14, 2019 at 03:55:33PM +0100, Niklas Söderlund wrote:
[snip]
> > + /* Register link to HDMI for TXA only. */
> > + if (is_txb(tx) || !is_hdmi_enabled(state))
>
> Small nit, I would s/is_txb(tx)/!is_txa(tx)/ here as to me it becomes
> easier to read. With or without thi
nitions").
>
> This reduces kernel size for an R-Car Gen3 kernel by almost 1 KiB.
>
> I plan to queue these in sh-pfc-for-v5.1.
>
> Thanks!
Thanks for this. I have compared the new tables in the series with the
removed ones (but not against the datasheet, as I assume what was
al
statically
selected as the s_stream functions are currently doing.
To fix this, store a reference to the active CSI-2 TX sink for both HDMI and
AFE sources, and operate on it when starting/stopping the stream.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
When the adv748x driver is informed about a link being created from HDMI or
AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make
sure to implement proper routing management at link setup time, to route
the selected video stream to the desired TX output.
Signed-off-
is not meaningful anymore.
To fix this, store the subdevice of the source providing video data to the
CSI-2 TX in the 'struct adv748x_csi2' representing the TX and check on it.
Reviewed-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/media/i
1 - 100 of 1032 matches
Mail list logo
