Re: [PATCH 1/5] pinctrl: sh-pfc: r8a77470: Add I2C4 pin groups
Hi Fabrizio,
On Wed, Sep 19, 2018 at 11:50 AM Fabrizio Castro
wrote:
> > Subject: Re: [PATCH 1/5] pinctrl: sh-pfc: r8a77470: Add I2C4 pin groups
> > On Tue, Sep 18, 2018 at 3:48 PM Fabrizio Castro
> > wrote:
> > > Add I2C4 pin groups and function to the R8A77470 SoC.
> >
> > Thanks for your patch!
> >
> > Any specific reason you added I2C4 only, and not the other I2C instances?
> > Usually we add all of them in one run.
>
> The iwg23s is a very small Raspberry Pi like SBC, there isn't much on it,
> therefore we can't test all of the interfaces we would like to test.
> The plan is to start supporting what we can easily test/access, for
> everything else we would like to wait and see, maybe at a later stage?
If your target is just the iwg23s, this is indeed fine.
However, you may have customers who want to use this SoC in their own products,
and thus aren't limited to the pins available on iwg23s.
Including this support upstream makes their life easier. While not everything
can be tested, it will at least have received some review.
Anyway, I'll queue this series in sh-pfc-for-v4.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
RE: [PATCH 1/5] pinctrl: sh-pfc: r8a77470: Add I2C4 pin groups
Hello Geert,
Thank you for your feedback.
> Subject: Re: [PATCH 1/5] pinctrl: sh-pfc: r8a77470: Add I2C4 pin groups
>
> Hi Fabrizio,
>
> On Tue, Sep 18, 2018 at 3:48 PM Fabrizio Castro
> wrote:
> > Add I2C4 pin groups and function to the R8A77470 SoC.
>
> Thanks for your patch!
>
> Any specific reason you added I2C4 only, and not the other I2C instances?
> Usually we add all of them in one run.
The iwg23s is a very small Raspberry Pi like SBC, there isn't much on it,
therefore we can't test all of the interfaces we would like to test.
The plan is to start supporting what we can easily test/access, for everything
else we would like to wait and see, maybe at a later stage?
Thanks,
Fab
>
> > Signed-off-by: Fabrizio Castro
> > Reviewed-by: Biju Das
>
> Reviewed-by: Geert Uytterhoeven
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End,
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered
No. 04586709.
Re: [PATCH 1/5] pinctrl: sh-pfc: r8a77470: Add I2C4 pin groups
Hi Fabrizio,
On Tue, Sep 18, 2018 at 3:48 PM Fabrizio Castro
wrote:
> Add I2C4 pin groups and function to the R8A77470 SoC.
Thanks for your patch!
Any specific reason you added I2C4 only, and not the other I2C instances?
Usually we add all of them in one run.
> Signed-off-by: Fabrizio Castro
> Reviewed-by: Biju Das
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
