Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Marek Vasut
On 2/18/19 2:41 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Mon, Feb 18, 2019 at 2:38 PM Marek Vasut wrote: >> On 2/18/19 2:32 PM, Geert Uytterhoeven wrote: >> struct pinmux_data_reg { >> u32 reg; >> u8 reg_width; >> @@ -270,6 +274,7 @@ struct sh_pfc_soc_i

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Geert Uytterhoeven
Hi Marek, On Mon, Feb 18, 2019 at 2:48 PM Marek Vasut wrote: > On 2/18/19 2:41 PM, Geert Uytterhoeven wrote: > > On Mon, Feb 18, 2019 at 2:38 PM Marek Vasut wrote: > >> On 2/18/19 2:32 PM, Geert Uytterhoeven wrote: > >> struct pinmux_data_reg { > >> u32 reg; > >> u8

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Marek Vasut
On 2/18/19 2:52 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Mon, Feb 18, 2019 at 2:48 PM Marek Vasut wrote: >> On 2/18/19 2:41 PM, Geert Uytterhoeven wrote: >>> On Mon, Feb 18, 2019 at 2:38 PM Marek Vasut wrote: On 2/18/19 2:32 PM, Geert Uytterhoeven wrote: struct pinmux_d

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Geert Uytterhoeven
Hi Marek, On Mon, Feb 18, 2019 at 2:38 PM Marek Vasut wrote: > On 2/18/19 2:32 PM, Geert Uytterhoeven wrote: > struct pinmux_data_reg { > u32 reg; > u8 reg_width; > @@ -270,6 +274,7 @@ struct sh_pfc_soc_info { > const struct pinmux_drive_reg *driv

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Marek Vasut
On 2/18/19 2:32 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, [...] struct pinmux_data_reg { u32 reg; u8 reg_width; @@ -270,6 +274,7 @@ struct sh_pfc_soc_info { const struct pinmux_drive_reg *drive_regs; const struct pinmux_bias_reg

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Geert Uytterhoeven
Hi Marek, On Mon, Feb 18, 2019 at 1:59 PM Marek Vasut wrote: > On 2/18/19 9:43 AM, Geert Uytterhoeven wrote: > > On Sat, Feb 16, 2019 at 2:49 PM wrote: > >> The TDSELCTRL register is responsible for configuring the SDHI clock > >> return path delay and may be adjusted by the bootloader. Retain t

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Marek Vasut
On 2/18/19 9:43 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Sat, Feb 16, 2019 at 2:49 PM wrote: >> The TDSELCTRL register is responsible for configuring the SDHI clock >> return path delay and may be adjusted by the bootloader. Retain the >> value across suspend/resume to prevent hardware

Re: [PATCH] pinctrl: sh-pfc: Retain TDSELCTRL register across suspend/resume

2019-02-18 Thread Geert Uytterhoeven
Hi Marek, On Sat, Feb 16, 2019 at 2:49 PM wrote: > The TDSELCTRL register is responsible for configuring the SDHI clock > return path delay and may be adjusted by the bootloader. Retain the > value across suspend/resume to prevent hardware instability after > resume. > > Signed-off-by: Marek Vasu