Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

Hi Geert, On 13/02/18 17:36, Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by > default") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Eric

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

Hi Geert, On 21/02/18 17:07, Geert Uytterhoeven wrote: > Hi Eric, > > On Wed, Feb 14, 2018 at 10:32 AM, Geert Uytterhoeven > wrote: >> On Wed, Feb 14, 2018 at 9:36 AM, Auger Eric wrote: >>> If I am not wrong we also leak the reset_module if >>>

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

Hi Eric, On Wed, Feb 14, 2018 at 10:32 AM, Geert Uytterhoeven wrote: > On Wed, Feb 14, 2018 at 9:36 AM, Auger Eric wrote: >> If I am not wrong we also leak the reset_module if >> vfio_platform_get_reset() fails to find the reset function (of_reset ==

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

Hi Eric, On Wed, Feb 14, 2018 at 9:36 AM, Auger Eric wrote: > If I am not wrong we also leak the reset_module if > vfio_platform_get_reset() fails to find the reset function (of_reset == > NULL), in which case we should do the module_put() in > vfio_platform_get_reset().

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

Hi Geert, On 13/02/18 17:36, Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by > default") > Signed-off-by: Geert Uytterhoeven > --- >