Re: [PATCH/RFC net] ravb: Remove Rx overflow log messages

[Sergei Shtylyov]

On 01/12/2017 11:41 AM, Simon Horman wrote:


From: Kazuya Mizuguchi 

Remove Rx overflow log messages as in an environment where logging results
in network traffic logging may cause further overflows.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Kazuya Mizuguchi 
[simon: reworked changelog]
Signed-off-by: Simon Horman 


Acked-by: Sergei Shtylyov 

MBR, Sergei

[PATCH/RFC net] ravb: Remove Rx overflow log messages

[Simon Horman]

From: Kazuya Mizuguchi 

Remove Rx overflow log messages as in an environment where logging results
in network traffic logging may cause further overflows.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Kazuya Mizuguchi 
[simon: reworked changelog]
Signed-off-by: Simon Horman 
---
 drivers/net/ethernet/renesas/ravb_main.c | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index 92d7692c840d..5e5ad978eab9 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -926,14 +926,10 @@ static int ravb_poll(struct napi_struct *napi, int budget)
/* Receive error message handling */
priv->rx_over_errors =  priv->stats[RAVB_BE].rx_over_errors;
priv->rx_over_errors += priv->stats[RAVB_NC].rx_over_errors;
-   if (priv->rx_over_errors != ndev->stats.rx_over_errors) {
+   if (priv->rx_over_errors != ndev->stats.rx_over_errors)
ndev->stats.rx_over_errors = priv->rx_over_errors;
-   netif_err(priv, rx_err, ndev, "Receive Descriptor Empty\n");
-   }
-   if (priv->rx_fifo_errors != ndev->stats.rx_fifo_errors) {
+   if (priv->rx_fifo_errors != ndev->stats.rx_fifo_errors)
ndev->stats.rx_fifo_errors = priv->rx_fifo_errors;
-   netif_err(priv, rx_err, ndev, "Receive FIFO Overflow\n");
-   }
 out:
return budget - quota;
 }
-- 
2.7.0.rc3.207.g0ac5344