Re: [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Jun 2, 2016 at 11:47 PM, Laurent Pinchart
 wrote:
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt
>> @@ -0,0 +1,35 @@
>> +DT bindings for the Renesas R-Car Reset Controller
>> +
>> +The R-Car Reset Controller provides reset control, and implements the
>> following
>> +functions:
>> +  - Latching of the levels on mode pins when PRESET# is negated,
>> +  - Mode monitoring register,
>> +  - Reset control of peripheral devices (on R-Car Gen1),
>> +  - Watchdog timer (on R-Car Gen1).
>> +  - Register-based reset control and boot address registers for the various
>> CPU
>> +cores (on R-Car Gen2/Gen3),
>> +
>> +
>> +Required properties:
>> +  - compatible: Should be
>> +   - "renesas,-reset-wdt" for R-Car Gen1,
>> +   - "renesas,-rst" for R-Car Gen2/Gen3.
>> + Examples with soctypes are:
>> +   - "renesas,r8a7778-reset-wdt" (R-Car M1A)
>> +   - "renesas,r8a7779-reset-wdt" (R-Car H1)
>> +   - "renesas,r8a7790-rst" (R-Car H2)
>> +   - "renesas,r8a7791-rst" (R-Car M2-W)
>> +   - "renesas,r8a7792-rst" (R-Car V2H
>> +   - "renesas,r8a7793-rst" (R-Car M2-N)
>> +   - "renesas,r8a7794-rst" (R-Car E2)
>> +   - "renesas,r8a7795-rst" (R-Car H3)
>> +   - "renesas,r8a7796-rst" (R-Car M3-W)
>
> Any specific reason for such a large indentation ? (I know this is really
> nitpicking)

To align the two paragraphs and lists.

> Apart from that, it's just a bit of a shame we can't have generic compatible
> strings, but that would require additional DT properties to describe the reset
> controller features, and I assume that's not a path we want to take.

The reset controller is one of the few blocks that really differs
between members
of the same family, due to the relationship with the various CPU cores.

> Acked-by: Laurent Pinchart 

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH/RFC v3 01/22] reset: Add renesas,rst DT bindings

[Dirk Behme]

On 01.06.2016 21:20, Geert Uytterhoeven wrote:

Add DT bindings for the Renesas R-Car Reset Controller (R-Car Gen1
RESET/WDT and R-Car Gen2/Gen3 RST).

As the features provided by the hardware module differ a lot across the
various SoC families and members, only SoC-specific compatible values
are defined.

For now we use the RST only for providing access to the state of the
mode pins.

Signed-off-by: Geert Uytterhoeven 
Acked-by: Magnus Damm 
---
v3:
  - Clarify current usage,
  - Use "renesas,-rst" instead of "renesas,rst-",
  - Drop "syscon" compatible value,
  - Add R-Car M3-W,
  - Add R-Car Gen1,

v2:
  - Add Acked-by.
---
 .../devicetree/bindings/reset/renesas,rst.txt  | 35 ++
 1 file changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reset/renesas,rst.txt

diff --git a/Documentation/devicetree/bindings/reset/renesas,rst.txt 
b/Documentation/devicetree/bindings/reset/renesas,rst.txt
new file mode 100644
index ..488c72e1ee849cd3
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt
@@ -0,0 +1,35 @@
+DT bindings for the Renesas R-Car Reset Controller
+
+The R-Car Reset Controller provides reset control, and implements the following
+functions:
+  - Latching of the levels on mode pins when PRESET# is negated,
+  - Mode monitoring register,
+  - Reset control of peripheral devices (on R-Car Gen1),
+  - Watchdog timer (on R-Car Gen1).



Quite minor nit: s/./,/

Or drop all the ',' completely?



+  - Register-based reset control and boot address registers for the various CPU
+cores (on R-Car Gen2/Gen3),


Best regards

Dirk