Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
On Fri, May 12, 2017 at 04:39:03PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 2, 2017 at 12:30 PM, Simon Horman >wrote: > > The EthernetAVB should not depend on the bootloader to setup correct > > drive-strength values. Values for drive-strength where found by > > examining the registers after the bootloader has configured the > > registers and successfully used the EthernetAVB. > > > > Based on: > > * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength > > for ravb pins") > > * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength > > for ravb pins") > > > > Cc: Geert Uytterhoeven > > Cc: Niklas Söderlund > > Signed-off-by: Simon Horman > > Reviewed-by: Geert Uytterhoeven > > > * Compile tested only due to lack of hardware access > > So how did you examine the registers? ;-) You got me there: copy-paste gone wrong. > Hence I examined the registers myself: > - H3ULCB has the same register settings as Salvator-X with H3 ES1.0 > - M3ULCB has the same register settings as Salvator-X with M3-W ES1.0 > or H3 ES2.0. That was my assumption, which is what I should have written. But as you have checked - thanks for that - I will leave the changelog as-is and queue up the patch.
Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
Hi Simon, On Tue, May 2, 2017 at 12:30 PM, Simon Hormanwrote: > The EthernetAVB should not depend on the bootloader to setup correct > drive-strength values. Values for drive-strength where found by > examining the registers after the bootloader has configured the > registers and successfully used the EthernetAVB. > > Based on: > * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength > for ravb pins") > * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength > for ravb pins") > > Cc: Geert Uytterhoeven > Cc: Niklas Söderlund > Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven > * Compile tested only due to lack of hardware access So how did you examine the registers? ;-) Hence I examined the registers myself: - H3ULCB has the same register settings as Salvator-X with H3 ES1.0 - M3ULCB has the same register settings as Salvator-X with M3-W ES1.0 or H3 ES2.0. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds