Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Simon Horman]

On Wed, May 23, 2018 at 01:52:32PM +0200, Geert Uytterhoeven wrote:
> Hi Marek,
> 
> On Wed, May 23, 2018 at 1:43 PM, Marek Vasut  wrote:
> > Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> > one DA9063L and one DA9210 on Porter, the only difference from
> > the other boards is that DA9063L is at I2C address 0x5a rather
> > than 0x58 .
> 
> Ah, so porter needs the regulator quirk, too.
> 
> > Signed-off-by: Marek Vasut 
> 
> Reviewed-by: Geert Uytterhoeven 

Thanks, applied.

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Marek Vasut]

On 05/23/2018 01:52 PM, Geert Uytterhoeven wrote:
> Hi Marek,

Hi,

> On Wed, May 23, 2018 at 1:43 PM, Marek Vasut  wrote:
>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>> one DA9063L and one DA9210 on Porter, the only difference from
>> the other boards is that DA9063L is at I2C address 0x5a rather
>> than 0x58 .
> 
> Ah, so porter needs the regulator quirk, too.

Most of the boards do in fact, they just miss the regulator nodes.
Silk to from what I can test locally.

>> Signed-off-by: Marek Vasut 
> 
> Reviewed-by: Geert Uytterhoeven 
> 
> Gr{oetje,eeting}s,
> 
> Geert
> 


-- 
Best regards,
Marek Vasut

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Geert Uytterhoeven]

Hi Marek,

On Wed, May 23, 2018 at 1:43 PM, Marek Vasut  wrote:
> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> one DA9063L and one DA9210 on Porter, the only difference from
> the other boards is that DA9063L is at I2C address 0x5a rather
> than 0x58 .

Ah, so porter needs the regulator quirk, too.

> Signed-off-by: Marek Vasut 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH] ARM: dts: porter: Add missing PMIC nodes

[Marek Vasut]

Add PMIC nodes to Porter and connect CPU DVFS supply. There is
one DA9063L and one DA9210 on Porter, the only difference from
the other boards is that DA9063L is at I2C address 0x5a rather
than 0x58 .

Signed-off-by: Marek Vasut 
Cc: Geert Uytterhoeven 
Cc: Kuninori Morimoto 
Cc: Simon Horman 
Cc: Wolfram Sang 
Cc: linux-renesas-soc@vger.kernel.org
---
 arch/arm/boot/dts/r8a7791-porter.dts | 33 +
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7791-porter.dts 
b/arch/arm/boot/dts/r8a7791-porter.dts
index a01101b49d99..5f77d73d7462 100644
--- a/arch/arm/boot/dts/r8a7791-porter.dts
+++ b/arch/arm/boot/dts/r8a7791-porter.dts
@@ -375,10 +375,43 @@
clock-frequency = <40>;
 };
 
+ {
+   status = "okay";
+   clock-frequency = <10>;
+
+   pmic@5a {
+   compatible = "dlg,da9063l";
+   reg = <0x5a>;
+   interrupt-parent = <>;
+   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+   interrupt-controller;
+
+   wdt {
+   compatible = "dlg,da9063-watchdog";
+   };
+   };
+
+   vdd_dvfs: regulator@68 {
+   compatible = "dlg,da9210";
+   reg = <0x68>;
+   interrupt-parent = <>;
+   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+
+   regulator-min-microvolt = <100>;
+   regulator-max-microvolt = <100>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+};
+
  {
status = "okay";
 };
 
+ {
+   cpu0-supply = <_dvfs>;
+};
+
 /* composite video input */
  {
status = "okay";
-- 
2.16.2

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Marek Vasut]

On 02/26/2018 11:55 AM, Simon Horman wrote:
> On Sat, Feb 24, 2018 at 11:11:31PM +0100, Marek Vasut wrote:
>> On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
>>> Hi Marek,
>>
>> Hi,
>>
>>> CC Steve Twiss
>>>
>>> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut  wrote:
 Add PMIC nodes to Porter and connect CPU DVFS supply. There is
 one DA9063 and one DA9210 on Porter, the only difference from
 the other boards is that DA9063 is at I2C address 0x5a rather
 than 0x58 .

 Signed-off-by: Marek Vasut 
>>>
>>> Thanks for your patch!
>>>
 --- a/arch/arm/boot/dts/r8a7791-porter.dts
 +++ b/arch/arm/boot/dts/r8a7791-porter.dts
 @@ -354,10 +354,47 @@
 clock-frequency = <40>;
  };

 + {
 +   status = "okay";
 +   clock-frequency = <10>;
 +
 +   pmic@5a {
 +   compatible = "dlg,da9063";
>>>
>>> Does it matter that this is a DA9063L ("Variant 6B")?
>>> Do we need a new compatible value, or can this be detected at runtime?
>>
>> The driver detects it
>>
>> da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)
>>
>> Comparing the datasheets makes it obvious that 9063L is just a cut-down
>> version of 9063, with less LDOs and one less ADC. So I think we should
>> have extra compatible and have the driver restrict which LDOs can be
>> used with this smaller PMIC.
> 
> Thanks, and sorry to ping yo about this while you were in transit.
> 
> It sounds like this patch should be updated.
> Accordingly I'm marking it as "Changes Requested".

Correct

-- 
Best regards,
Marek Vasut

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Simon Horman]

On Sat, Feb 24, 2018 at 11:11:31PM +0100, Marek Vasut wrote:
> On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
> > Hi Marek,
> 
> Hi,
> 
> > CC Steve Twiss
> > 
> > On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut  wrote:
> >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> >> one DA9063 and one DA9210 on Porter, the only difference from
> >> the other boards is that DA9063 is at I2C address 0x5a rather
> >> than 0x58 .
> >>
> >> Signed-off-by: Marek Vasut 
> > 
> > Thanks for your patch!
> > 
> >> --- a/arch/arm/boot/dts/r8a7791-porter.dts
> >> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> >> @@ -354,10 +354,47 @@
> >> clock-frequency = <40>;
> >>  };
> >>
> >> + {
> >> +   status = "okay";
> >> +   clock-frequency = <10>;
> >> +
> >> +   pmic@5a {
> >> +   compatible = "dlg,da9063";
> > 
> > Does it matter that this is a DA9063L ("Variant 6B")?
> > Do we need a new compatible value, or can this be detected at runtime?
> 
> The driver detects it
> 
> da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)
> 
> Comparing the datasheets makes it obvious that 9063L is just a cut-down
> version of 9063, with less LDOs and one less ADC. So I think we should
> have extra compatible and have the driver restrict which LDOs can be
> used with this smaller PMIC.

Thanks, and sorry to ping yo about this while you were in transit.

It sounds like this patch should be updated.
Accordingly I'm marking it as "Changes Requested".

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Marek Vasut]

On 02/18/2018 04:07 PM, Geert Uytterhoeven wrote:
> Hi Marek,

Hi,

> CC Steve Twiss
> 
> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut  wrote:
>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>> one DA9063 and one DA9210 on Porter, the only difference from
>> the other boards is that DA9063 is at I2C address 0x5a rather
>> than 0x58 .
>>
>> Signed-off-by: Marek Vasut 
> 
> Thanks for your patch!
> 
>> --- a/arch/arm/boot/dts/r8a7791-porter.dts
>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
>> @@ -354,10 +354,47 @@
>> clock-frequency = <40>;
>>  };
>>
>> + {
>> +   status = "okay";
>> +   clock-frequency = <10>;
>> +
>> +   pmic@5a {
>> +   compatible = "dlg,da9063";
> 
> Does it matter that this is a DA9063L ("Variant 6B")?
> Do we need a new compatible value, or can this be detected at runtime?

The driver detects it

da9063 6-005a: Device detected (chip-ID: 0x61, var-ID: 0x63)

Comparing the datasheets makes it obvious that 9063L is just a cut-down
version of 9063, with less LDOs and one less ADC. So I think we should
have extra compatible and have the driver restrict which LDOs can be
used with this smaller PMIC.

-- 
Best regards,
Marek Vasut

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Marek Vasut]

On 02/23/2018 05:45 PM, Simon Horman wrote:
> On Sun, Feb 18, 2018 at 04:07:51PM +0100, Geert Uytterhoeven wrote:
>> Hi Marek,
>>
>> CC Steve Twiss
>>
>> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut  wrote:
>>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
>>> one DA9063 and one DA9210 on Porter, the only difference from
>>> the other boards is that DA9063 is at I2C address 0x5a rather
>>> than 0x58 .
>>>
>>> Signed-off-by: Marek Vasut 
>>
>> Thanks for your patch!
>>
>>> --- a/arch/arm/boot/dts/r8a7791-porter.dts
>>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
>>> @@ -354,10 +354,47 @@
>>> clock-frequency = <40>;
>>>  };
>>>
>>> + {
>>> +   status = "okay";
>>> +   clock-frequency = <10>;
>>> +
>>> +   pmic@5a {
>>> +   compatible = "dlg,da9063";
>>
>> Does it matter that this is a DA9063L ("Variant 6B")?
>> Do we need a new compatible value, or can this be detected at runtime?
> 
> Hi Marek,
> 
> could you follow up on this?

Yes, ASAP, once I'm back in the office, currently I'm stuck at the airport.

-- 
Best regards,
Marek Vasut

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Simon Horman]

On Sun, Feb 18, 2018 at 04:07:51PM +0100, Geert Uytterhoeven wrote:
> Hi Marek,
> 
> CC Steve Twiss
> 
> On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut  wrote:
> > Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> > one DA9063 and one DA9210 on Porter, the only difference from
> > the other boards is that DA9063 is at I2C address 0x5a rather
> > than 0x58 .
> >
> > Signed-off-by: Marek Vasut 
> 
> Thanks for your patch!
> 
> > --- a/arch/arm/boot/dts/r8a7791-porter.dts
> > +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> > @@ -354,10 +354,47 @@
> > clock-frequency = <40>;
> >  };
> >
> > + {
> > +   status = "okay";
> > +   clock-frequency = <10>;
> > +
> > +   pmic@5a {
> > +   compatible = "dlg,da9063";
> 
> Does it matter that this is a DA9063L ("Variant 6B")?
> Do we need a new compatible value, or can this be detected at runtime?

Hi Marek,

could you follow up on this?

> > +   reg = <0x5a>;
> > +   interrupt-parent = <>;
> > +   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> > +   interrupt-controller;
> > +
> > +   rtc {
> > +   compatible = "dlg,da9063-rtc";
> > +   };
> > +
> > +   wdt {
> > +   compatible = "dlg,da9063-watchdog";
> > +   };
> > +   };
> > +
> > +   vdd_dvfs: regulator@68 {
> > +   compatible = "dlg,da9210";
> > +   reg = <0x68>;
> > +   interrupt-parent = <>;
> > +   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +   regulator-min-microvolt = <100>;
> > +   regulator-max-microvolt = <100>;
> > +   regulator-boot-on;
> > +   regulator-always-on;
> > +   };
> > +};
> > +
> >   {
> > status = "okay";
> >  };
> >
> > + {
> > +   cpu0-supply = <_dvfs>;
> > +};
> > +
> >  /* composite video input */
> >   {
> > status = "okay";
> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
> 

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

[Geert Uytterhoeven]

Hi Marek,

CC Steve Twiss

On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut  wrote:
> Add PMIC nodes to Porter and connect CPU DVFS supply. There is
> one DA9063 and one DA9210 on Porter, the only difference from
> the other boards is that DA9063 is at I2C address 0x5a rather
> than 0x58 .
>
> Signed-off-by: Marek Vasut 

Thanks for your patch!

> --- a/arch/arm/boot/dts/r8a7791-porter.dts
> +++ b/arch/arm/boot/dts/r8a7791-porter.dts
> @@ -354,10 +354,47 @@
> clock-frequency = <40>;
>  };
>
> + {
> +   status = "okay";
> +   clock-frequency = <10>;
> +
> +   pmic@5a {
> +   compatible = "dlg,da9063";

Does it matter that this is a DA9063L ("Variant 6B")?
Do we need a new compatible value, or can this be detected at runtime?

> +   reg = <0x5a>;
> +   interrupt-parent = <>;
> +   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +   interrupt-controller;
> +
> +   rtc {
> +   compatible = "dlg,da9063-rtc";
> +   };
> +
> +   wdt {
> +   compatible = "dlg,da9063-watchdog";
> +   };
> +   };
> +
> +   vdd_dvfs: regulator@68 {
> +   compatible = "dlg,da9210";
> +   reg = <0x68>;
> +   interrupt-parent = <>;
> +   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +
> +   regulator-min-microvolt = <100>;
> +   regulator-max-microvolt = <100>;
> +   regulator-boot-on;
> +   regulator-always-on;
> +   };
> +};
> +
>   {
> status = "okay";
>  };
>
> + {
> +   cpu0-supply = <_dvfs>;
> +};
> +
>  /* composite video input */
>   {
> status = "okay";

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH] ARM: dts: porter: Add missing PMIC nodes

[Marek Vasut]

Add PMIC nodes to Porter and connect CPU DVFS supply. There is
one DA9063 and one DA9210 on Porter, the only difference from
the other boards is that DA9063 is at I2C address 0x5a rather
than 0x58 .

Signed-off-by: Marek Vasut 
Cc: Geert Uytterhoeven 
Cc: Kuninori Morimoto 
Cc: Simon Horman 
Cc: Wolfram Sang 
---
 arch/arm/boot/dts/r8a7791-porter.dts | 37 
 1 file changed, 37 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7791-porter.dts 
b/arch/arm/boot/dts/r8a7791-porter.dts
index a098d66292fb..116f30f54e04 100644
--- a/arch/arm/boot/dts/r8a7791-porter.dts
+++ b/arch/arm/boot/dts/r8a7791-porter.dts
@@ -354,10 +354,47 @@
clock-frequency = <40>;
 };
 
+ {
+   status = "okay";
+   clock-frequency = <10>;
+
+   pmic@5a {
+   compatible = "dlg,da9063";
+   reg = <0x5a>;
+   interrupt-parent = <>;
+   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+   interrupt-controller;
+
+   rtc {
+   compatible = "dlg,da9063-rtc";
+   };
+
+   wdt {
+   compatible = "dlg,da9063-watchdog";
+   };
+   };
+
+   vdd_dvfs: regulator@68 {
+   compatible = "dlg,da9210";
+   reg = <0x68>;
+   interrupt-parent = <>;
+   interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+
+   regulator-min-microvolt = <100>;
+   regulator-max-microvolt = <100>;
+   regulator-boot-on;
+   regulator-always-on;
+   };
+};
+
  {
status = "okay";
 };
 
+ {
+   cpu0-supply = <_dvfs>;
+};
+
 /* composite video input */
  {
status = "okay";
-- 
2.15.1