Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property

[Laurent Pinchart]

Hi Simon,

On Thursday 20 Oct 2016 10:42:30 Simon Horman wrote:
> Hi Laurent,
> 
> On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote:
> > The system uses one address cell and one size cell, not two. Fix the DU
> > DT node.
> 
> Do you want to handle this as a fix for v4.9? If so shall we add the
> following?
> 
> Fixes: 1f08bbe8ac73 ("ARM: shmobile: r8a7779: Add DU node to device tree")
> 
> Else I'll just queue it up for v4.10.

v4.10 is fine, 1f08bbe8ac73 was merged in v3.19, so there's no urgency :-)

It looks like nobody has tried to get display working on Marzen for a very 
long time.

> > Signed-off-by: Laurent Pinchart
> > 
> > ---
> > 
> >  arch/arm/boot/dts/r8a7779.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7779.dtsi
> > b/arch/arm/boot/dts/r8a7779.dtsi index b9bbcce69dfb..9d5b8fa3da8b 100644
> > --- a/arch/arm/boot/dts/r8a7779.dtsi
> > +++ b/arch/arm/boot/dts/r8a7779.dtsi
> > @@ -420,7 +420,7 @@
> > 
> > du: display@fff8 {
> > compatible = "renesas,du-r8a7779";
> > -   reg = <0 0xfff8 0 0x4>;
> > +   reg = <0xfff8 0x4>;
> > interrupts = ;
> > clocks = <_clks R8A7779_CLK_DU>;
> > power-domains = < R8A7779_PD_ALWAYS_ON>;

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property

[Simon Horman]

Hi Laurent,

On Wed, Oct 19, 2016 at 01:23:02AM +0300, Laurent Pinchart wrote:
> The system uses one address cell and one size cell, not two. Fix the DU
> DT node.

Do you want to handle this as a fix for v4.9? If so shall we add the
following?

Fixes: 1f08bbe8ac73 ("ARM: shmobile: r8a7779: Add DU node to device tree")

Else I'll just queue it up for v4.10.

> 
> Signed-off-by: Laurent Pinchart 
> ---
>  arch/arm/boot/dts/r8a7779.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
> index b9bbcce69dfb..9d5b8fa3da8b 100644
> --- a/arch/arm/boot/dts/r8a7779.dtsi
> +++ b/arch/arm/boot/dts/r8a7779.dtsi
> @@ -420,7 +420,7 @@
>  
>   du: display@fff8 {
>   compatible = "renesas,du-r8a7779";
> - reg = <0 0xfff8 0 0x4>;
> + reg = <0xfff8 0x4>;
>   interrupts = ;
>   clocks = <_clks R8A7779_CLK_DU>;
>   power-domains = < R8A7779_PD_ALWAYS_ON>;
> -- 
> Regards,
> 
> Laurent Pinchart
> 

Re: [PATCH] ARM: dts: r8a7779: Fix DU reg property

[Geert Uytterhoeven]

On Wed, Oct 19, 2016 at 12:23 AM, Laurent Pinchart
 wrote:
> The system uses one address cell and one size cell, not two. Fix the DU
> DT node.
>
> Signed-off-by: Laurent Pinchart 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH] ARM: dts: r8a7779: Fix DU reg property

[Laurent Pinchart]

The system uses one address cell and one size cell, not two. Fix the DU
DT node.

Signed-off-by: Laurent Pinchart 
---
 arch/arm/boot/dts/r8a7779.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
index b9bbcce69dfb..9d5b8fa3da8b 100644
--- a/arch/arm/boot/dts/r8a7779.dtsi
+++ b/arch/arm/boot/dts/r8a7779.dtsi
@@ -420,7 +420,7 @@
 
du: display@fff8 {
compatible = "renesas,du-r8a7779";
-   reg = <0 0xfff8 0 0x4>;
+   reg = <0xfff8 0x4>;
interrupts = ;
clocks = <_clks R8A7779_CLK_DU>;
power-domains = < R8A7779_PD_ALWAYS_ON>;
-- 
Regards,

Laurent Pinchart