Re: [PATCH] ARM: dts: r8a7794: remove Z clock

[Geert Uytterhoeven]

On Sat, Oct 29, 2016 at 11:31 PM, Sergei Shtylyov
 wrote:
> R8A7794 doesn't have Cortex-A15 CPUs, thus there's no Z clock...
>
> Fixes: 0dce5454d5c2 ("ARM: shmobile: Initial r8a7794 SoC device tree")
> Signed-off-by: Sergei Shtylyov 

Reviewed-by: Geert Uytterhoeven 

> ---
> The patch is against the 'master' branch of Simon Horman's 'renesas.git' repo.
>
>  arch/arm/boot/dts/r8a7794.dtsi|3 +--
>  include/dt-bindings/clock/r8a7794-clock.h |3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -1025,8 +1025,7 @@
> clocks = <_clk _extal_clk>;
> #clock-cells = <1>;
> clock-output-names = "main", "pll0", "pll1", "pll3",
> -"lb", "qspi", "sdh", "sd0", "z",
> -"rcan";
> +"lb", "qspi", "sdh", "sd0", 
> "rcan";
> #power-domain-cells = <0>;
> };
> /* Variable factor clocks */
> Index: renesas/include/dt-bindings/clock/r8a7794-clock.h
> ===
> --- renesas.orig/include/dt-bindings/clock/r8a7794-clock.h
> +++ renesas/include/dt-bindings/clock/r8a7794-clock.h
> @@ -20,8 +20,7 @@
>  #define R8A7794_CLK_QSPI   5
>  #define R8A7794_CLK_SDH6
>  #define R8A7794_CLK_SD07
> -#define R8A7794_CLK_Z  8
> -#define R8A7794_CLK_RCAN   9
> +#define R8A7794_CLK_RCAN   8

JFTR, this changes the bindings file, but the values are solely used
for indexing
the clock-output-names array, so this is fine.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] ARM: dts: r8a7794: remove Z clock

[Simon Horman]

On Sun, Oct 30, 2016 at 12:31:27AM +0300, Sergei Shtylyov wrote:
> R8A7794 doesn't have Cortex-A15 CPUs, thus there's no Z clock...
> 
> Fixes: 0dce5454d5c2 ("ARM: shmobile: Initial r8a7794 SoC device tree")
> Signed-off-by: Sergei Shtylyov 
> 
> ---
> The patch is against the 'master' branch of Simon Horman's 'renesas.git' repo.

Thanks, I have queued this up.