Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-27 Thread Lee Jones
On Fri, 24 Mar 2017, Daniel Thompson wrote: > On 24/03/17 16:42, Daniel Thompson wrote: > > On 22/03/17 17:21, Geert Uytterhoeven wrote: > > > Commit 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial > > > power state to a separate function") not just moved some code, but made > >

Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-24 Thread Daniel Thompson
On 24/03/17 16:42, Daniel Thompson wrote: On 22/03/17 17:21, Geert Uytterhoeven wrote: Commit 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial power state to a separate function") not just moved some code, but made slight changes in semantics. If a gpiochip doesn't implement

Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-24 Thread Daniel Thompson
On 22/03/17 17:21, Geert Uytterhoeven wrote: Commit 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial power state to a separate function") not just moved some code, but made slight changes in semantics. If a gpiochip doesn't implement the optional .get_direction() callback,

Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-24 Thread Philipp Zabel
On Wed, 2017-03-22 at 18:21 +0100, Geert Uytterhoeven wrote: > Commit 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial > power state to a separate function") not just moved some code, but made > slight changes in semantics. > > If a gpiochip doesn't implement the optional

Re: [PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-23 Thread Peter Ujfalusi
On 03/22/2017 07:21 PM, Geert Uytterhoeven wrote: Commit 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial power state to a separate function") not just moved some code, but made slight changes in semantics. If a gpiochip doesn't implement the optional .get_direction() callback,

[PATCH] backlight: pwm_bl: Fix GPIO out for unimplemented .get_direction()

2017-03-22 Thread Geert Uytterhoeven
Commit 7613c922315e308a ("backlight: pwm_bl: Move the checks for initial power state to a separate function") not just moved some code, but made slight changes in semantics. If a gpiochip doesn't implement the optional .get_direction() callback, gpiod_get_direction always returns -EINVAL, which