Re: [Qemu-devel] [PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB
On 13 February 2018 at 16:41, Geert Uytterhoevenwrote: > It is not uncommon for a contemporary FDT to be larger than 64 KiB, > leading to failures loading the device tree from sysfs: > > qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE > > For reference, the largest arm64 DTB created from the Linux sources is > 70 KiB large (93 KiB when built with symbols/fixup support). I think we should probably give ourselves a bit more headroom, then -- at least 256K. The ppc boards actually define their own version of this constant: #define FDT_MAX_SIZE0x0010 so I think we might as well just go with that in device_tree.c for consistency. thanks -- PMM
[PATCH] device_tree: Increase FDT_MAX_SIZE to 128 KiB
It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE For reference, the largest arm64 DTB created from the Linux sources is 70 KiB large (93 KiB when built with symbols/fixup support). Signed-off-by: Geert Uytterhoeven--- device_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/device_tree.c b/device_tree.c index a24ddff02bdd857c..1ba9b8e0a49e6bbc 100644 --- a/device_tree.c +++ b/device_tree.c @@ -29,7 +29,7 @@ #include -#define FDT_MAX_SIZE 0x1 +#define FDT_MAX_SIZE 0x2 void *create_device_tree(int *sizep) { -- 2.7.4