Re: [PATCH] drm: rcar-du: Use NULL for table initialisation

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Tuesday, 24 April 2018 18:40:03 EEST Kieran Bingham wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
> 
> Fixes the following warning:
>  linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
> warning: Using plain integer as NULL pointer
>   CC  drivers/gpu/drm/rcar-du/rcar_du_kms.o
> 
> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same
> VSP") Signed-off-by: Kieran Bingham
> 

Reviewed-by: Laurent Pinchart 

and applied to my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ef72dff00763..cf5b422fc753
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device
> *rcdu) struct {
>   struct device_node *np;
>   unsigned int crtcs_mask;
> - } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
> + } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
>   unsigned int vsps_count = 0;
>   unsigned int cells;
>   unsigned int i;

-- 
Regards,

Laurent Pinchart

Re: [PATCH] drm: rcar-du: Use NULL for table initialisation

[Simon Horman]

On Tue, Apr 24, 2018 at 04:40:03PM +0100, Kieran Bingham wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
> 
> Fixes the following warning:
>  linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
> warning: Using plain integer as NULL pointer
>   CC  drivers/gpu/drm/rcar-du/rcar_du_kms.o
> 
> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same 
> VSP")
> Signed-off-by: Kieran Bingham 

Reviewed-by: Simon Horman 

Re: [PATCH] drm: rcar-du: Use NULL for table initialisation

[Vaishali Thakkar]

On Tue, Apr 24, 2018 at 9:10 PM, Kieran Bingham
 wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
>
> Fixes the following warning:
>  linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
> warning: Using plain integer as NULL pointer
>   CC  drivers/gpu/drm/rcar-du/rcar_du_kms.o

Hi Kieran,

Change looks ok to me.

> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same 
> VSP")
> Signed-off-by: Kieran Bingham 

Reviewed-by: Vaishali Thakkar 

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c 
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index ef72dff00763..cf5b422fc753 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
> struct {
> struct device_node *np;
> unsigned int crtcs_mask;
> -   } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
> +   } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
> unsigned int vsps_count = 0;
> unsigned int cells;
> unsigned int i;
> --
> 2.17.0
>

[PATCH] drm: rcar-du: Use NULL for table initialisation

[Kieran Bingham]

Replace the initialisation of the vsps table with a NULL specifier.

Fixes the following warning:
 linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
warning: Using plain integer as NULL pointer
  CC  drivers/gpu/drm/rcar-du/rcar_du_kms.o

Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP")
Signed-off-by: Kieran Bingham 
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c 
b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index ef72dff00763..cf5b422fc753 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
struct {
struct device_node *np;
unsigned int crtcs_mask;
-   } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
+   } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
unsigned int vsps_count = 0;
unsigned int cells;
unsigned int i;
-- 
2.17.0