Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-26 Thread Boris Brezillon
On Thu, 26 Apr 2018 19:56:58 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Thu, Apr 26, 2018 at 7:53 PM, Boris Brezillon > wrote: > > On Tue, 10 Apr 2018 15:26:20 +0200 > > Geert Uytterhoeven wrote: > >> On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut > >> wrote: > >> > On 04/09/2018 0

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-26 Thread Geert Uytterhoeven
Hi Boris, On Thu, Apr 26, 2018 at 7:53 PM, Boris Brezillon wrote: > On Tue, 10 Apr 2018 15:26:20 +0200 > Geert Uytterhoeven wrote: >> On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: >> > On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: >> >> Currently add_mtd_device() failures are plainly

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-26 Thread Boris Brezillon
Hi Geert, Sorry for the late reply. On Tue, 10 Apr 2018 15:26:20 +0200 Geert Uytterhoeven wrote: > Hi Marek, > > On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: > > On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: > >> Currently add_mtd_device() failures are plainly ignored, which may

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-10 Thread Steve deRosier
On Tue, Apr 10, 2018 at 7:47 AM, Geert Uytterhoeven wrote: > Hi Marek, > > On Tue, Apr 10, 2018 at 4:37 PM, Marek Vasut wrote: >> On 04/10/2018 03:26 PM, Geert Uytterhoeven wrote: >>> On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: >

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-10 Thread Geert Uytterhoeven
Hi Marek, On Tue, Apr 10, 2018 at 4:37 PM, Marek Vasut wrote: > On 04/10/2018 03:26 PM, Geert Uytterhoeven wrote: >> On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: >>> On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: Currently add_mtd_device() failures are plainly ignored, which may l

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-10 Thread Marek Vasut
On 04/10/2018 03:26 PM, Geert Uytterhoeven wrote: > Hi Marek, > > On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: >> On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: >>> Currently add_mtd_device() failures are plainly ignored, which may lead >>> to kernel crashes later. > >>> Fix this by ig

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-10 Thread Geert Uytterhoeven
Hi Marek, On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: > On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: >> Currently add_mtd_device() failures are plainly ignored, which may lead >> to kernel crashes later. >> Fix this by ignoring and freeing partitions that failed to add in >> add_mtd

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-09 Thread Marek Vasut
On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: > Currently add_mtd_device() failures are plainly ignored, which may lead > to kernel crashes later. > > E.g. after flipping SW17 on r8a7791/koelsch, to switch from the large to > the small QSPI FLASH, without updating the partition description in

[PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-09 Thread Geert Uytterhoeven
Currently add_mtd_device() failures are plainly ignored, which may lead to kernel crashes later. E.g. after flipping SW17 on r8a7791/koelsch, to switch from the large to the small QSPI FLASH, without updating the partition description in DT, the following happens: m25p80 spi0.0: found s25sl03