Re: [PATCH] phy: Renesas R-Car gen3 PCIe PHY driver

2018-04-10 Thread Rob Herring
On Wed, Apr 04, 2018 at 10:31:26PM +0300, Sergei Shtylyov wrote: > This PHY is still mostly undocumented -- the only documented registers > exist on R-Car V3H (R8A77980) SoC where this PHY stays in a powered-down > state after a reset and thus we must power it on for PCIe to work... > > Signed-o

Re: [PATCH] phy: Renesas R-Car gen3 PCIe PHY driver

2018-04-10 Thread Simon Horman
On Mon, Apr 09, 2018 at 06:57:11PM +0300, Sergei Shtylyov wrote: > On 04/09/2018 12:46 PM, Geert Uytterhoeven wrote: > > >> This PHY is still mostly undocumented -- the only documented registers > >> exist on R-Car V3H (R8A77980) SoC where this PHY stays in a powered-down > >> state after a reset

Re: [PATCH] phy: Renesas R-Car gen3 PCIe PHY driver

2018-04-09 Thread Geert Uytterhoeven
Hi Sergei, On Mon, Apr 9, 2018 at 5:57 PM, Sergei Shtylyov wrote: > On 04/09/2018 12:46 PM, Geert Uytterhoeven wrote: >>> +static int rcar_gen3_phy_pcie_probe(struct platform_device *pdev) >>> +{ >>> + struct device *dev = &pdev->dev; >>> + struct phy_provider *provider; >>> + s

Re: [PATCH] phy: Renesas R-Car gen3 PCIe PHY driver

2018-04-09 Thread Sergei Shtylyov
On 04/09/2018 12:46 PM, Geert Uytterhoeven wrote: >> This PHY is still mostly undocumented -- the only documented registers >> exist on R-Car V3H (R8A77980) SoC where this PHY stays in a powered-down >> state after a reset and thus we must power it on for PCIe to work... > > Bogus spaces slippi

Re: [PATCH] phy: Renesas R-Car gen3 PCIe PHY driver

2018-04-09 Thread Geert Uytterhoeven
Hi Sergei, Thanks for your patch! On Wed, Apr 4, 2018 at 9:31 PM, Sergei Shtylyov wrote: > This PHY is still mostly undocumented -- the only documented registers > exist on R-Car V3H (R8A77980) SoC where this PHY stays in a powered-down > state after a reset and thus we must power it on for PC

[PATCH] phy: Renesas R-Car gen3 PCIe PHY driver

2018-04-04 Thread Sergei Shtylyov
This PHY is still mostly undocumented -- the only documented registers exist on R-Car V3H (R8A77980) SoC where this PHY stays in a powered-down state after a reset and thus we must power it on for PCIe to work... Signed-off-by: Sergei Shtylyov --- The patch is against the 'next' branch of Kish