Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings

[Simon Horman]

On Wed, Aug 09, 2017 at 08:11:24PM +0900, Magnus Damm wrote:
> Hi Simon,
> 
> On Wed, Aug 9, 2017 at 5:22 PM, Simon Horman  wrote:
> > On Wed, Aug 09, 2017 at 09:55:26AM +0200, Simon Horman wrote:
> >> On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
> >> > Hi Simon,
> >> >
> >> > On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman 
> >> >  wrote:
> >> > > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in 
> >> > > place
> >> > > of now deprecated non-generation specific R-Car GPIO fallback compat 
> >> > > string
> >> > > in the DT of Renesas ARM and arm64 based SoCs.
> >> > >
> >> > > This should have no run-time effect as the driver matches against the
> >> > > per-SoC compat string before considering the fallback compat string.
> >> >
> >> > Thanks for your efforts.I have no issue with your series (apart from
> >> > the GPIO and SATA mistake), but at the same time I believe the GPIO
> >> > hardware itself is backwards compatible between various generations.
> >> >
> >> > In the nitpick department I would like to point out that the level of
> >> > hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
> >> > similar to say good old uarts like 8250 and 16450 hardware. Basically
> >> > a couple of registers were added to the hardware in a
> >> > backwards-compatible way if I recall correctly.
> >> >
> >> > So if we are going to use "compatible" to point out if hardware is
> >> > compatible or not then I would do this instead:
> >>
> >> Thanks for your feedback.
> >>
> >> When the generation specific compat strings were recently
> >> added the renesas,gpio-rcar compat string was marked as deprecated
> >> as I was under the understanding that it was only compatibile with gen 1 
> >> SoCs.
> >>
> >> It now seems that was not the best thing to do and renesas,gpio-rcar should
> >> be re-instated as being a generic fallback for all R-Car versions supported
> >> in upstream.
> >>
> >> Do you concur?
> >
> > I posted a patch to un-deprecate the renesas,gpio-rcar compat string
> > in the bindings documentation.
> >
> > [PATCH] gpio: rcar: reinstate generic compat string
> 
> Thanks, this looks good to me. I would like to hear what Geert thinks as well!

Thanks, good plan.

Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings

[Simon Horman]

On Wed, Aug 09, 2017 at 09:55:26AM +0200, Simon Horman wrote:
> On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
> > Hi Simon,
> > 
> > On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman  
> > wrote:
> > > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
> > > of now deprecated non-generation specific R-Car GPIO fallback compat 
> > > string
> > > in the DT of Renesas ARM and arm64 based SoCs.
> > >
> > > This should have no run-time effect as the driver matches against the
> > > per-SoC compat string before considering the fallback compat string.
> > 
> > Thanks for your efforts.I have no issue with your series (apart from
> > the GPIO and SATA mistake), but at the same time I believe the GPIO
> > hardware itself is backwards compatible between various generations.
> > 
> > In the nitpick department I would like to point out that the level of
> > hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
> > similar to say good old uarts like 8250 and 16450 hardware. Basically
> > a couple of registers were added to the hardware in a
> > backwards-compatible way if I recall correctly.
> > 
> > So if we are going to use "compatible" to point out if hardware is
> > compatible or not then I would do this instead:
> 
> Thanks for your feedback.
> 
> When the generation specific compat strings were recently
> added the renesas,gpio-rcar compat string was marked as deprecated
> as I was under the understanding that it was only compatibile with gen 1 SoCs.
> 
> It now seems that was not the best thing to do and renesas,gpio-rcar should
> be re-instated as being a generic fallback for all R-Car versions supported
> in upstream.
> 
> Do you concur?

I posted a patch to un-deprecate the renesas,gpio-rcar compat string
in the bindings documentation.

[PATCH] gpio: rcar: reinstate generic compat string

Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings

[Simon Horman]

On Tue, Aug 08, 2017 at 07:29:28PM +0900, Magnus Damm wrote:
> Hi Simon,
> 
> On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman  
> wrote:
> > Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
> > of now deprecated non-generation specific R-Car GPIO fallback compat string
> > in the DT of Renesas ARM and arm64 based SoCs.
> >
> > This should have no run-time effect as the driver matches against the
> > per-SoC compat string before considering the fallback compat string.
> 
> Thanks for your efforts.I have no issue with your series (apart from
> the GPIO and SATA mistake), but at the same time I believe the GPIO
> hardware itself is backwards compatible between various generations.
> 
> In the nitpick department I would like to point out that the level of
> hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
> similar to say good old uarts like 8250 and 16450 hardware. Basically
> a couple of registers were added to the hardware in a
> backwards-compatible way if I recall correctly.
> 
> So if we are going to use "compatible" to point out if hardware is
> compatible or not then I would do this instead:

Thanks for your feedback.

When the generation specific compat strings were recently
added the renesas,gpio-rcar compat string was marked as deprecated
as I was under the understanding that it was only compatibile with gen 1 SoCs.

It now seems that was not the best thing to do and renesas,gpio-rcar should
be re-instated as being a generic fallback for all R-Car versions supported
in upstream.

Do you concur?

> 
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -214,7 +214,7 @@
> 
> gpio0: gpio@e605 {
> compatible = "renesas,gpio-r8a7796",
> +"renesas,rcar-gen3-gpio";
>  "renesas,gpio-rcar";
> reg = <0 0xe605 0 0x50>;
> interrupts = ;
> #gpio-cells = <2>;
> 
> At the same time I'm not sure if I care _that_ much. =)
> 
> Thanks,
> 
> / magnus
> 

Re: [PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings

[Magnus Damm]

Hi Simon,

On Tue, Aug 8, 2017 at 5:39 PM, Simon Horman  wrote:
> Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
> of now deprecated non-generation specific R-Car GPIO fallback compat string
> in the DT of Renesas ARM and arm64 based SoCs.
>
> This should have no run-time effect as the driver matches against the
> per-SoC compat string before considering the fallback compat string.

Thanks for your efforts.I have no issue with your series (apart from
the GPIO and SATA mistake), but at the same time I believe the GPIO
hardware itself is backwards compatible between various generations.

In the nitpick department I would like to point out that the level of
hardware difference between say R-Car Gen1 GPIO and R-Car Gen2 GPIO is
similar to say good old uarts like 8250 and 16450 hardware. Basically
a couple of registers were added to the hardware in a
backwards-compatible way if I recall correctly.

So if we are going to use "compatible" to point out if hardware is
compatible or not then I would do this instead:

--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -214,7 +214,7 @@

gpio0: gpio@e605 {
compatible = "renesas,gpio-r8a7796",
+"renesas,rcar-gen3-gpio";
 "renesas,gpio-rcar";
reg = <0 0xe605 0 0x50>;
interrupts = ;
#gpio-cells = <2>;

At the same time I'm not sure if I care _that_ much. =)

Thanks,

/ magnus

[PATCH 00/10] ARM, arm64: dts: renesas: Use R-Car GPIO Gen[123] fallback compat strings

[Simon Horman]

Use newly added R-Car GPIO Gen 1, 2 and 3 fallback compat strings in place
of now deprecated non-generation specific R-Car GPIO fallback compat string
in the DT of Renesas ARM and arm64 based SoCs.

This should have no run-time effect as the driver matches against the
per-SoC compat string before considering the fallback compat string.

Based on renesas-devel-20170807-v4.13-rc4

Simon Horman (10):
  ARM: dts: r8a7778: Use R-Car GPIO Gen1 fallback compat string
  ARM: dts: r8a7779: Use R-Car GPIO Gen1 fallback compat string
  ARM: dts: r8a7743: Use R-Car GPIO Gen2 fallback compat string
  ARM: dts: r8a7790: Use R-Car GPIO Gen2 fallback compat string
  ARM: dts: r8a7791: Use R-Car GPIO Gen2 fallback compat string
  ARM: dts: r8a7792: Use R-Car GPIO Gen2 fallback compat string
  ARM: dts: r8a7793: Use R-Car GPIO Gen2 fallback compat string
  ARM: dts: r8a7794: Use R-Car GPIO Gen2 fallback compat string
  arm64: dts: r8a7795: Use R-Car GPIO Gen3 fallback compat string
  arm64: dts: r8a7796: Use R-Car GPIO Gen3 fallback compat string

 arch/arm/boot/dts/r8a7743.dtsi   | 16 
 arch/arm/boot/dts/r8a7778.dtsi   | 10 +-
 arch/arm/boot/dts/r8a7779.dtsi   | 14 +++---
 arch/arm/boot/dts/r8a7790.dtsi   | 12 ++--
 arch/arm/boot/dts/r8a7791.dtsi   | 16 
 arch/arm/boot/dts/r8a7792.dtsi   | 24 
 arch/arm/boot/dts/r8a7793.dtsi   | 16 
 arch/arm/boot/dts/r8a7794.dtsi   | 14 +++---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 16 
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 16 
 10 files changed, 77 insertions(+), 77 deletions(-)

-- 
2.1.4