Re: [PATCH 02/10] ARM: dts: r8a7779: Use R-Car GPIO Gen1 fallback compat string

[Geert Uytterhoeven]

On Tue, Aug 8, 2017 at 10:39 AM, Simon Horman
 wrote:
> Use newly added R-Car GPIO Gen1 fallback compat string
> in place of now deprecated non-generation specific
> R-Car GPIO fallback compat string in DT of r8a7779 SoC.
>
> This should have no run-time effect as the driver matches against
> the per-SoC compat string before considering the fallback compat string.

That is not correct: the driver does not match against "renesas,gpio-r8a7779".
Hence this breaks using a new DTS and an old kernel (which we may decide not
to care about for R-Car Gen1, though).
But at least the DTS change should be postponed until commit d10bbd156926e65d
("gpio: rcar: add gen[123] fallback compatibility strings") has hit mainline.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 02/10] ARM: dts: r8a7779: Use R-Car GPIO Gen1 fallback compat string

[Simon Horman]

Use newly added R-Car GPIO Gen1 fallback compat string
in place of now deprecated non-generation specific
R-Car GPIO fallback compat string in DT of r8a7779 SoC.

This should have no run-time effect as the driver matches against
the per-SoC compat string before considering the fallback compat string.

Signed-off-by: Simon Horman 
---
 arch/arm/boot/dts/r8a7779.dtsi | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779.dtsi
index 8ee0b2ca5d39..ccef2cfab6e0 100644
--- a/arch/arm/boot/dts/r8a7779.dtsi
+++ b/arch/arm/boot/dts/r8a7779.dtsi
@@ -76,7 +76,7 @@
};
 
gpio0: gpio@ffc4 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc4 0x2c>;
interrupts = ;
#gpio-cells = <2>;
@@ -87,7 +87,7 @@
};
 
gpio1: gpio@ffc41000 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc41000 0x2c>;
interrupts = ;
#gpio-cells = <2>;
@@ -98,7 +98,7 @@
};
 
gpio2: gpio@ffc42000 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc42000 0x2c>;
interrupts = ;
#gpio-cells = <2>;
@@ -109,7 +109,7 @@
};
 
gpio3: gpio@ffc43000 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc43000 0x2c>;
interrupts = ;
#gpio-cells = <2>;
@@ -120,7 +120,7 @@
};
 
gpio4: gpio@ffc44000 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc44000 0x2c>;
interrupts = ;
#gpio-cells = <2>;
@@ -131,7 +131,7 @@
};
 
gpio5: gpio@ffc45000 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc45000 0x2c>;
interrupts = ;
#gpio-cells = <2>;
@@ -142,7 +142,7 @@
};
 
gpio6: gpio@ffc46000 {
-   compatible = "renesas,gpio-r8a7779", "renesas,gpio-rcar";
+   compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
reg = <0xffc46000 0x2c>;
interrupts = ;
#gpio-cells = <2>;
-- 
2.1.4