Re: [PATCH 3/3] arm64: dts: r8a7795: Use R-Car GPIO Gen3 fallback compat string

2017-08-09 Thread Simon Horman 
On Tue, Aug 08, 2017 at 07:24:58PM +0900, Magnus Damm wrote:
> Hi Simon,
> 
> On Tue, Aug 8, 2017 at 5:54 PM, Simon Horman  
> wrote:
> > Use newly added R-Car GPIO Gen3 fallback compat string
> > in the DT of the r8a7795 SoC.
> >
> > This should have no run-time effect as the driver matches against
> > the per-SoC compat string before the fallback compat string is considered.
> >
> > Signed-off-by: Simon Horman 
> > ---
> >  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > index a87ae76880ab..c9f2b87e7ee3 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -1451,7 +1451,8 @@
> > };
> >
> > sata: sata@ee30 {
> > -   compatible = "renesas,sata-r8a7795";
> > +   compatible = "renesas,sata-r8a7795",
> > +"renesas,rcar-gen3-sata";
> > reg = <0 0xee30 0 0x20>;
> > interrupts = ;
> > clocks = < CPG_MOD 815>;
> > --
> > 2.1.4
> 
> This patch looks odd. The subject and patch description says GPIO but
> the hunk above modifies SATA...?

Yes, it looks like I have made a cut-and-paste error there.
I'll repost.

Re: [PATCH 3/3] arm64: dts: r8a7795: Use R-Car GPIO Gen3 fallback compat string

2017-08-08 Thread Magnus Damm 
Hi Simon,

On Tue, Aug 8, 2017 at 5:54 PM, Simon Horman  wrote:
> Use newly added R-Car GPIO Gen3 fallback compat string
> in the DT of the r8a7795 SoC.
>
> This should have no run-time effect as the driver matches against
> the per-SoC compat string before the fallback compat string is considered.
>
> Signed-off-by: Simon Horman 
> ---
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index a87ae76880ab..c9f2b87e7ee3 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -1451,7 +1451,8 @@
> };
>
> sata: sata@ee30 {
> -   compatible = "renesas,sata-r8a7795";
> +   compatible = "renesas,sata-r8a7795",
> +"renesas,rcar-gen3-sata";
> reg = <0 0xee30 0 0x20>;
> interrupts = ;
> clocks = < CPG_MOD 815>;
> --
> 2.1.4

This patch looks odd. The subject and patch description says GPIO but
the hunk above modifies SATA...?

Cheers,

/ magnus

[PATCH 3/3] arm64: dts: r8a7795: Use R-Car GPIO Gen3 fallback compat string

2017-08-08 Thread Simon Horman 
Use newly added R-Car GPIO Gen3 fallback compat string
in the DT of the r8a7795 SoC.

This should have no run-time effect as the driver matches against
the per-SoC compat string before the fallback compat string is considered.

Signed-off-by: Simon Horman 
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi 
b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index a87ae76880ab..c9f2b87e7ee3 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1451,7 +1451,8 @@
};
 
sata: sata@ee30 {
-   compatible = "renesas,sata-r8a7795";
+   compatible = "renesas,sata-r8a7795",
+"renesas,rcar-gen3-sata";
reg = <0 0xee30 0 0x20>;
interrupts = ;
clocks = < CPG_MOD 815>;
-- 
2.1.4