RE: [PATCH 3/4] pinctrl: sh-pfc: r8a7794: Add tpu groups and function

[Fabrizio Castro]

Hello Geert,

thank you for your feedback.

> Subject: Re: [PATCH 3/4] pinctrl: sh-pfc: r8a7794: Add tpu groups and function
>
> On Mon, Dec 18, 2017 at 12:09 PM, Geert Uytterhoeven
> <ge...@linux-m68k.org> wrote:
> > On Thu, Dec 14, 2017 at 11:57 AM, Fabrizio Castro
> > <fabrizio.cas...@bp.renesas.com> wrote:
> >> This patch adds tpu groups and function to r8a7745/r8a7794.
> >>
> >> Signed-off-by: Fabrizio Castro <fabrizio.cas...@bp.renesas.com>
> >> Reviewed-by: Biju Das <biju@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
> > i.e. will queue in sh-pfc-for-v4.16.
>
> Oops, missed one thing: please use alphabetical sort order when adding
> new entries.

I'll send a v2 to fix the order.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds


[https://www2.renesas.eu/media/email/unicef_2017.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have 
decided to support Unicef with a donation. For further details click 
here<https://www.unicef.org/> to find out about the valuable work they do, 
helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a 
prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH 3/4] pinctrl: sh-pfc: r8a7794: Add tpu groups and function

[Geert Uytterhoeven]

On Mon, Dec 18, 2017 at 12:09 PM, Geert Uytterhoeven
 wrote:
> On Thu, Dec 14, 2017 at 11:57 AM, Fabrizio Castro
>  wrote:
>> This patch adds tpu groups and function to r8a7745/r8a7794.
>>
>> Signed-off-by: Fabrizio Castro 
>> Reviewed-by: Biju Das 
>
> Reviewed-by: Geert Uytterhoeven 
> i.e. will queue in sh-pfc-for-v4.16.

Oops, missed one thing: please use alphabetical sort order when adding
new entries.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 3/4] pinctrl: sh-pfc: r8a7794: Add tpu groups and function

[Geert Uytterhoeven]

On Thu, Dec 14, 2017 at 11:57 AM, Fabrizio Castro
 wrote:
> This patch adds tpu groups and function to r8a7745/r8a7794.
>
> Signed-off-by: Fabrizio Castro 
> Reviewed-by: Biju Das 

Reviewed-by: Geert Uytterhoeven 
i.e. will queue in sh-pfc-for-v4.16.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 3/4] pinctrl: sh-pfc: r8a7794: Add tpu groups and function

[Fabrizio Castro]

This patch adds tpu groups and function to r8a7745/r8a7794.

Signed-off-by: Fabrizio Castro 
Reviewed-by: Biju Das 
---
 drivers/pinctrl/sh-pfc/pfc-r8a7794.c | 101 +++
 1 file changed, 101 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7794.c 
b/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
index dccc20a..455cb02 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
@@ -3254,6 +3254,79 @@ static const unsigned int sdhi2_wp_pins[] = {
 static const unsigned int sdhi2_wp_mux[] = {
SD2_WP_MARK,
 };
+/* - TPU  
*/
+static const unsigned int tpu_to0_pins[] = {
+   RCAR_GP_PIN(3, 31),
+};
+static const unsigned int tpu_to0_mux[] = {
+   TPUTO0_MARK,
+};
+static const unsigned int tpu_to0_b_pins[] = {
+   RCAR_GP_PIN(3, 30),
+};
+static const unsigned int tpu_to0_b_mux[] = {
+   TPUTO0_B_MARK,
+};
+static const unsigned int tpu_to0_c_pins[] = {
+   RCAR_GP_PIN(1, 18),
+};
+static const unsigned int tpu_to0_c_mux[] = {
+   TPUTO0_C_MARK,
+};
+static const unsigned int tpu_to1_pins[] = {
+   RCAR_GP_PIN(4, 9),
+};
+static const unsigned int tpu_to1_mux[] = {
+   TPUTO1_MARK,
+};
+static const unsigned int tpu_to1_b_pins[] = {
+   RCAR_GP_PIN(4, 0),
+};
+static const unsigned int tpu_to1_b_mux[] = {
+   TPUTO1_B_MARK,
+};
+static const unsigned int tpu_to1_c_pins[] = {
+   RCAR_GP_PIN(4, 4),
+};
+static const unsigned int tpu_to1_c_mux[] = {
+   TPUTO1_C_MARK,
+};
+static const unsigned int tpu_to2_pins[] = {
+   RCAR_GP_PIN(1, 3),
+};
+static const unsigned int tpu_to2_mux[] = {
+   TPUTO2_MARK,
+};
+static const unsigned int tpu_to2_b_pins[] = {
+   RCAR_GP_PIN(1, 0),
+};
+static const unsigned int tpu_to2_b_mux[] = {
+   TPUTO2_B_MARK,
+};
+static const unsigned int tpu_to2_c_pins[] = {
+   RCAR_GP_PIN(0, 22),
+};
+static const unsigned int tpu_to2_c_mux[] = {
+   TPUTO2_C_MARK,
+};
+static const unsigned int tpu_to3_pins[] = {
+   RCAR_GP_PIN(1, 14),
+};
+static const unsigned int tpu_to3_mux[] = {
+   TPUTO3_MARK,
+};
+static const unsigned int tpu_to3_b_pins[] = {
+   RCAR_GP_PIN(1, 13),
+};
+static const unsigned int tpu_to3_b_mux[] = {
+   TPUTO3_B_MARK,
+};
+static const unsigned int tpu_to3_c_pins[] = {
+   RCAR_GP_PIN(0, 21),
+};
+static const unsigned int tpu_to3_c_mux[] = {
+   TPUTO3_C_MARK,
+};
 /* - SSI  
*/
 static const unsigned int ssi0_data_pins[] = {
/* SDATA0 */
@@ -3892,6 +3965,18 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
SH_PFC_PIN_GROUP(sdhi2_ctrl),
SH_PFC_PIN_GROUP(sdhi2_cd),
SH_PFC_PIN_GROUP(sdhi2_wp),
+   SH_PFC_PIN_GROUP(tpu_to0),
+   SH_PFC_PIN_GROUP(tpu_to0_b),
+   SH_PFC_PIN_GROUP(tpu_to0_c),
+   SH_PFC_PIN_GROUP(tpu_to1),
+   SH_PFC_PIN_GROUP(tpu_to1_b),
+   SH_PFC_PIN_GROUP(tpu_to1_c),
+   SH_PFC_PIN_GROUP(tpu_to2),
+   SH_PFC_PIN_GROUP(tpu_to2_b),
+   SH_PFC_PIN_GROUP(tpu_to2_c),
+   SH_PFC_PIN_GROUP(tpu_to3),
+   SH_PFC_PIN_GROUP(tpu_to3_b),
+   SH_PFC_PIN_GROUP(tpu_to3_c),
SH_PFC_PIN_GROUP(ssi0_data),
SH_PFC_PIN_GROUP(ssi0129_ctrl),
SH_PFC_PIN_GROUP(ssi1_data),
@@ -4351,6 +4436,21 @@ static const char * const sdhi2_groups[] = {
"sdhi2_wp",
 };
 
+static const char * const tpu_groups[] = {
+   "tpu_to0",
+   "tpu_to0_b",
+   "tpu_to0_c",
+   "tpu_to1",
+   "tpu_to1_b",
+   "tpu_to1_c",
+   "tpu_to2",
+   "tpu_to2_b",
+   "tpu_to2_c",
+   "tpu_to3",
+   "tpu_to3_b",
+   "tpu_to3_c",
+};
+
 static const char * const ssi_groups[] = {
"ssi0_data",
"ssi0129_ctrl",
@@ -4469,6 +4569,7 @@ static const struct sh_pfc_function pinmux_functions[] = {
SH_PFC_FUNCTION(sdhi0),
SH_PFC_FUNCTION(sdhi1),
SH_PFC_FUNCTION(sdhi2),
+   SH_PFC_FUNCTION(tpu),
SH_PFC_FUNCTION(ssi),
SH_PFC_FUNCTION(usb0),
SH_PFC_FUNCTION(usb1),
-- 
2.7.4