Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-28 Thread Vladimir Zapolskiy
Hello Sergei, On 05/26/2018 10:50 PM, Sergei Shtylyov wrote: > On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > >> The change replaces a custom implementation of .set_link_ksettings >> callback with a shared phy_ethtool_set_link_ksettings(), this fixes >> sleep in atomic context bug, which is

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-26 Thread Sergei Shtylyov
On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .set_link_ksettings > callback with a shared phy_ethtool_set_link_ksettings(), this fixes > sleep in atomic context bug, which is encountered every time when link > settings are changed by ethtool.

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
Hi Andrew, On 05/24/2018 04:29 PM, Andrew Lunn wrote: > On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: >> The change replaces a custom implementation of .set_link_ksettings >> callback with a shared phy_ethtool_set_link_ksettings(), this fixes >> sleep in atomic context bug,

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Andrew Lunn
On Thu, May 24, 2018 at 02:11:55PM +0300, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .set_link_ksettings > callback with a shared phy_ethtool_set_link_ksettings(), this fixes > sleep in atomic context bug, which is encountered every time when link > settings are

[PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

2018-05-24 Thread Vladimir Zapolskiy
The change replaces a custom implementation of .set_link_ksettings callback with a shared phy_ethtool_set_link_ksettings(), this fixes sleep in atomic context bug, which is encountered every time when link settings are changed by ethtool. Now duplex mode setting is enforced in ravb_adjust_link()