RE: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-21 Thread Fabrizio Castro
list:GPIO SUBSYSTEM ; Simon Horman > ; Chris Paterson > ; Biju Das ; Wolfram > Sang > Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups > > > > > 2) Specify SH_PFC_PIN_CFG_IO_VOLTAGE for every line that belongs to > > > the interface, keep t

Re: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-21 Thread Wolfram Sang
> > 2) Specify SH_PFC_PIN_CFG_IO_VOLTAGE for every line that belongs to > > the interface, keep the SD card pin groups as specified by this > > patch, map all of the pins to the same bit in the POC register (as > > per pin_to_pocctrl is concerned), and the board specific device tree > >

RE: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-21 Thread Fabrizio Castro
Hello Geert, Thank you for your feedback! > Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups > > Hi Fabrizio, > > CC wolfram > > On Wed, Sep 19, 2018 at 12:19 PM Fabrizio Castro > wrote: > > Although this patch is pretty much s

Re: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-20 Thread Geert Uytterhoeven
Hi Fabrizio, CC wolfram On Wed, Sep 19, 2018 at 12:19 PM Fabrizio Castro wrote: > Although this patch is pretty much standard, I would like to start a > discussion as while testing SDHI2 (which goes on the uSD connector on the > bottom side of the iwg23s) I have come across an issue. The POC

RE: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-19 Thread Fabrizio Castro
Hello Geert, > Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups > > On Tue, Sep 18, 2018 at 3:48 PM Fabrizio Castro > wrote: > > Add SDHI2 pin groups and functions to the R8A77470 SoC. > > > > Signed-off-by: Fabrizio Castro > >

Re: [PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-19 Thread Geert Uytterhoeven
On Tue, Sep 18, 2018 at 3:48 PM Fabrizio Castro wrote: > Add SDHI2 pin groups and functions to the R8A77470 SoC. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Reviewed-by: Geert Uytterhoeven But there are more SDHI channels? Gr{oetje,eeting}s, Geert --

[PATCH 4/5] pinctrl: sh-pfc: r8a77470: Add SDHI2 pin groups

2018-09-18 Thread Fabrizio Castro
Add SDHI2 pin groups and functions to the R8A77470 SoC. Signed-off-by: Fabrizio Castro Reviewed-by: Biju Das --- drivers/pinctrl/sh-pfc/pfc-r8a77470.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77470.c