Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-11 Thread Ulf Hansson
On 11 February 2016 at 14:32, Wolfram Sang wrote: > On Thu, Feb 11, 2016 at 10:00:50AM +0100, Ulf Hansson wrote: >> On 11 February 2016 at 01:07, Wolfram Sang wrote: >> >> I suspect you are using a delayed work in this driver to deal with >> >> request timeouts. >> >> >> >> The value for the dela

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-11 Thread Wolfram Sang
On Thu, Feb 11, 2016 at 10:00:50AM +0100, Ulf Hansson wrote: > On 11 February 2016 at 01:07, Wolfram Sang wrote: > >> I suspect you are using a delayed work in this driver to deal with > >> request timeouts. > >> > >> The value for the delay that is used, needs to be informed towards the > >> mmc

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-11 Thread Ulf Hansson
On 11 February 2016 at 01:07, Wolfram Sang wrote: >> I suspect you are using a delayed work in this driver to deal with >> request timeouts. >> >> The value for the delay that is used, needs to be informed towards the >> mmc core via the "->max_busy_timeout". > > Shouldn't that be a seperate patch

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-10 Thread Wolfram Sang
> I suspect you are using a delayed work in this driver to deal with > request timeouts. > > The value for the delay that is used, needs to be informed towards the > mmc core via the "->max_busy_timeout". Shouldn't that be a seperate patch? In patch 9, I add support for another SoC. But your requ

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-10 Thread Ulf Hansson
On 10 February 2016 at 17:36, Wolfram Sang wrote: > ^ >> I think you should try without MMC_CAP_WAIT_WHILE_BUSY, and then check >> that a following CMD13 command always states that the card isn't busy. >> I think the best path to try this is when sending a big write data >> request, as in that cas

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-10 Thread Wolfram Sang
^ > I think you should try without MMC_CAP_WAIT_WHILE_BUSY, and then check > that a following CMD13 command always states that the card isn't busy. > I think the best path to try this is when sending a big write data > request, as in that case you can be quite certain that the card gets > busy betw

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-01-29 Thread Ulf Hansson
On 25 January 2016 at 20:15, Wolfram Sang wrote: > From: Wolfram Sang > > Registers are 64bit apart, so we refactor bus_shift handling a little > and set it based on the DT compatible. Also, EXT_ACC is different. > > Signed-off-by: Ai Kyuse > Signed-off-by: Wolfram Sang > --- > > @MMC maintaine

[PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang Registers are 64bit apart, so we refactor bus_shift handling a little and set it based on the DT compatible. Also, EXT_ACC is different. Signed-off-by: Ai Kyuse Signed-off-by: Wolfram Sang --- @MMC maintainers: I set the MMC_CAP_WAIT_WHILE_BUSY flage here and it is needed t