Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

[Simon Horman]

On Wed, Nov 07, 2018 at 06:30:13PM +0200, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Tuesday, 6 November 2018 16:00:35 EET Simon Horman wrote:
> > On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote:
> > > The VIN driver bindings dictates fixed numbering for VIN endpoints
> > > connected to CSI-2 endpoints, even when a single endpoint exists.
> > > 
> > > Without proper endpoint numbering the VIN driver fails to probe.
> > > 
> > > Based on a patch in BSP from Koji Matsuoka 
> > > 
> > > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2
> > > device nodes") Signed-off-by: Koji Matsuoka
> > > 
> > > Signed-off-by: Takeshi Kihara 
> > > Signed-off-by: Jacopo Mondi 
> > > Reviewed-by: Laurent Pinchart 
> > 
> > Thanks,
> > 
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> > 
> > Reviewed-by: Simon Horman 
> 
> I think you can go ahead and apply it.

Thanks, applied for v4.21.

Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

[Laurent Pinchart]

Hi Simon,

On Tuesday, 6 November 2018 16:00:35 EET Simon Horman wrote:
> On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote:
> > The VIN driver bindings dictates fixed numbering for VIN endpoints
> > connected to CSI-2 endpoints, even when a single endpoint exists.
> > 
> > Without proper endpoint numbering the VIN driver fails to probe.
> > 
> > Based on a patch in BSP from Koji Matsuoka 
> > 
> > Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2
> > device nodes") Signed-off-by: Koji Matsuoka
> > 
> > Signed-off-by: Takeshi Kihara 
> > Signed-off-by: Jacopo Mondi 
> > Reviewed-by: Laurent Pinchart 
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
> 
> Reviewed-by: Simon Horman 

I think you can go ahead and apply it.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

[Simon Horman]

On Mon, Nov 05, 2018 at 02:12:43PM +0100, Jacopo Mondi wrote:
> The VIN driver bindings dictates fixed numbering for VIN endpoints connected
> to CSI-2 endpoints, even when a single endpoint exists.
> 
> Without proper endpoint numbering the VIN driver fails to probe.
> 
> Based on a patch in BSP from Koji Matsuoka 
> 
> Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device 
> nodes")
> Signed-off-by: Koji Matsuoka 
> Signed-off-by: Takeshi Kihara 
> Signed-off-by: Jacopo Mondi 
> Reviewed-by: Laurent Pinchart 

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman 

[PATCH v2] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering

[Jacopo Mondi]

The VIN driver bindings dictates fixed numbering for VIN endpoints connected
to CSI-2 endpoints, even when a single endpoint exists.

Without proper endpoint numbering the VIN driver fails to probe.

Based on a patch in BSP from Koji Matsuoka 

Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2 device 
nodes")
Signed-off-by: Koji Matsuoka 
Signed-off-by: Takeshi Kihara 
Signed-off-by: Jacopo Mondi 
Reviewed-by: Laurent Pinchart 
---
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 9509dc0..106a574 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -745,9 +745,13 @@
#size-cells = <0>;

port@1 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
reg = <1>;

-   vin4csi40: endpoint {
+   vin4csi40: endpoint@2 {
+   reg = <2>;
remote-endpoint= <>;
};
};
@@ -769,9 +773,13 @@
#size-cells = <0>;

port@1 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
reg = <1>;

-   vin5csi40: endpoint {
+   vin5csi40: endpoint@2 {
+   reg = <2>;
remote-endpoint= <>;
};
};
--
2.7.4