Re: [PATCH v2] pinctrl: rzn1: Fix check for used MDIO bus

2018-10-16 Thread jacopo mondi
Hi Phil, On Tue, Oct 16, 2018 at 08:04:53AM +, Phil Edworthy wrote: > Hi Jacopo, > > On 15 October 2018 16:12 jacopo mondi wrote: > > On Mon, Oct 15, 2018 at 04:01:47PM +0100, Phil Edworthy wrote: > > > This fixes the check for unused mdio bus setting and the following > > > static checker

RE: [PATCH v2] pinctrl: rzn1: Fix check for used MDIO bus

2018-10-16 Thread Phil Edworthy
Hi Jacopo, On 15 October 2018 16:12 jacopo mondi wrote: > On Mon, Oct 15, 2018 at 04:01:47PM +0100, Phil Edworthy wrote: > > This fixes the check for unused mdio bus setting and the following > > static checker warning: > > drivers/pinctrl/pinctrl-rzn1.c:198 rzn1_pinctrl_mdio_select() > > warn:

Re: [PATCH v2] pinctrl: rzn1: Fix check for used MDIO bus

2018-10-15 Thread jacopo mondi
Hi Phil, On Mon, Oct 15, 2018 at 04:01:47PM +0100, Phil Edworthy wrote: > This fixes the check for unused mdio bus setting and the following static > checker warning: > drivers/pinctrl/pinctrl-rzn1.c:198 rzn1_pinctrl_mdio_select() > warn: always true condition '(ipctl->mdio_func[mdio] >= 0) =>

[PATCH v2] pinctrl: rzn1: Fix check for used MDIO bus

2018-10-15 Thread Phil Edworthy
This fixes the check for unused mdio bus setting and the following static checker warning: drivers/pinctrl/pinctrl-rzn1.c:198 rzn1_pinctrl_mdio_select() warn: always true condition '(ipctl->mdio_func[mdio] >= 0) => (0-u32max >= 0)' It also fixes the return var when calling of_get_child_count()