Re: [PATCH v3 06/10] v4l: fdp1: Incorporate miscellaneous review comments

2016-09-11 Thread Kieran Bingham
On 07/09/16 23:25, Laurent Pinchart wrote: > - Constify data tables > - Add missing break in switch statement > - Use struct video_device::device_caps > - Don't set read-only flag manually for V4L2_CID_MIN_BUFFERS_FOR_CAPTURE > - Use V4L2_YCBCR_ENC_709 instead of V4L2_COLORSPACE_REC709 for ycbcr_

[PATCH v3 06/10] v4l: fdp1: Incorporate miscellaneous review comments

2016-09-07 Thread Laurent Pinchart
- Constify data tables - Add missing break in switch statement - Use struct video_device::device_caps - Don't set read-only flag manually for V4L2_CID_MIN_BUFFERS_FOR_CAPTURE - Use V4L2_YCBCR_ENC_709 instead of V4L2_COLORSPACE_REC709 for ycbcr_enc - Fix handling of V4L2_FIELD_INTERLACED - Use the s