Re: [PATCH v4 4/4] pinctrl: sh-pfc: r8a77990: Add VIN[4|5] groups/functions

2018-11-08 Thread Geert Uytterhoeven
Hi Jacopo, On Wed, Nov 7, 2018 at 11:56 AM jacopo mondi wrote: > On Wed, Nov 07, 2018 at 11:34:50AM +0100, Simon Horman wrote: > > On Tue, Nov 06, 2018 at 11:35:33AM +0100, Jacopo Mondi wrote: > > > Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car E3. > > > > > > Signed-off-by:

Re: [PATCH v4 4/4] pinctrl: sh-pfc: r8a77990: Add VIN[4|5] groups/functions

2018-11-07 Thread jacopo mondi
Hi Simon, On Wed, Nov 07, 2018 at 11:34:50AM +0100, Simon Horman wrote: > On Tue, Nov 06, 2018 at 11:35:33AM +0100, Jacopo Mondi wrote: > > Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car E3. > > > > Signed-off-by: Jacopo Mondi > > > > --- > > v3 -> v4: > > - Use new variadic v

Re: [PATCH v4 4/4] pinctrl: sh-pfc: r8a77990: Add VIN[4|5] groups/functions

2018-11-07 Thread Simon Horman
On Tue, Nov 06, 2018 at 11:35:33AM +0100, Jacopo Mondi wrote: > Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car E3. > > Signed-off-by: Jacopo Mondi > > --- > v3 -> v4: > - Use new variadic version of VIN_DATA_PIN_GROUP macro I may be missing something but this patch seems to

[PATCH v4 4/4] pinctrl: sh-pfc: r8a77990: Add VIN[4|5] groups/functions

2018-11-06 Thread Jacopo Mondi
Add pin, mux and functions definitions for VIN4 and VIN5 for R-Car E3. Signed-off-by: Jacopo Mondi --- v3 -> v4: - Use new variadic version of VIN_DATA_PIN_GROUP macro v2 -> v3: - Rebased on v4.20-rc1 - Use the newly introduced VIN_DATA_PIN_GROUP_VER macro Incorporate Geert's comments: - vin5_