Hi Heikki,
Thank you for the comments!
> From: Heikki Krogerus, Sent: Wednesday, April 11, 2018 5:02 PM
>
> On Wed, Apr 11, 2018 at 03:15:23AM +, Yoshihiro Shimoda wrote:
> > > > + host_node = of_parse_phandle(pdev->dev.of_node, "renesas,host",
> > > > 0);
> > > > + if (!host_no
Hi Heikki,
> From: Heikki Krogerus, Sent: Wednesday, April 11, 2018 4:26 PM
>
> On Tue, Apr 10, 2018 at 09:03:46PM +0900, Yoshihiro Shimoda wrote:
> > +Example of R-Car H3 ES2.0:
> > + usb3_peri0: usb@ee02 {
> > + compatible = "renesas,r8a7795-usb3-peri",
> > +
On Wed, Apr 11, 2018 at 03:15:23AM +, Yoshihiro Shimoda wrote:
> > > + host_node = of_parse_phandle(pdev->dev.of_node, "renesas,host",
> > > 0);
> > > + if (!host_node)
> > > + return -ENODEV;
> > > +
> > > + pdev_host = of_find_device_by_node(host_node);
> > >
On Tue, Apr 10, 2018 at 09:03:46PM +0900, Yoshihiro Shimoda wrote:
> This patch adds role switch support for R-Car SoCs. Some R-Car SoCs
> (e.g. R-Car H3) have USB 3.0 dual-role device controller which has
> the USB 3.0 xHCI host and Renesas USB 3.0 peripheral.
>
> Unfortunately, the mode change r
Hi Andy,
Thank you for the review!
> From: Andy Shevchenko, Sent: Tuesday, April 10, 2018 9:40 PM
>
> On Tue, Apr 10, 2018 at 3:03 PM, Yoshihiro Shimoda
> wrote:
> > +#include
> > +#include
> > +#include
>
> > +#include
>
> Do you need this one?
If using of_parse_phandle() is acceptable
On Tue, Apr 10, 2018 at 3:03 PM, Yoshihiro Shimoda
wrote:
> This patch adds role switch support for R-Car SoCs. Some R-Car SoCs
> (e.g. R-Car H3) have USB 3.0 dual-role device controller which has
> the USB 3.0 xHCI host and Renesas USB 3.0 peripheral.
>
> Unfortunately, the mode change register c