Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

Hi Chris, On Mon, Sep 12, 2016 at 1:56 PM, Chris Brandt wrote: > On 9/11/12016, Geert Uytterhoeven wrote: >> > So would you say sd_ctrl_write16_rep should also be changed to be 'const >> u16 *buf'? >> > >> > Currently it is: >> > static inline void

RE: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

Hi Geert, On 9/11/12016, Geert Uytterhoeven wrote: > > So would you say sd_ctrl_write16_rep should also be changed to be 'const > u16 *buf'? > > > > Currently it is: > > static inline void sd_ctrl_write16_rep(struct tmio_mmc_host *host, int > addr, > > u16 *buf, int count) > > { >

Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

Hi Chris, On Sun, Sep 11, 2016 at 9:50 PM, Chris Brandt wrote: > On 9/11/2016, Geert Uytterhoeven wrote: >> > --- a/drivers/mmc/host/tmio_mmc.h >> > +++ b/drivers/mmc/host/tmio_mmc.h >> >> > @@ -259,4 +265,10 @@ static inline void >> sd_ctrl_write32_as_16_and_16(struct

Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

On Fri, Sep 9, 2016 at 5:52 PM, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was change to be 32-bits wide. changed > --- a/drivers/mmc/host/tmio_mmc.h > +++ b/drivers/mmc/host/tmio_mmc.h > @@ -259,4 +265,10 @@ static inline void

RE: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

On 9/9/2016, Sergei Shtylyov wrote: > > + if (is_read) { > > + sd_ctrl_read32_rep(host, CTL_SD_DATA_PORT, , 1); > > + while (count--) { > > + *buf8 = data * 0xFF; > > 'data & 0xFF', perhaps? Wow...how did I miss

Re: [PATCH 2/3] mmc: tmio-mmc: add support for 32bit data port

Hello. On 09/09/2016 06:52 PM, Chris Brandt wrote: For the r7s72100 SOC, the DATA_PORT register was change to be 32-bits wide. Therefore a new flag has been created that will allow 32-bit reads/writes to the DATA_PORT register instead of 16-bit (because 16-bits accesses are not supported).