RE: [PATCH v5 2/4] phy: rcar-gen3-usb2: use enum phy_mode in the role_store()

2017-10-12 Thread Yoshihiro Shimoda
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com], Sent: Wednesday, October > 11, 2017 5:28 PM > > Hi, > > On Tuesday 10 October 2017 03:11 PM, Yoshihiro Shimoda wrote: > > This patch modifies the role_store() to use "enum phy_mode" instead > > of the local "bool" for host/device mode

Re: [PATCH v5 2/4] phy: rcar-gen3-usb2: use enum phy_mode in the role_store()

2017-10-11 Thread Kishon Vijay Abraham I
Hi, On Tuesday 10 October 2017 03:11 PM, Yoshihiro Shimoda wrote: > This patch modifies the role_store() to use "enum phy_mode" instead > of the local "bool" for host/device mode selection. looks good except for one minor comment.. > > Signed-off-by: Yoshihiro Shimoda

Re: [PATCH v5 2/4] phy: rcar-gen3-usb2: use enum phy_mode in the role_store()

2017-10-11 Thread Simon Horman
On Tue, Oct 10, 2017 at 06:41:28PM +0900, Yoshihiro Shimoda wrote: > This patch modifies the role_store() to use "enum phy_mode" instead > of the local "bool" for host/device mode selection. > > Signed-off-by: Yoshihiro Shimoda Thanks for the updates, this