Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-28 Thread Wolfram Sang
> Note that reset controller support is optional, so we want to add > > select RESET_CONTROLLER if ARCH_RENESAS && ARM64 > > to the I2C_RCAR section drivers/i2c/busses/Kconfig. Else reset will fail > silently. Actually, no. I use a non-optional reset_controller_get[1], so I will get an

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-27 Thread Wolfram Sang
Shimoda-san, > Please refer to "57.5.4 Usage note for the transmission and reception > procedure" in the datasheet Rev. 1.00. Thank you. I'll send a new version with the workaround in the i2c driver. > The BSP waits for maximum 1024us, not 1024ms. You are right. Sorry, my mistake. Regards,

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-27 Thread Yoshihiro Shimoda
Hi Wolfram-san, > From: Wolfram Sang, Sent: Wednesday, June 27, 2018 5:44 PM > > Hi, > > thanks for the discussion on this topic! > > > > The hardware team said: > > > - In CPG point of view: > > >- such polling doesn't need (because the reset pulse is generated > > > correctly). > > >

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-27 Thread Wolfram Sang
> > Doesn't make this writing device drivers a bit harder, I wonder? If we > > follow the above, we need to know per driver (like i2c-rcar.c) if > > reset_control_reset() is enough or if we need to call > > reset_control_status() additionally. For a driver author, it would be > > much less error

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-27 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Jun 27, 2018 at 10:44 AM Wolfram Sang wrote: > > > The hardware team said: > > > - In CPG point of view: > > >- such polling doesn't need (because the reset pulse is generated > > > correctly). > > >- About the interval after deassert the reset, this is depend on

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-27 Thread Wolfram Sang
Hi, thanks for the discussion on this topic! > > The hardware team said: > > - In CPG point of view: > >- such polling doesn't need (because the reset pulse is generated > > correctly). > >- About the interval after deassert the reset, this is depend on each > > hardware module. > >

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-26 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, June 26, 2018 5:58 PM > > Hi Shimoda-san, > > On Tue, Jun 26, 2018 at 10:38 AM Yoshihiro Shimoda > wrote: > > > From: Wolfram Sang , Sent: Tuesday, June 26, 2018 > > > 12:05 PM > > > > > I got information about this topic. > > > > > > >

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-26 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, Jun 26, 2018 at 10:38 AM Yoshihiro Shimoda wrote: > > From: Wolfram Sang , Sent: Tuesday, June 26, 2018 12:05 > > PM > > > > I got information about this topic. > > > > > > > > < In CPG / MSSR point of view > > > > > - This needs 35 usec wait while asserting. > > > > -

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-26 Thread Yoshihiro Shimoda
Hi Wolfram-san, Geert-san, I'm sorry for delayed response. I completely overlooked this email... > From: Wolfram Sang , Sent: Tuesday, June 26, 2018 12:05 PM > > > > I got information about this topic. > > > > > > < In CPG / MSSR point of view > > > > - This needs 35 usec wait while asserting.

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-25 Thread Wolfram Sang
> > I got information about this topic. > > > > < In CPG / MSSR point of view > > > - This needs 35 usec wait while asserting. > > - After deasserted a reset, no wait needs. > > - In other words, there is each hardware IP dependence. > > Let's call the above procedure A. > > > < In I2C

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-07 Thread Geert Uytterhoeven
Hi Shimoda-san, On Thu, Jun 7, 2018 at 7:36 AM, Yoshihiro Shimoda wrote: >> From: Yoshihiro Shimoda, Sent: Thursday, May 31, 2018 6:12 PM >> > From: Geert Uytterhoeven, Sent: Thursday, May 31, 2018 5:45 PM >> > On Wed, May 30, 2018 at 10:35 AM, Yoshihiro Shimoda >> > wrote: >> > >> From:

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-06 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Yoshihiro Shimoda, Sent: Thursday, May 31, 2018 6:12 PM > > Hi Geert-san, Wolfram-san, > > > From: Geert Uytterhoeven, Sent: Thursday, May 31, 2018 5:45 PM > > > > Hi Shimoda-san, > > > > On Wed, May 30, 2018 at 10:35 AM, Yoshihiro Shimoda > > wrote: > > >> From: Wolfram

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-05-31 Thread Yoshihiro Shimoda
Hello Wolfram-san, > From: Wolfram Sang, Sent: Thursday, May 31, 2018 5:31 PM > > Hello Shimoda-san, > > > > Subject: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3 > > > > If possible, I'd like to replace "bug" with "specification" or other words > > :) > > "behaviour" maybe is a

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-05-31 Thread Yoshihiro Shimoda
Hi Geert-san, Wolfram-san, > From: Geert Uytterhoeven, Sent: Thursday, May 31, 2018 5:45 PM > > Hi Shimoda-san, > > On Wed, May 30, 2018 at 10:35 AM, Yoshihiro Shimoda > wrote: > >> From: Wolfram Sang, Sent: Tuesday, May 29, 2018 7:59 PM > >> Subject: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-05-31 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, May 30, 2018 at 10:35 AM, Yoshihiro Shimoda wrote: >> From: Wolfram Sang, Sent: Tuesday, May 29, 2018 7:59 PM >> Subject: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3 > > If possible, I'd like to replace "bug" with "specification" or other words :) > > >> @@

Re: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-05-31 Thread Wolfram Sang
Hello Shimoda-san, > > Subject: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3 > > If possible, I'd like to replace "bug" with "specification" or other words :) "behaviour" maybe is a better word? > > + /* Gen3 has a HW bug which needs a reset before allowing RX DMA once */ > > +

RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-05-30 Thread Yoshihiro Shimoda
Hi Wolfram-san, Thank you for the patch! > From: Wolfram Sang, Sent: Tuesday, May 29, 2018 7:59 PM > Subject: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3 If possible, I'd like to replace "bug" with "specification" or other words :) > @@ -743,6 +753,16 @@ static int