Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-22 Thread Hans Verkuil
On 22/01/18 01:52, Laurent Pinchart wrote: > Hi Hans, > > On Friday, 19 January 2018 14:25:39 EET Hans Verkuil wrote: >> On 01/19/18 13:20, Laurent Pinchart wrote: >>> On Friday, 19 January 2018 13:20:19 EET Hans Verkuil wrote: On 01/16/18 22:44, Jacopo Mondi wrote: > Add driver for

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-22 Thread Frank Rowand
On 01/21/18 06:31, Wolfram Sang wrote: > I got a bug report for a DT node refcounting problem in the I2C subsystem. > This > patch was a huge help in validating the bug report and the proposed solution. > So, I thought I bring it to attention again. Thanks Tyrel, for the initial > work! > > Note

RE: [PATCH 0/2] Use demuxer for i2c1 and i2c5

2018-01-22 Thread Biju Das
> Subject: Re: [PATCH 0/2] Use demuxer for i2c1 and i2c5 > > On Mon, Jan 22, 2018 at 11:29:21AM +, Biju Das wrote: > > We have observed that on iWave RZ/G1E boards, randomly HDMI slave > > device is holding data line after a soft reboot. > > > > We applied demuxer patch for i2c1 and using an

Re: [PATCH] serdev: add method to set parity

2018-01-22 Thread Marcel Holtmann
Hi Ulrich, >> Adds serdev_device_set_parity() and an implementation for ttyport. > > Perhaps you can mention that the interface uses an enum and the three > settings that you add here. > >> Signed-off-by: Ulrich Hecht >> --- >> Broken out of the "[PATCH 0/6]

Re: [PATCH 0/2] Use demuxer for i2c1 and i2c5

2018-01-22 Thread Wolfram Sang
> How do i2c-bus gets details of gpio lines associated with i2c bus for bus > recovery? As you can see in the code, you don't need GPIOs if you can control SDA and SCL directly. The I2C IP can do this. > On top of renesas-dev branch, I am using the below i2c-rcar driver related > patches. >

[PATCH 0/2] Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
Back in 2014, Jean-Michel provided patches [0] to implement a means of describing software defined I2C addresses for devices through the DT nodes. The patch to implement the function "i2c_new_secondary_device()" was integrated, but the corresponding driver update didn't get applied. This short

[PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
The ADV7511 has four 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that address conflicts with other devices on the same bus may be

Re: [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver

2018-01-22 Thread Hans Verkuil
On 21/01/18 18:29, jacopo mondi wrote: > Hi Hans, > > On Sun, Jan 21, 2018 at 11:23:12AM +0100, Hans Verkuil wrote: >> On 21/01/18 11:21, Hans Verkuil wrote: >>> On 21/01/18 10:53, jacopo mondi wrote: Hi Hans, On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote: >

Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-01-22 Thread Hans Verkuil
On 21/01/18 18:49, jacopo mondi wrote: > Hi Hans, > > On Fri, Jan 19, 2018 at 12:26:09PM +0100, Hans Verkuil wrote: >> Hi Jacopo, >> >> On 01/16/18 22:44, Jacopo Mondi wrote: >>> Hello, >>>new version of CEU after Hans' review. >>> >>> Added his Acked-by to most patches and closed review

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-22 Thread Wolfram Sang
Hi Frank, > Please go back and read the thread for version 1. Simply resubmitting a > forward port is ignoring that whole conversation. > > There is a lot of good info in that thread. I certainly learned stuff in it. Yes, I did that and learned stuff, too. My summary of the discussion was: -

Re: [PATCH 0/2] Use demuxer for i2c1 and i2c5

2018-01-22 Thread Wolfram Sang
On Mon, Jan 22, 2018 at 11:29:21AM +, Biju Das wrote: > We have observed that on iWave RZ/G1E boards, randomly HDMI slave device > is holding data line after a soft reboot. > > We applied demuxer patch for i2c1 and using an oscilloscope verified that > i2c recovery works on the failure

[PATCH 1/2] media: adv7604: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
From: Jean-Michel Hautbois The ADV7604 has thirteen 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that

[PATCH vY 1/2] ARM: dts: iwg22d-sodimm-dbhd-ca: use demuxer for I2C1

2018-01-22 Thread Biju Das
Create a separate bus for HDMI related I2C1 and provide fallback to GPIO. Based on work for r8a7794/Alt by Wolfram Sang: "ARM: dts: alt: use demuxer for I2C1" Add Fixes: 97b94d256d432ba9 ("ARM: dts: iwg22d-sodimm-dbhd-ca: Add HDMI video output") Signed-off-by: Biju Das

[PATCH vY 2/2] ARM: dts: iwg22d-sodimm: use demuxer for I2C5

2018-01-22 Thread Biju Das
Create a separate bus for audiocodec related I2C5 and provide fallback to GPIO. Based on work for r8a7794/Alt by Wolfram Sang: "ARM: dts: alt: use demuxer for I2C1" Signed-off-by: Biju Das Reviewed-by: Chris Paterson ---

[PATCH 0/2] Use demuxer for i2c1 and i2c5

2018-01-22 Thread Biju Das
://patchwork.ozlabs.org/cover/857505/ it is tested against renesas-devel-20180122-v4.15-rc9 Biju Das (2): ARM: dts: iwg22d-sodimm-dbhd-ca: use demuxer for I2C1 ARM: dts: iwg22d-sodimm: use demuxer for I2C5 .../arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 96 +- arch/arm/boot/dts

Re: [PATCH v2] serdev: add method to set parity

2018-01-22 Thread Greg Kroah-Hartman
On Mon, Jan 22, 2018 at 07:23:00PM +0100, Marcel Holtmann wrote: > Hi Rob, > > > Adds serdev_device_set_parity() and an implementation for ttyport. > > The interface uses an enum with the values SERIAL_PARITY_NONE, > > SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD. > > > > Signed-off-by: Ulrich Hecht

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Kieran Bingham
On 22/01/18 13:00, Lars-Peter Clausen wrote: > On 01/22/2018 01:50 PM, Kieran Bingham wrote: >> The ADV7511 has four 256-byte maps that can be accessed via the main I²C >> ports. Each map has it own I²C address and acts as a standard slave >> device on the I²C bus. >> >> Allow a device tree node

RE: [PATCH 0/2] Use demuxer for i2c1 and i2c5

2018-01-22 Thread Biju Das
> Subject: Re: [PATCH 0/2] Use demuxer for i2c1 and i2c5 [>] > > How do i2c-bus gets details of gpio lines associated with i2c bus for bus > recovery? > > As you can see in the code, you don't need GPIOs if you can control SDA and > SCL > directly. The I2C IP can do this. I agree. Thanks for

Re: [PATCH 0/2] Use demuxer for i2c1 and i2c5

2018-01-22 Thread Wolfram Sang
> > > On top of renesas-dev branch, I am using the below i2c-rcar driver related > > patches. > > > > > > https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg2227 > > > 8.html > > > > Those should be enough. They are not? > > Yes. I have tested without demuxer patches, I confirm,

Re: [PATCH 2/2] drm: adv7511: Add support for i2c_new_secondary_device

2018-01-22 Thread Lars-Peter Clausen
On 01/22/2018 01:50 PM, Kieran Bingham wrote: > The ADV7511 has four 256-byte maps that can be accessed via the main I²C > ports. Each map has it own I²C address and acts as a standard slave > device on the I²C bus. > > Allow a device tree node to override the default addresses so that > address

Re: [PATCH v2] serdev: add method to set parity

2018-01-22 Thread Marcel Holtmann
Hi Rob, > Adds serdev_device_set_parity() and an implementation for ttyport. > The interface uses an enum with the values SERIAL_PARITY_NONE, > SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD. > > Signed-off-by: Ulrich Hecht > Reviewed-by: Sebastian Reichel

Re: [PATCH v2] serdev: add method to set parity

2018-01-22 Thread Johan Hovold
On Mon, Jan 22, 2018 at 06:56:32PM +0100, Ulrich Hecht wrote: > Adds serdev_device_set_parity() and an implementation for ttyport. > The interface uses an enum with the values SERIAL_PARITY_NONE, > SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD. > > Signed-off-by: Ulrich Hecht

[PATCH v2] serdev: add method to set parity

2018-01-22 Thread Ulrich Hecht
Adds serdev_device_set_parity() and an implementation for ttyport. The interface uses an enum with the values SERIAL_PARITY_NONE, SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD. Signed-off-by: Ulrich Hecht Reviewed-by: Sebastian Reichel