Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

2018-02-14 Thread jacopo mondi
Hi Geert, thanks for review On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi > wrote: > > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > > No groups or functions defined,

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-14 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add initial support for R-Car M3-N Salvator-x and r8a77965 SoC in > device tree with cpg-mssr, reset and clock nodes. > > Add place-holder device nodes for all nodes referred by > "salvator-common.dtsi"

Re: [PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar. > > Signed-off-by: Jacopo Mondi > --- a/drivers/gpio/gpio-rcar.c > +++ b/drivers/gpio/gpio-rcar.c > @@ -360,6 +360,10 @@

Re: [PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-14 Thread Wolfram Sang
Hi Geert, > The other R-Car Gen2 boards use 115200 bps for U-Boot and Linux, but some > other value (38400?) for the SPI loader that loads U-Boot. Yes, mostly correct. I am quite sure I have one board which has non-115200 for U-Boot. I am not at home currently, so I can't check now. > What

Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

2018-02-14 Thread Wolfram Sang
> You need to check again. :-) Seems like it. Sorry for the noise. > I am eager to apply those patches you already have reviewed (to > patch14), as those mostly seemed rather trivial and should be nice > cleanups. > > Do you mind me going ahead, then you can continue and review/test the rest?

Re: [PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-14 Thread Marek Vasut
On 02/14/2018 07:05 AM, Wolfram Sang wrote: >> +chosen { >> +bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; >> +stdout-path = "serial0:38400n8"; > > Hmm, that would be our first board to not have 115200, or? We already > have some other boards upstream where

[PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-14 Thread Niklas Söderlund
There is no way for drivers to validate a colorspace value, which could be provided by user-space by VIDIOC_S_FMT for example. Add a helper to validate that the colorspace value is part of enum v4l2_colorspace. Signed-off-by: Niklas Söderlund ---

Re: [PATCH 01/15] Documentation: devicetree: R-Car M3-N SoC DT bindings

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add device tree bindings documentation for Renesas R-Car M3-N (r8a77965) > SoC. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven

Re: [PATCH 03/15] soc: renesas: Add R-Car M3-N support

2018-02-14 Thread Geert Uytterhoeven
Hi Jacopo, Thanks for your patch! On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add support for R-Car M3-N (r8a77965) power areas and reset. > M3-N power areas are identical to M3-W ones, so just copy and rename > them. They are not identical: - M3-N does

Re: [PATCH 02/15] clk: renesas: cpg-msr: Add support for R-Car M3-N

2018-02-14 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Initial support for R-Car M3-N (r8a77965), including core and module > clocks. > > Signed-off-by: Jacopo Mondi Thanks for your patch! Please refer to Table 8.2d of R-Car

Re: [PATCH] regulator: Fix resume from suspend to idle

2018-02-14 Thread Sudeep Holla
On Tue, Feb 13, 2018 at 9:37 AM, Geert Uytterhoeven wrote: > When resuming from idle with the new suspend mode configuration support > we go through the resume callbacks with a state of PM_SUSPEND_TO_IDLE > which we don't have regulator constraints for, causing an error:

Re: [PATCH 07/15] ARM64: dts: r8a77965: Add dmac device nods

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add dmac[0-2] device nodes for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH] ravb: add support for changing MTU

2018-02-14 Thread Sergei Shtylyov
Hello! On 02/13/2018 04:12 PM, Niklas Söderlund wrote: >> On 02/12/2018 11:00 PM, Niklas Söderlund wrote: >> >>> Allow for chancing the MTU within the limit of the maximum size of a >> >>Changing. :-) > > Yes :-) > >>> descriptor (2048 bytes). Add the callback to change MTU from user-space

Re: [PATCH 08/15] Documentation: devicetree: renesas,sci: Add r8a77965

2018-02-14 Thread Geert Uytterhoeven
Subject prefix should be "dt-bindings: serial: sh-sci: " On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to reneass sci-serial Renesas > device tree bindings documentation. > > Signed-off-by: Jacopo Mondi

Re: [PATCH 12/15] ARM64: dts: r8a77965: Add GPIO nodes

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add GPIO nodes to r8a77965 SoC device tree file. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven > ---

Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

2018-02-14 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add initial PFC support for R-Car M3-N (r8a77965) SoC. > No groups or functions defined, just pin and registers enumeration. > > Signed-off-by: Jacopo Mondi Thanks for your

Re: [PATCH 06/15] Documentation: devicetree: dma: Add r8a77965 dmac

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to rcar-dmac device > tree bindings documentation. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven

Re: [PATCH] ravb: add support for changing MTU

2018-02-14 Thread Niklas Söderlund
Hi Sergei, Thanks for your feedback. On 2018-02-14 14:34:09 +0300, Sergei Shtylyov wrote: > Hello! > > On 02/13/2018 04:12 PM, Niklas Söderlund wrote: > > >> On 02/12/2018 11:00 PM, Niklas Söderlund wrote: > >> > >>> Allow for chancing the MTU within the limit of the maximum size of a > >> >

Re: [PATCH 13/15] Documentation: devicetree: ravb: Add r8a77965

2018-02-14 Thread Geert Uytterhoeven
Subject prefix should be "dt-bindings: net: ravb:" On Tue, Feb 13, 2018 at 10:46 AM, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to renesas ravb device > tree bindings documentation. > > Signed-off-by: Jacopo Mondi

Re: [PATCH v2 2/4] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-14 Thread Kieran Bingham
Hi Laurent, Thanks for the review, On 13/02/18 22:03, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 13 February 2018 21:30:35 EET Kieran Bingham wrote: >> From: Kieran Bingham >> >> The r8a77995 has a VSPBS to

Re: [PATCH v2 0/4] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-14 Thread Kieran Bingham
Hi Laurent, On 13/02/18 22:08, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patches. > >> Kieran Bingham (4): >> arm64: dts: renesas: r8a77995: add FCPV nodes >> arm64: dts: renesas: r8a77995: add VSP instances >> arm64: dts: renesas: r8a7795: Fix register mappings on VSPs >

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-14 Thread Auger Eric
Hi Geert, On 13/02/18 17:36, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the > device's compatible value. > > On many SoCs, devices are connected to an SoC-internal reset

Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

2018-02-14 Thread Masahiro Yamada
Hi Ulf, 2018-02-14 18:36 GMT+09:00 Ulf Hansson : > On 7 February 2018 at 20:11, Wolfram Sang wrote: >> >>> I picked patch5 and patch6, as those seemed trivial. Unless there is a >>> rc9, let's aim for 4.17 for the rest. >> >> I can't find the branch

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-14 Thread Geert Uytterhoeven
Hi Eric, On Wed, Feb 14, 2018 at 10:09 AM, Auger Eric wrote: > On 13/02/18 17:36, Geert Uytterhoeven wrote: >> Vfio-platform requires reset support, provided either by ACPI, or, on DT >> platforms, by a device-specific reset driver matching against the >> device's

[PATCH] dmaengine: rcar-dmac: fix max_chunk_size for R-Car Gen3

2018-02-14 Thread Yoshihiro Shimoda
According to R-Car Gen3 Rev.0.80 manual, the DMATCR can be set to 16,777,215 as maximum. So, this patch fixes the max_chunk_size for safety on all of SoCs. Otherwise, a system may hang if the DMATCR is set to 0 on R-Car Gen3. Signed-off-by: Yoshihiro Shimoda ---

Re: [PATCH] ARM: shmobile: Document Renesas H2-based Stout DT bindings

2018-02-14 Thread Geert Uytterhoeven
Hi Marek, On Wed, Feb 14, 2018 at 12:29 AM, Marek Vasut wrote: > Document the Renesas H2 Stout (ADAS Starter Kit) device tree bindings, Thanks for your patch! According to https://elinux.org/images/1/10/StoutTopWithLabels.png, it's called "ADAS Starterkit". > listing it

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

2018-02-14 Thread Auger Eric
Hi Geert, On 13/02/18 17:36, Geert Uytterhoeven wrote: > If the IOMMU group setup fails, the reset module is not released. > > Fixes: b5add544d677d363 ("vfio, platform: make reset driver a requirement by > default") > Signed-off-by: Geert Uytterhoeven > --- >

Re: [PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-14 Thread Geert Uytterhoeven
Hi Marek, On Wed, Feb 14, 2018 at 12:29 AM, Marek Vasut wrote: > Stout base board support making use of 1 GiB of memory, > the Renesas H2 r8a7790 SoC with the SCIFA0 serial port > and CA15 with ARM architected timer. > > Furthermore, this device tree contains entries for:

Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

2018-02-14 Thread Ulf Hansson
On 7 February 2018 at 20:11, Wolfram Sang wrote: > >> I picked patch5 and patch6, as those seemed trivial. Unless there is a >> rc9, let's aim for 4.17 for the rest. > > I can't find the branch where you picked these patches? I wanted to use > it to apply the rest of the

Re: [PATCH v3 3/5] arm64: dts: renesas: r8a7795-es1: Fix register mappings on VSPs

2018-02-14 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Wednesday, 14 February 2018 11:55:06 EET Kieran Bingham wrote: > From: Kieran Bingham > > The VSPD includes a CLUT on RPF2. Ensure that the register space is > mapped correctly to support this. > > Signed-off-by:

Re: [PATCH] mmc: sh_mmcif: remove some cruft

2018-02-14 Thread Ulf Hansson
On 5 February 2018 at 14:28, Wolfram Sang wrote: > The TODO section from 2010 is obsolete. We have DMA and PM meanwhile and > we always want to handle errors better, if possible. Also DRIVER_VERSION > is not used anymore these days. > > Signed-off-by: Wolfram

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-14 Thread Geert Uytterhoeven
Hi Marek, On Wed, Feb 14, 2018 at 12:28 AM, Marek Vasut wrote: > Regulator setup is suboptimal on H2 Stout too. Worse, Stout has 2 DA9210 regulators, so you have to add a check for a DA9210 at address 0x70. Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH 2/4] arm64: defconfig: Enable USB-DMAC for R-Car

2018-02-14 Thread Geert Uytterhoeven
On Wed, Feb 14, 2018 at 7:23 AM, Yoshihiro Shimoda wrote: > Enable the R-Car's USB-DMAC controller. This controller will be used > by HS-USB (renesas_usbhs driver). Since the renesas_usbhs driver > (CONFIG_USB_RENESAS_USBHS_UDC) is enabled as module, the USB-DMAC

Re: [PATCH 3/4] arm64: defconfig: Enable USB 3.0 PHY for R-Car

2018-02-14 Thread Geert Uytterhoeven
On Wed, Feb 14, 2018 at 7:23 AM, Yoshihiro Shimoda wrote: > Enable the R-Car's USB 3.0 PHY. > > Signed-off-by: Yoshihiro Shimoda Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 1/4] arm64: defconfig: Enable PWM for R-Car

2018-02-14 Thread Geert Uytterhoeven
On Wed, Feb 14, 2018 at 7:23 AM, Yoshihiro Shimoda wrote: > Enable the Renesas R-Car's PWM controller. > > Signed-off-by: Yoshihiro Shimoda Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH/RFC 5/5] hw/arm/sysbus-fdt: Enable rcar-gen3-gpio dynamic instantiation

2018-02-14 Thread Auger Eric
Hi Geert, On 09/02/18 16:17, Geert Uytterhoeven wrote: > Allow the instantiation of a Renesas R-Car Gen3 GPIO controller device > from the QEMU command line: > > -device vfio-platform,host=,manufacturer=renesas,model=rcar-gen3-gpio > -device >

Re: [PATCH] ARM: dts: stout: Initial r8a7790 Stout board support

2018-02-14 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Feb 14, 2018 at 7:05 AM, Wolfram Sang wrote: >> + chosen { >> + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; >> + stdout-path = "serial0:38400n8"; > > Hmm, that would be our first board to not have 115200, or? We

Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

2018-02-14 Thread Ulf Hansson
On 14 February 2018 at 10:43, Masahiro Yamada wrote: > Hi Ulf, > > > 2018-02-14 18:36 GMT+09:00 Ulf Hansson : >> On 7 February 2018 at 20:11, Wolfram Sang wrote: >>> I picked patch5 and patch6, as those seemed

[PATCH v3 2/5] arm64: dts: renesas: r8a77995: add VSP instances

2018-02-14 Thread Kieran Bingham
From: Kieran Bingham The r8a77995 has a VSPBS to support image processing such as blending of two input images, and has two VSPDs to handle display pipelines with a DU. Signed-off-by: Kieran Bingham Reviewed-by:

[PATCH v3 0/5] arm64: dts: renesas: r8a77995: Add VSP support

2018-02-14 Thread Kieran Bingham
From: Kieran Bingham The r8a77995-d3 platform supports 3 VSP instances. One VSPBS can be used as a dual-input image blender, while two VSPD instances can be utilised as part of a display (DU) pipeline. Add support for these, along with their required

[PATCH v3 1/5] arm64: dts: renesas: r8a77995: add FCPV nodes

2018-02-14 Thread Kieran Bingham
From: Kieran Bingham The FCPVB handles the interface between the VSPB and memory, while the FCPVD handles the interface between the VSPD and memory. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart

Re: [PATCH 4/4] arm64: defconfig: Enable USB 3.0 peripheral for R-Car

2018-02-14 Thread Geert Uytterhoeven
On Wed, Feb 14, 2018 at 7:23 AM, Yoshihiro Shimoda wrote: > Enable the R-Car's USB 3.0 peripheral controller. > > Signed-off-by: Yoshihiro Shimoda Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH v3 00/16] mmc: tmio: another batch of TMIO MMC fixes and cleanups

2018-02-14 Thread Ulf Hansson
On 14 February 2018 at 11:23, Wolfram Sang wrote: > >> You need to check again. :-) > > Seems like it. Sorry for the noise. > >> I am eager to apply those patches you already have reviewed (to >> patch14), as those mostly seemed rather trivial and should be nice >> cleanups.

Re: [PATCH 1/5] soc: renesas: Add symbols for R-Car Gen3 register offsets

2018-02-14 Thread Geert Uytterhoeven
Hi Simon, On Mon, Feb 12, 2018 at 4:44 PM, Simon Horman wrote: > Add symbols for Gen3 register offsets. > These may be used to improve readability of users of these offsets. > > This does not introduce any functional change. > > Signed-off-by: Simon Horman

Re: [PATCH] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-14 Thread Geert Uytterhoeven
On Wed, Feb 14, 2018 at 6:58 AM, Wolfram Sang wrote: >> - * The r8a7790/lager and r8a7791/koelsch development boards have da9063 and >> - * da9210 regulators. Both regulators have their interrupt request lines >> tied >> - * to the same interrupt pin (IRQ2) on the SoC. >> +

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

2018-02-14 Thread Geert Uytterhoeven
Hi Eric, On Wed, Feb 14, 2018 at 9:36 AM, Auger Eric wrote: > If I am not wrong we also leak the reset_module if > vfio_platform_get_reset() fails to find the reset function (of_reset == > NULL), in which case we should do the module_put() in > vfio_platform_get_reset().

[PATCH v3 4/5] arm64: dts: renesas: r8a7795: Fix register mappings on VSPs

2018-02-14 Thread Kieran Bingham
From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart

[PATCH v3 5/5] arm64: dts: renesas: r8a7796: Fix register mappings on VSPs

2018-02-14 Thread Kieran Bingham
From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart

[PATCH v3 3/5] arm64: dts: renesas: r8a7795-es1: Fix register mappings on VSPs

2018-02-14 Thread Kieran Bingham
From: Kieran Bingham The VSPD includes a CLUT on RPF2. Ensure that the register space is mapped correctly to support this. Signed-off-by: Kieran Bingham --- arch/arm64/boot/dts/renesas/r8a7795-es1.dtsi | 2 +- 1

Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 12:24 PM, Sergei Shtylyov wrote: > Specify EtherAVB PHY IRQ in the Eagle board's device tree, now that we > have the GPIO support (previously phylib had to resort to polling). > > Signed-off-by: Sergei Shtylyov

Re: [PATCH v2 1/2] arm64: dts: renesas: r8a77970: add GPIO support

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 12:22 PM, Sergei Shtylyov wrote: > Describe all 6 GPIO controllers in the R8A77970 device tree. > > Based on the original (and large) patch by Daisuke Matsushita > . > > Signed-off-by: Vladimir Barinov

Re: [PATCH 01/15] Documentation: devicetree: R-Car M3-N SoC DT bindings

2018-02-14 Thread Simon Horman
On Tue, Feb 13, 2018 at 10:45:48AM +0100, Jacopo Mondi wrote: > Add device tree bindings documentation for Renesas R-Car M3-N (r8a77965) > SoC. > > Signed-off-by: Jacopo Mondi Thanks, this looks fine to me but I think the subject should be updated to dt-bindings:

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-14 Thread Auger Eric
Hi Geert, On 14/02/18 10:43, Geert Uytterhoeven wrote: > Hi Eric, > > On Wed, Feb 14, 2018 at 10:09 AM, Auger Eric wrote: >> On 13/02/18 17:36, Geert Uytterhoeven wrote: >>> Vfio-platform requires reset support, provided either by ACPI, or, on DT >>> platforms, by a

Re: [PATCH/RFC 3/5] hw/arm/virt: Allow dynamic sysbus devices again

2018-02-14 Thread Auger Eric
Hi Geert, On 09/02/18 16:17, Geert Uytterhoeven wrote: > Allow the instantation of generic dynamic sysbus devices again, without > the need to create a new device-specific vfio type. > > This is a partial revert of commit 6f2062b9758ebc64 ("hw/arm/virt: > Allow only supported dynamic sysbus

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-14 Thread Sakari Ailus
On Wed, Feb 14, 2018 at 11:36:43AM +0100, Niklas Söderlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part of enum v4l2_colorspace. > >

Re: [PATCH] drm: rcar-du: Enable VSP compositor by default on Gen3

2018-02-14 Thread Kieran Bingham
Hi Laurent, Thankyou for the patch. On 12/01/18 03:20, Laurent Pinchart wrote: > On Gen3 hardware the VSP compositor is required for display. Enable it > by default in the kernel configuration. The option is kept > user-configurable for testing purpose on Gen2 platforms. > > Signed-off-by:

Re: [PATCH 09/15] pinctrl: sh-pfc: r8a77965: Add SCIFs groups/functions

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add SCIF[0-5] groups and pin function definitions for R-Car M3-N. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Minor nit below... > ---

Re: [PATCH 14/15] pinctrl: sh-pfc: r8a77965: Add EtherAVB groups/functions

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:46 AM, Jacopo Mondi wrote: > Add EtherAVB groups and functions definitions for R-Car M3-N. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 04/15] pinctrl: sh-pfc: Initial R-Car M3-N support

2018-02-14 Thread Geert Uytterhoeven
Hi Jacopo, On Wed, Feb 14, 2018 at 2:53 PM, jacopo mondi wrote: > On Wed, Feb 14, 2018 at 02:37:08PM +0100, Geert Uytterhoeven wrote: >> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi >> wrote: >> > Add initial PFC support for R-Car M3-N (r8a77965)

Re: [PATCH 15/15] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:46 AM, Jacopo Mondi wrote: > Populate the ethernet@e680 device node to enable Ethernet interface > for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven

Re: [PATCH 13/15] Documentation: devicetree: ravb: Add r8a77965

2018-02-14 Thread Sergei Shtylyov
Hello! You need to send this patch to netdev and Cc me as well... On 02/13/2018 12:46 PM, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to renesas ravb device > tree bindings documentation. > > Signed-off-by: Jacopo Mondi [...] Acked-by:

Re: [PATCH 10/15] ARM64: dts: r8a77965: Add SCIF device nodes

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi wrote: > Add SCIF[0-5] device nodes for M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-14 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday, 14 February 2018 12:36:43 EET Niklas Söderlund wrote: > There is no way for drivers to validate a colorspace value, which could > be provided by user-space by VIDIOC_S_FMT for example. Add a helper to > validate that the colorspace value is part

Re: [PATCH/RFC 00/11] ARM: dts: rcar-gen2: Enable watchdog support

2018-02-14 Thread Geert Uytterhoeven
On Fri, Feb 9, 2018 at 11:11 AM, Geert Uytterhoeven wrote: > On Thu, Feb 8, 2018 at 11:34 AM, Geert Uytterhoeven > wrote: >> This patch series enables the builtin watchdog timer on R-Car Gen2 SoCs >> on all supported boards, and builds on top of

Re: [PATCH 2/3] DT: display: renesas,lvds: document R8A77970 bindings

2018-02-14 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Friday, 19 January 2018 20:29:20 EET Sergei Shtylyov wrote: > Document the R-Car V3M (R8A77970) SoC in the R-Car LVDS bindings. > > Signed-off-by: Sergei Shtylyov Reviewed-by: Laurent Pinchart

[PATCH v2 1/3] drm: rcar-du: lvds: Fix LVDS startup on R-Car Gen2

2018-02-14 Thread Laurent Pinchart
From: Sergei Shtylyov According to the latest revision 2.00 of the R-Car Gen2 manual, the LVDS and the bias circuit must be enabled after the LVDS I/O pins are enabled, not before. Fix the Gen2 LVDS startup sequence accordingly. While at it, also fix the

Re: [PATCH 3/3] drm: rcar-du: lvds: add R8A77970 support

2018-02-14 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Friday, 19 January 2018 20:29:21 EET Sergei Shtylyov wrote: > Add support for the R-Car V3M (R8A77970) SoC to the LVDS encoder driver. > Note that there are some differences with the other R-Car gen3 SoCs, e.g. > LVDPLLCR has the same layout as in the R-Car

[PATCH v2 0/3] R-Car DU: Fix and refactor LVDS to prepare for V3M support

2018-02-14 Thread Laurent Pinchart
Hello, This patch series fixes the LVDS startup sequence for Gen2 and Gen3 SoCs, and then proceeds to refactoring the code to merge the Gen2 and Gen3 implementations in preparation for V3M support. The patches have been previously posted as part of the following series. [PATCH 0/2] Fix LVDS

[PATCH v2 3/3] drm: rcar-du: lvds: Refactor LVDS startup

2018-02-14 Thread Laurent Pinchart
From: Sergei Shtylyov After the recent corrections to the R-Car gen2/3 LVDS startup code, already similar enough at their ends rcar_lvds_enable_gen{2|3}() started asking for a merge and it's becoming actually necessary with the addition of the R-Car V3M

[PATCH v2 2/3] drm: rcar-du: lvds: Fix LVDS startup on R-Car Gen3

2018-02-14 Thread Laurent Pinchart
From: Sergei Shtylyov According to the latest revisions of the R-Car Gen3 manual, the LVDS mode must be set before the LVDS I/O pins are enabled, not after -- fix the Gen3 LVDS startup sequence accordingly. Fixes: e947eccbeba4 ("drm: rcar-du: Add support for

[PATCH v2] device_tree: Increase FDT_MAX_SIZE to 1 MiB

2018-02-14 Thread Geert Uytterhoeven
It is not uncommon for a contemporary FDT to be larger than 64 KiB, leading to failures loading the device tree from sysfs: qemu-system-aarch64: qemu_fdt_setprop: Couldn't set ...: FDT_ERR_NOSPACE Hence increase the limit to 1 MiB, like on PPC. For reference, the largest arm64 DTB created

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-14 Thread Philippe Ombredanne
Jacopo, On Wed, Feb 14, 2018 at 2:58 PM, Geert Uytterhoeven wrote: >> --- /dev/null >> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> @@ -0,0 +1,30 @@ >> +// SPDX-License-Identifier: GPL-2. This should be GPL-2.0 >> --- /dev/null >> +++

Re: [PATCH] drm: rcar-du: lvds: Fix LVDS clock frequency range

2018-02-14 Thread Sergei Shtylyov
On 01/13/2018 12:40 AM, Laurent Pinchart wrote: > According to the latest versions of both the Gen2 and Gen3 datasheets, > the operating range for the LVDS clock is 31 MHz to 148.5 MHz on all Not quite so with R-Car D3/E3 (which have the low boundary of 5 MHz) But we don't support them yet

Re: [PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

2018-02-14 Thread Laurent Pinchart
Hi Sergei, On Tuesday, 16 January 2018 17:42:41 EET Laurent Pinchart wrote: > On Saturday, 13 January 2018 11:25:31 EET Sergei Shtylyov wrote: > > On 1/13/2018 1:15 AM, Laurent Pinchart wrote: > According to the latest revisions of the R-Car gen3 manual, the LVDS > mode must be set

Re: [PATCH v2 3/3] drm: rcar-du: lvds: Refactor LVDS startup

2018-02-14 Thread Sergei Shtylyov
On 02/14/2018 09:13 PM, Laurent Pinchart wrote: > From: Sergei Shtylyov > > After the recent corrections to the R-Car gen2/3 LVDS startup code, already > similar enough at their ends rcar_lvds_enable_gen{2|3}() started asking for > a merge and it's becoming

[PATCH v3 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-02-14 Thread Laurent Pinchart
The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge. Backward compatibility is retained as legacy DT is patched

[PATCH v3 08/12] ARM: dts: r8a7792: Convert to new DU DT bindings

2018-02-14 Thread Laurent Pinchart
The DU DT bindings have been updated to drop the reg-names property. Update the r8a7792 device tree accordingly. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7792.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 11/12] arm64: dts: renesas: r8a7795: Convert to new LVDS DT bindings

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v2: - Fixed LVDS compatible string Changes since v1: - Remove the DU reg-names property

[PATCH v3 09/12] ARM: dts: r8a7793: Convert to new LVDS DT bindings

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v2: - Fixed LVDS compatible string Changes since v1: - Remove the DU reg-names property

[PATCH v3 07/12] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v2: - Fixed LVDS compatible string Changes since v1: - Remove the DU reg-names property

[PATCH v3 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoders now have their own DT bindings. Before switching the driver infrastructure to those new bindings, implement backward-compatibility through live DT patching. Patching is disabled and will be enabled along with support for the new DT bindings in the DU driver.

[PATCH v3 12/12] arm64: dts: renesas: r8a7796: Convert to new LVDS DT bindings

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v2: - Fixed LVDS compatible string Changes since v1: - Remove the DU reg-names property

[PATCH v3 01/12] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-14 Thread Laurent Pinchart
The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add corresponding device tree bindings. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Move the SoC name before the IP name in

[PATCH v3 05/12] ARM: dts: porter: Fix HDMI output routing

2018-02-14 Thread Laurent Pinchart
The HDMI encoder is connected to the RGB output of the DU, which is port@0, not port@1. Fix the incorrect DT description. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7791-porter.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 00/12] R-Car DU: Convert LVDS code to bridge driver

2018-02-14 Thread Laurent Pinchart
Hello, This patch series addresses a design mistake that dates back from the initial DU support. Support for the LVDS encoders, which are IP cores separate from the DU, was bundled in the DU driver. Worse, both the DU and LVDS were described through a single DT node. To fix the, patches 01/12

[PATCH v3 02/12] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoders now have their own DT bindings, representing them as part of the DU is deprecated. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Remove the LVDS reg range from the example

[PATCH v3 06/12] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-02-14 Thread Laurent Pinchart
The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v2: - Fixed LVDS compatible string Changes since v1: - Remove the DU reg-names property

[PATCH v3 10/12] ARM: dts: r8a7794: Convert to new DU DT bindings

2018-02-14 Thread Laurent Pinchart
The DU DT bindings have been updated to drop the reg-names property. Update the r8a7792 device tree accordingly. Signed-off-by: Laurent Pinchart --- arch/arm/boot/dts/r8a7794.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v2 3/3] drm: rcar-du: lvds: Refactor LVDS startup

2018-02-14 Thread Laurent Pinchart
Hi Sergei, On Wednesday, 14 February 2018 20:39:59 EET Sergei Shtylyov wrote: > On 02/14/2018 09:13 PM, Laurent Pinchart wrote: > > From: Sergei Shtylyov > > > > After the recent corrections to the R-Car gen2/3 LVDS startup code, > > already similar enough at