Re: [PATCH v4 07/16] i2c: demux: Use changeset helpers for clarity

2018-02-21 Thread Wolfram Sang
On Wed, Feb 21, 2018 at 01:10:37AM +0200, Laurent Pinchart wrote: > From: Pantelis Antoniou > > The changeset helpers are easier to use, use them instead of > using the static property. > > Signed-off-by: Pantelis Antoniou >

Re: [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-21 Thread Sergei Shtylyov
On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add corresponding device tree bindings. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1:

Re: [PATCH v4 14/16] ARM: dts: r8a7794: Convert to new DU DT bindings

2018-02-21 Thread Sergei Shtylyov
Hello! On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The DU DT bindings have been updated to drop the reg-names property. Update the r8a7792 device tree accordingly. Apparently r8a7794. Signed-off-by: Laurent Pinchart [...] MBR, Sergei

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread jacopo mondi
Hi Sergei, On Tue, Feb 20, 2018 at 06:30:56PM +0300, Sergei Shtylyov wrote: > On 02/20/2018 06:12 PM, Jacopo Mondi wrote: > > > Populate the ethernet@e680 device node to enable Ethernet interface > > for R-Car M3-N (r8a77965) SoC. > > > > Signed-off-by: Jacopo Mondi

Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

2018-02-21 Thread Hans Verkuil
On 02/21/18 13:29, Laurent Pinchart wrote: > Hi Hans, > > On Wednesday, 21 February 2018 14:03:24 EET Hans Verkuil wrote: >> On 02/19/18 17:59, Jacopo Mondi wrote: >>> Add driver for Renesas Capture Engine Unit (CEU). >>> >>> The CEU interface supports capturing 'data' (YUV422) and 'images' >>>

Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

2018-02-21 Thread Hans Verkuil
On 02/19/18 17:59, Jacopo Mondi wrote: > Add support to ov772x driver for frame intervals handling and enumeration. > Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for > 10, 15 and 30 frame per second rates. > > Signed-off-by: Jacopo Mondi >

Re: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv()

2018-02-21 Thread Laurent Pinchart
Hi Geert, On Wednesday, 21 February 2018 12:26:45 EET Geert Uytterhoeven wrote: > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Add an __of_node_dupv() private method and make __of_node_dup() use it. > > This is

Re: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv()

2018-02-21 Thread Rob Herring
On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Add an __of_node_dupv() private method and make __of_node_dup() use it. > This is required for the subsequent changeset accessors

[PATCH] pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]

2018-02-21 Thread Niklas Söderlund
When adding GP-1-28 port pin support it was forgotten to remove the CLKOUT pin from the list of pins that are not associated with a GPIO port in pinmux_pins[]. This results in a warning when reading the pinctrl files in sysfs as the CLKOUT pin is still added as a none GPIO pin. Fix this by

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Rob Herring
On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Changesets are very powerful, but the lack of a helper API > makes using them cumbersome. Introduce a simple copy based > API that

Re: [PATCH v4 06/16] of: unittest: changeset helpers

2018-02-21 Thread Laurent Pinchart
Hi Rob, On Thursday, 22 February 2018 01:10:25 EET Rob Herring wrote: > On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Add a unitest specific for the new changeset helpers. > > > > Signed-off-by: Pantelis Antoniou

Re: [PATCH v4 08/16] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-21 Thread Rob Herring
On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > The internal LVDS encoders now have their own DT bindings. Before > switching the driver infrastructure to those new bindings, implement > backward-compatibility through live DT patching. > >

Re: [PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 06:47:58PM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart

[PATCH] i2c: adv748x: afe: fix sparse warning

2018-02-21 Thread Niklas Söderlund
This fixes the following sparse warning: drivers/media/i2c/adv748x/adv748x-afe.c:294:34:expected unsigned int [usertype] *signal drivers/media/i2c/adv748x/adv748x-afe.c:294:34:got int * drivers/media/i2c/adv748x/adv748x-afe.c:294:34: warning: incorrect type in argument 2 (different

Re: [PATCH v4 05/16] of: changeset: Add of_changeset_node_move method

2018-02-21 Thread Rob Herring
On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Adds a changeset helper for moving a subtree to a different place > in the running tree. This is useful in advances cases of dynamic >

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-21 Thread Hans Verkuil
On 02/21/2018 09:16 PM, Laurent Pinchart wrote: > Hi Hans, > > On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote: >> On 02/19/2018 11:28 PM, Niklas Söderlund wrote: >>> Hi Hans, >>> >>> Thanks for your feedback. >>> >>> [snip] >>> Can you then fix v4l2-compliance to stop

[PATCH v5 8/8] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-02-21 Thread Laurent Pinchart
The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge. Backward compatibility is retained as legacy DT is patched

[PATCH v5 6/8] i2c: demux: Use changeset helpers for clarity

2018-02-21 Thread Laurent Pinchart
From: Pantelis Antoniou The changeset helpers are easier to use, use them instead of using the static property. Signed-off-by: Pantelis Antoniou Acked-by: Wolfram Sang ["okay" -> "ok"] Signed-off-by: Laurent

[PATCH v5 4/8] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Laurent Pinchart
From: Pantelis Antoniou Changesets are very powerful, but the lack of a helper API makes using them cumbersome. Introduce a simple copy based API that makes things considerably easier. To wit, adding a property using the raw API. struct property *prop;

[PATCH v5 7/8] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-21 Thread Laurent Pinchart
The internal LVDS encoders now have their own DT bindings. Before switching the driver infrastructure to those new bindings, implement backward-compatibility through live DT patching. Patching is disabled and will be enabled along with support for the new DT bindings in the DU driver.

[PATCH v5 0/8] R-Car DU: Convert LVDS code to bridge driver

2018-02-21 Thread Laurent Pinchart
Hello, This patch series addresses a design mistake that dates back from the initial DU support. Support for the LVDS encoders, which are IP cores separate from the DU, was bundled in the DU driver. Worse, both the DU and LVDS were described through a single DT node. To fix the, patches 1/8 and

[PATCH v5 3/8] of: dynamic: Add __of_node_dupv()

2018-02-21 Thread Laurent Pinchart
From: Pantelis Antoniou Add an __of_node_dupv() private method and make __of_node_dup() use it. This is required for the subsequent changeset accessors which will make use of it. Signed-off-by: Pantelis Antoniou [Make

[PATCH v5 2/8] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings

2018-02-21 Thread Laurent Pinchart
The internal LVDS encoders now have their own DT bindings, representing them as part of the DU is deprecated. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Remove the LVDS reg range from the example

[PATCH v5 5/8] of: unittest: changeset helpers

2018-02-21 Thread Laurent Pinchart
From: Pantelis Antoniou Add a unitest specific for the new changeset helpers. Signed-off-by: Pantelis Antoniou [Use IS_ENABLED instead of #ifdef] Signed-off-by: Laurent Pinchart

[PATCH v5 1/8] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-21 Thread Laurent Pinchart
The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add corresponding device tree bindings. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Move the SoC name before the IP name in

Re: [PATCH v4 06/16] of: unittest: changeset helpers

2018-02-21 Thread Rob Herring
On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Add a unitest specific for the new changeset helpers. > > Signed-off-by: Pantelis Antoniou >

Re: [PATCH v4 05/16] of: changeset: Add of_changeset_node_move method

2018-02-21 Thread Laurent Pinchart
Hi Rob, On Thursday, 22 February 2018 01:20:36 EET Rob Herring wrote: > On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Adds a changeset helper for moving a subtree to a different place > > in the running tree. This is

Re: [PATCH v4 06/16] of: unittest: changeset helpers

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 5:39 PM, Laurent Pinchart wrote: > Hi Rob, > > On Thursday, 22 February 2018 01:10:25 EET Rob Herring wrote: >> On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: >> > From: Pantelis Antoniou >> > >>

Re: [PATCH v4 08/16] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-21 Thread Laurent Pinchart
Hi Rob, On Thursday, 22 February 2018 01:28:48 EET Rob Herring wrote: > On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote: > > The internal LVDS encoders now have their own DT bindings. Before > > switching the driver infrastructure to those new bindings, implement > >

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-21 Thread Frank Rowand
On 02/20/18 15:10, Laurent Pinchart wrote: > Hello, > > This patch series addresses a design mistake that dates back from the initial > DU support. Support for the LVDS encoders, which are IP cores separate from > the DU, was bundled in the DU driver. Worse, both the DU and LVDS were > described

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Rob Herring
On Wed, Feb 21, 2018 at 4:21 AM, Geert Uytterhoeven wrote: > Hi Laurent, > > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart > wrote: >> From: Pantelis Antoniou >> >> Changesets are very

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 01:10:30AM +0200, Laurent Pinchart wrote: > Hello, > > This patch series addresses a design mistake that dates back from the initial > DU support. Support for the LVDS encoders, which are IP cores separate from > the DU, was bundled in the DU driver. Worse, both the DU and

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-21 Thread Philipp Zabel
Hi Geert, I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see below: On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: > Vfio-platform requires reset support, provided either by ACPI, or, on DT > platforms, by a device-specific reset driver matching against the >

Re: [PATCH v2 03/19] soc: renesas: Identify R-Car M3-N

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:40:34PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi > wrote: > > Add support for indentifying R-Car M3-N (R8A77965) SoC. > > > > Signed-off-by: Jacopo Mondi > >

Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

2018-02-21 Thread Hans Verkuil
On 02/21/18 16:16, jacopo mondi wrote: >>> static const struct v4l2_subdev_pad_ops ov772x_subdev_pad_ops = { >>> - .enum_mbus_code = ov772x_enum_mbus_code, >>> - .get_selection = ov772x_get_selection, >>> - .get_fmt= ov772x_get_fmt, >>> - .set_fmt= ov772x_set_fmt, >>> +

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-21 Thread jacopo mondi
Hello again, On Tue, Feb 20, 2018 at 09:58:57AM +0100, jacopo mondi wrote: > Hi Laurent, > > On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > On Monday, 19 February 2018 18:59:44 EET Jacopo Mondi wrote: > > > The sensor

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-21 Thread Geert Uytterhoeven
Hi Eric, On Wed, Feb 14, 2018 at 11:11 AM, Auger Eric wrote: > On 14/02/18 10:43, Geert Uytterhoeven wrote: >> On Wed, Feb 14, 2018 at 10:09 AM, Auger Eric wrote: >>> On 13/02/18 17:36, Geert Uytterhoeven wrote: Vfio-platform requires reset

Re: [PATCH v2] arm64: defconfig: Enable PWM and USB for R-Car

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 02:57:16PM +0900, Yoshihiro Shimoda wrote: > Enables PWM controller, USB-DMAC that is used by HS-USB, USB 3.0 > peripheral controller and USB 3.0 PHY for R-Car SoCs. > > Signed-off-by: Yoshihiro Shimoda > Acked-by: Geert Uytterhoeven

Re: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

2018-02-21 Thread Geert Uytterhoeven
Hi Simon, On Wed, Feb 21, 2018 at 5:13 PM, Simon Horman wrote: > On Tue, Feb 20, 2018 at 01:51:28PM +0100, Geert Uytterhoeven wrote: >> On Mon, Feb 12, 2018 at 6:44 PM, Fabrizio Castro >> wrote: >> > this series has been around for some time

Re: [PATCH 1/2] vfio: platform: Fix reset module leak in error path

2018-02-21 Thread Geert Uytterhoeven
Hi Eric, On Wed, Feb 14, 2018 at 10:32 AM, Geert Uytterhoeven wrote: > On Wed, Feb 14, 2018 at 9:36 AM, Auger Eric wrote: >> If I am not wrong we also leak the reset_module if >> vfio_platform_get_reset() fails to find the reset function (of_reset ==

Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

2018-02-21 Thread jacopo mondi
Hi Laurent, Hans, On Wed, Feb 21, 2018 at 02:02:59PM +0100, Hans Verkuil wrote: > On 02/21/18 13:29, Laurent Pinchart wrote: > > Hi Hans, > > > > On Wednesday, 21 February 2018 14:03:24 EET Hans Verkuil wrote: > >> On 02/19/18 17:59, Jacopo Mondi wrote: > >>> Add driver for Renesas Capture Engine

Re: [PATCH v2 04/19] soc: renesas: rcar-sysc: Add R-Car M3-N support

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:06PM +0100, Jacopo Mondi wrote: > Add support for R-Car M3-N (R8A77965) power areas. > > Signed-off-by: Jacopo Mondi > > --- > v1->v2: > - Remove A2VC0 power area > - Add A3VP power area > --- > .../bindings/power/renesas,rcar-sysc.txt

Re: [PATCH v2 06/19] dt-bindings: arm: Document R-Car M3-N SoC DT bindings

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:08PM +0100, Jacopo Mondi wrote: > Add device tree bindings documentation for Renesas R-Car M3-N (r8a77965) > SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Rob Herring

Re: [PATCH v9 07/11] media: i2c: ov772x: Support frame interval handling

2018-02-21 Thread jacopo mondi
Hi Hans, On Wed, Feb 21, 2018 at 01:12:14PM +0100, Hans Verkuil wrote: [snip] > > +static int ov772x_g_frame_interval(struct v4l2_subdev *sd, > > + struct v4l2_subdev_frame_interval *ival) > > +{ > > + struct ov772x_priv *priv = to_ov772x(sd); > > + struct

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Geert Uytterhoeven
Hi Rob, On Wed, Feb 21, 2018 at 4:23 PM, Rob Herring wrote: > On Wed, Feb 21, 2018 at 4:21 AM, Geert Uytterhoeven > wrote: >> You missed one fix I have in my topic/overlays branch >>

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread Sergei Shtylyov
Hello! On 02/21/2018 01:07 PM, jacopo mondi wrote: >>> Populate the ethernet@e680 device node to enable Ethernet interface >>> for R-Car M3-N (r8a77965) SoC. >>> >>> Signed-off-by: Jacopo Mondi >>> Reviewed-by: Geert Uytterhoeven >>> >>>

Re: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 01:51:28PM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 12, 2018 at 6:44 PM, Fabrizio Castro > wrote: > > this series has been around for some time as RFC, and it has collected > > useful comments from the community along the way. > > The

Re: [PATCH] watchdog: renesas_wdt: Blacklist early R-Car Gen2 SoCs

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 04:43:04PM +0100, Geert Uytterhoeven wrote: > On early revisions of some R-Car Gen2 SoCs, and depending on SMP > configuration, the system may fail to restart on watchdog time-out, and > lock up instead. > > Specifically: > - On R-Car H2 ES1.0 and M2-W ES1.0, watchdog

Re: [PATCH v2 02/19] soc: renesas: rcar-rst: Add support for R-Car M3-N

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:29:37PM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi > wrote: > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert Uytterhoeven Thanks, applied.

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-21 Thread Hans Verkuil
On 02/21/2018 04:47 PM, jacopo mondi wrote: > Hello again, > > On Tue, Feb 20, 2018 at 09:58:57AM +0100, jacopo mondi wrote: >> Hi Laurent, >> >> On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote: >>> Hi Jacopo, >>> >>> Thank you for the patch. >>> >>> On Monday, 19 February 2018

Re: [PATCH v2 07/19] ARM64: Add Renesas R-Car M3-N config symbol

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:09PM +0100, Jacopo Mondi wrote: > Add configuration option for the R-Car M3-N (R8A77965) SoC. > > Signed-off-by: Jacopo Mondi Thanks, I have applied this after updating the subject to: arm64: add Renesas R8A77965 support Please use

Re: [PATCH v4 03/16] of: dynamic: Add __of_node_dupv()

2018-02-21 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Add an __of_node_dupv() private method and make __of_node_dup() use it. > This is required for the subsequent changeset

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > Changesets are very powerful, but the lack of a helper API > makes using them cumbersome. Introduce a simple copy based

Re: [PATCH v9 06/11] media: i2c: ov772x: Remove soc_camera dependencies

2018-02-21 Thread Hans Verkuil
On 02/19/18 17:59, Jacopo Mondi wrote: > Remove soc_camera framework dependencies from ov772x sensor driver. > - Handle clock and gpios > - Register async subdevice > - Remove soc_camera specific g/s_mbus_config operations > - Change image format colorspace from JPEG to SRGB as the two use the >

Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

2018-02-21 Thread Hans Verkuil
On 02/19/18 17:59, Jacopo Mondi wrote: > Add driver for Renesas Capture Engine Unit (CEU). > > The CEU interface supports capturing 'data' (YUV422) and 'images' > (NV[12|21|16|61]). > > This driver aims to replace the soc_camera-based sh_mobile_ceu one. > > Tested with ov7670 camera sensor,

Re: [PATCH v4 04/16] of: changesets: Introduce changeset helper methods

2018-02-21 Thread Laurent Pinchart
Hi Geert, On Wednesday, 21 February 2018 12:21:50 EET Geert Uytterhoeven wrote: > On Wed, Feb 21, 2018 at 12:10 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > Changesets are very powerful, but the lack of a helper API > > makes using them

Re: [PATCH v9 03/11] media: platform: Add Renesas CEU driver

2018-02-21 Thread Laurent Pinchart
Hi Hans, On Wednesday, 21 February 2018 14:03:24 EET Hans Verkuil wrote: > On 02/19/18 17:59, Jacopo Mondi wrote: > > Add driver for Renesas Capture Engine Unit (CEU). > > > > The CEU interface supports capturing 'data' (YUV422) and 'images' > > (NV[12|21|16|61]). > > > > This driver aims to

Re: [PATCH v2 14/19] ARM64: dts: r8a77965: Add SCIF device nodes

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:16PM +0100, Jacopo Mondi wrote: > Add SCIF[0-5] device nodes for M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven Thanks, applied with prefix updated to: arm64: dts:

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 06:48:59PM +0300, Sergei Shtylyov wrote: > Hello! > > On 02/21/2018 01:07 PM, jacopo mondi wrote: > > >>> Populate the ethernet@e680 device node to enable Ethernet interface > >>> for R-Car M3-N (r8a77965) SoC. > >>> > >>> Signed-off-by: Jacopo Mondi

[PATCH v10 08/10] media: i2c: Copy tw9910 soc_camera sensor driver

2018-02-21 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

Re: [PATCH v2 08/19] ARM64: dts: Add Renesas R8A77965 SoC support

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:45:48PM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi > wrote: > > Basic support for the Gen 3 R-Car M3-N SoC. > > > > Based on original work from: > > Takeshi Kihara > >

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread Sergei Shtylyov
On 02/21/2018 08:31 PM, Simon Horman wrote: > Populate the ethernet@e680 device node to enable Ethernet interface > for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven >

[PATCH v10 10/10] arch: sh: migor: Use new renesas-ceu camera driver

2018-02-21 Thread Jacopo Mondi
Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

[PATCH v10 09/10] media: i2c: tw9910: Remove soc_camera dependencies

2018-02-21 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread Sergei Shtylyov
On 02/21/2018 08:38 PM, Sergei Shtylyov wrote: >> Populate the ethernet@e680 device node to enable Ethernet interface >> for R-Car M3-N (r8a77965) SoC. >> >> Signed-off-by: Jacopo Mondi >> Reviewed-by: Geert Uytterhoeven

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread Sergei Shtylyov
On 02/21/2018 09:23 PM, Simon Horman wrote: > ... > + clocks = < CPG_MOD 812>; + power-domains = < 32>; + resets = < 812>; + phy-mode = "rgmii-txid"; >>> >>>Why not

Re: [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:46:23PM +0100, Geert Uytterhoeven wrote: > On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi > wrote: > > Add basic support for R-Car Salvator-X M3-N (R8A77965) board. > > > > Based on original work from: > > Takeshi Kihara

Re: [PATCH v2 12/19] dt-bindings: serial: sh-sci: Add support for r8a77965 (H)SCIF

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:14PM +0100, Jacopo Mondi wrote: > Add documentation for r8a77965 compatible string to Renesas sci-serial > device tree bindings documentation. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman

Re: [PATCH v2 11/19] ARM64: dts: r8a77965: Add dmac device nods

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:13PM +0100, Jacopo Mondi wrote: > Add dmac[0-2] device nodes for R-Car M3-N (r8a77965) SoC. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven Thanks, applied with prefix updated to: arm64: dts:

[PATCH v10 03/10] media: platform: Add Renesas CEU driver

2018-02-21 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v10 02/10] include: media: Add Renesas CEU driver interface

2018-02-21 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v10 06/10] media: i2c: ov772x: Remove soc_camera dependencies

2018-02-21 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v10 05/10] media: i2c: Copy ov772x soc_camera sensor driver

2018-02-21 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v10 07/10] media: i2c: ov772x: Support frame interval handling

2018-02-21 Thread Jacopo Mondi
Add support to ov772x driver for frame intervals handling and enumeration. Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for 10, 15 and 30 frame per second rates. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart

[PATCH v10 01/10] dt-bindings: media: Add Renesas CEU bindings

2018-02-21 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v10 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-21 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

Re: [PATCH v2 16/19] ARM64: dts: r8a77965: Add GPIO nodes

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:18PM +0100, Jacopo Mondi wrote: > Add GPIO nodes to r8a77965 SoC device tree file. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > > --- > v1 -> v2: > - Replace ALWAYS_ON power area define

Re: [PATCH v2 15/19] dt-bindings: gpio: Add support for r8a77965

2018-02-21 Thread Simon Horman
On Tue, Feb 20, 2018 at 04:12:17PM +0100, Jacopo Mondi wrote: > Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman

[PATCH v10 00/10] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-02-21 Thread Jacopo Mondi
Hello, 10th round, one step closer to finalize CEU inclusion (hopefully). I have dropped patch 11/11 of v9 as it is still a debated topic and I would like to have it clarified without blocking this series. In patch [3/10] Hans noticed that after changing input, format should be set on CEU

Re: [PATCH V3] ARM: shmobile: stout: enable R-Car Gen2 regulator quirk

2018-02-21 Thread Simon Horman
On Thu, Feb 15, 2018 at 12:33:50PM +0100, Marek Vasut wrote: > Regulator setup is suboptimal on H2 Stout too. The Stout newly has > two DA9210 regulators, so the quirk is extended to handle another > DA9210 at i2c address 0x70. > > Signed-off-by: Marek Vasut > Cc:

Re: [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-21 Thread Laurent Pinchart
Hi Sergei, On Wednesday, 21 February 2018 10:35:13 EET Sergei Shtylyov wrote: > On 2/21/2018 2:10 AM, Laurent Pinchart wrote: > > The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add > > corresponding device tree bindings. > > > > Signed-off-by: Laurent Pinchart > >

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-21 Thread Laurent Pinchart
Hi Hans, On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote: > On 02/19/2018 11:28 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your feedback. > > > > [snip] > > > >> Can you then fix v4l2-compliance to stop testing colorspace > >> against 0xff > >> ? >

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 08:53:53PM +0300, Sergei Shtylyov wrote: > On 02/21/2018 08:38 PM, Sergei Shtylyov wrote: ... > >> + clocks = < CPG_MOD 812>; > >> + power-domains = < 32>; > >> + resets = < 812>; > >> +

Re: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

2018-02-21 Thread Simon Horman
On Wed, Feb 21, 2018 at 05:30:12PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Feb 21, 2018 at 5:13 PM, Simon Horman wrote: > > On Tue, Feb 20, 2018 at 01:51:28PM +0100, Geert Uytterhoeven wrote: > >> On Mon, Feb 12, 2018 at 6:44 PM, Fabrizio Castro > >>

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-21 Thread Sakari Ailus
Hi Laurent and Hans, On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote: > No, I'm sorry, for MC-based drivers this isn't correct. The media entity that > symbolizes the DMA engine indeed has a sink pad, but it's a video node, not a > subdev. It thus has no media bus format

Re: [PATCH 1/2] ARM: shmobile: Factor out complex condition

2018-02-21 Thread Marek Vasut
On 02/19/2018 09:58 AM, Simon Horman wrote: > On Sat, Feb 17, 2018 at 03:06:41AM +0100, Marek Vasut wrote: >> Pull the complex condition in regulator_quirk_notify() into >> regulator_quirk_check(). Moreover, do not hard-code the I2C >> address, but rather use the one in da9xxx_msgs[]. >> >>

Re: [PATCH] clk: renesas: rcar-gen3: Fix SD divider setting

2018-02-21 Thread Wolfram Sang
Simon, sorry for the delay in checking this. I refreshed my memory about the issues here this evening and will be able to do educated tests tomorrow. However, one question already: > - In M3N, HS400 mode and HS200 mode use the same clock setting. a) I did not find any code handling this

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-21 Thread Laurent Pinchart
Hi Jacopo, On Tuesday, 20 February 2018 10:58:57 EET jacopo mondi wrote: > On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote: > > On Monday, 19 February 2018 18:59:44 EET Jacopo Mondi wrote: > >> The sensor driver sets mbus format colorspace information and sizes, > >> but not