Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-22 Thread Hans Verkuil
On 02/21/2018 10:01 PM, Sakari Ailus wrote: > Hi Laurent and Hans, > > On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote: >> No, I'm sorry, for MC-based drivers this isn't correct. The media entity >> that >> symbolizes the DMA engine indeed has a sink pad, but it's a video node,

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-22 Thread Geert Uytterhoeven
Hi Philipp, On Wed, Feb 21, 2018 at 5:51 PM, Philipp Zabel wrote: > I have a suggestion to avoid having to use the IS_ERR_OR_NULL macro, see > below: > > On Tue, 2018-02-13 at 17:36 +0100, Geert Uytterhoeven wrote: >> Vfio-platform requires reset support, provided either

Re: [PATCH] pinctrl: sh-pfc: r8a7795: remove duplicate of CLKOUT pin in pinmux_pins[]

2018-02-22 Thread Geert Uytterhoeven
Hi Niklas, Linus, CC pinctrl On Thu, Feb 22, 2018 at 12:32 AM, Niklas Söderlund wrote: > When adding GP-1-28 port pin support it was forgotten to remove the > CLKOUT pin from the list of pins that are not associated with a GPIO > port in pinmux_pins[].

Re: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

2018-02-22 Thread Geert Uytterhoeven
Hi Simon, On Wed, Feb 21, 2018 at 7:32 PM, Simon Horman wrote: > On Wed, Feb 21, 2018 at 05:30:12PM +0100, Geert Uytterhoeven wrote: >> On Wed, Feb 21, 2018 at 5:13 PM, Simon Horman wrote: >> > On Tue, Feb 20, 2018 at 01:51:28PM +0100, Geert Uytterhoeven

Re: [PATCH v5 6/8] i2c: demux: Use changeset helpers for clarity

2018-02-22 Thread Geert Uytterhoeven
Hi Laurent, On Thu, Feb 22, 2018 at 1:05 AM, Laurent Pinchart wrote: > From: Pantelis Antoniou > > The changeset helpers are easier to use, use them instead of > using the static property. > > Signed-off-by: Pantelis

Re: [PATCH 2/2] vfio: platform: Add generic DT reset support

2018-02-22 Thread Philipp Zabel
Hi Geert, On Thu, 2018-02-22 at 09:50 +0100, Geert Uytterhoeven wrote: [...] > > > @@ -127,8 +134,15 @@ static int vfio_platform_get_reset(struct > > > vfio_platform_device *vdev) > > > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > > >

Re: [PATCH v10 03/10] media: platform: Add Renesas CEU driver

2018-02-22 Thread Hans Verkuil
On 02/21/18 18:47, Jacopo Mondi wrote: > Add driver for Renesas Capture Engine Unit (CEU). > > The CEU interface supports capturing 'data' (YUV422) and 'images' > (NV[12|21|16|61]). > > This driver aims to replace the soc_camera-based sh_mobile_ceu one. > > Tested with ov7670 camera sensor,

Re: [PATCH v5 6/8] i2c: demux: Use changeset helpers for clarity

2018-02-22 Thread Laurent Pinchart
Hi Geert, On Thursday, 22 February 2018 11:26:44 EET Geert Uytterhoeven wrote: > On Thu, Feb 22, 2018 at 1:05 AM, Laurent Pinchart wrote: > > From: Pantelis Antoniou > > > > The changeset helpers are easier to use, use them instead of > > using the static

[PATCH v11 02/10] include: media: Add Renesas CEU driver interface

2018-02-22 Thread Jacopo Mondi
Add renesas-ceu header file. Do not remove the existing sh_mobile_ceu.h one as long as the original driver does not go away. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil

[PATCH v11 03/10] media: platform: Add Renesas CEU driver

2018-02-22 Thread Jacopo Mondi
Add driver for Renesas Capture Engine Unit (CEU). The CEU interface supports capturing 'data' (YUV422) and 'images' (NV[12|21|16|61]). This driver aims to replace the soc_camera-based sh_mobile_ceu one. Tested with ov7670 camera sensor, providing YUYV_2X8 data on Renesas RZ platform GR-Peach.

[PATCH v11 05/10] media: i2c: Copy ov772x soc_camera sensor driver

2018-02-22 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v11 01/10] dt-bindings: media: Add Renesas CEU bindings

2018-02-22 Thread Jacopo Mondi
Add bindings documentation for Renesas Capture Engine Unit (CEU). Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH 3/3] MAINTAINERS: Add entry for Techwell TW9910

2018-02-22 Thread Jacopo Mondi
Add entry for Techwell TW9910 video decoder. The driver is currently orphaned. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 64b8cd4..da1a88d 100644 --- a/MAINTAINERS +++

[PATCH 1/3] MAINTAINERS: Add entry for Renesas CEU

2018-02-22 Thread Jacopo Mondi
Add entry for Renesas Capture Engine Interface listing myself as maintainer. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aee793b..de0d4c6 100644 --- a/MAINTAINERS +++

[PATCH 0/3] Update MAINTAINERS file preparing for CEU inclusion

2018-02-22 Thread Jacopo Mondi
Hi Hans, this 3 patches update MAINTAINERS in preparation for CEU inclusion. I have listed myself as contact for CEU driver, as well as for ov772x as I've a access to a test platform but for "Odd fixes" only. I listed tw9910 as unmaintained instead, as I've not been able to test it. Thanks

[PATCH 2/3] MAINTAINERS: Add entry for Omnivision OV772x

2018-02-22 Thread Jacopo Mondi
Add entry for Omnivision OV772x image sensor listing myself as maintainer for 'Odd fixes' only, as I currently have access to a platform for testing. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Laurent Pinchart
Hi Frank, On Thursday, 22 February 2018 08:07:14 EET Frank Rowand wrote: > On 02/20/18 15:10, Laurent Pinchart wrote: > > Hello, > > > > This patch series addresses a design mistake that dates back from the > > initial DU support. Support for the LVDS encoders, which are IP cores > > separate

[PATCH v11 09/10] media: i2c: tw9910: Remove soc_camera dependencies

2018-02-22 Thread Jacopo Mondi
Remove soc_camera framework dependencies from tw9910 sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Add kernel doc to driver interface header file - Adjust build system This commit does not remove the original

[PATCH v11 10/10] arch: sh: migor: Use new renesas-ceu camera driver

2018-02-22 Thread Jacopo Mondi
Migo-R platform uses sh_mobile_ceu camera driver, which is now being replaced by a proper V4L2 camera driver named 'renesas-ceu'. Move Migo-R platform to use the v4l2 renesas-ceu camera driver interface and get rid of soc_camera defined components used to register sensor drivers and of platform

Re: [PATCH v5 6/8] i2c: demux: Use changeset helpers for clarity

2018-02-22 Thread Wolfram Sang
> > Why? ePAPR says "okay", "disabled", "fail", or "fail-sss". > > > > Sorry for missing this in the previous round. > > That was per Wolfram's request, and because the existing code uses "ok". I'm > personally fine with any. I did? Well, today I don't have a strong preference. Any is fine

Re: [PATCH] i2c: adv748x: afe: fix sparse warning

2018-02-22 Thread Geert Uytterhoeven
Hi Niklas, On Thu, Feb 22, 2018 at 12:21 AM, Niklas Söderlund wrote: > This fixes the following sparse warning: > > drivers/media/i2c/adv748x/adv748x-afe.c:294:34:expected unsigned int > [usertype] *signal >

[PATCH v11 00/10] Renesas Capture Engine Unit (CEU) V4L2 driver

2018-02-22 Thread Jacopo Mondi
Hello, Hans reported he sees a few warnings when compiling CEU driver with gcc7.3.0 I have silenced them, and the one reported in "probe" was actually a bug. That's the diff from v10: diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c index

[PATCH v11 08/10] media: i2c: Copy tw9910 soc_camera sensor driver

2018-02-22 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi

[PATCH v11 06/10] media: i2c: ov772x: Remove soc_camera dependencies

2018-02-22 Thread Jacopo Mondi
Remove soc_camera framework dependencies from ov772x sensor driver. - Handle clock and gpios - Register async subdevice - Remove soc_camera specific g/s_mbus_config operations - Change image format colorspace from JPEG to SRGB as the two use the same colorspace information but JPEG makes

[PATCH v11 07/10] media: i2c: ov772x: Support frame interval handling

2018-02-22 Thread Jacopo Mondi
Add support to ov772x driver for frame intervals handling and enumeration. Tested with 10MHz and 24MHz input clock at VGA and QVGA resolutions for 10, 15 and 30 frame per second rates. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart

[PATCH v11 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-02-22 Thread Jacopo Mondi
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil ---

[PATCH v6 4/4] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-02-22 Thread Laurent Pinchart
The LVDS encoders used to be described in DT as part of the DU. They now have their own DT node, linked to the DU using the OF graph bindings. This allows moving internal LVDS encoder support to a separate driver modelled as a DRM bridge. Backward compatibility is retained as legacy DT is patched

[PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-22 Thread Laurent Pinchart
The internal LVDS encoders now have their own DT bindings. Before switching the driver infrastructure to those new bindings, implement backward-compatibility through live DT patching. Patching is disabled and will be enabled along with support for the new DT bindings in the DU driver.

[PATCH v6 0/4] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Laurent Pinchart
Hello, This patch series addresses a design mistake that dates back from the initial DU support. Support for the LVDS encoders, which are IP cores separate from the DU, was bundled in the DU driver. Worse, both the DU and LVDS were described through a single DT node. To fix the, patches 1/4 and

[PATCH v6 2/4] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings

2018-02-22 Thread Laurent Pinchart
The internal LVDS encoders now have their own DT bindings, representing them as part of the DU is deprecated. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Remove the LVDS reg range from the example

[PATCH v6 1/4] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-22 Thread Laurent Pinchart
The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add corresponding device tree bindings. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring --- Changes since v1: - Move the SoC name before the IP name in

Re: [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-22 Thread Geert Uytterhoeven
Hi Arnd, On Thu, Feb 22, 2018 at 12:39 PM, Arnd Bergmann wrote: > On Wed, Feb 21, 2018 at 6:15 PM, Simon Horman wrote: >> On Tue, Feb 20, 2018 at 04:46:23PM +0100, Geert Uytterhoeven wrote: >>> On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi

Re: [PATCH v6 2/4] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings

2018-02-22 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-02-22 15:13:34 +0200, Laurent Pinchart wrote: > The internal LVDS encoders now have their own DT bindings, representing > them as part of the DU is deprecated. > > Signed-off-by: Laurent Pinchart >

Re: [PATCH v6 1/4] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings

2018-02-22 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-02-22 15:13:33 +0200, Laurent Pinchart wrote: > The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add > corresponding device tree bindings. > > Signed-off-by: Laurent Pinchart > Reviewed-by:

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-22 Thread jacopo mondi
Hi Laurent, On Thu, Feb 22, 2018 at 02:14:53PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Thursday, 22 February 2018 14:04:12 EET jacopo mondi wrote: > > On Wed, Feb 21, 2018 at 10:28:06PM +0200, Laurent Pinchart wrote: > > > On Tuesday, 20 February 2018 10:58:57 EET jacopo mondi wrote: >

Re: [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-22 Thread Arnd Bergmann
On Wed, Feb 21, 2018 at 6:15 PM, Simon Horman wrote: > On Tue, Feb 20, 2018 at 04:46:23PM +0100, Geert Uytterhoeven wrote: >> On Tue, Feb 20, 2018 at 4:12 PM, Jacopo Mondi >> wrote: >> > Add basic support for R-Car Salvator-X M3-N (R8A77965) board.

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-22 Thread jacopo mondi
Hi Laurent, On Wed, Feb 21, 2018 at 10:28:06PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Tuesday, 20 February 2018 10:58:57 EET jacopo mondi wrote: > > On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote: > > > On Monday, 19 February 2018 18:59:44 EET Jacopo Mondi wrote: > >

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-22 Thread Laurent Pinchart
Hi Jacopo, On Thursday, 22 February 2018 14:04:12 EET jacopo mondi wrote: > On Wed, Feb 21, 2018 at 10:28:06PM +0200, Laurent Pinchart wrote: > > On Tuesday, 20 February 2018 10:58:57 EET jacopo mondi wrote: > > > On Mon, Feb 19, 2018 at 09:19:32PM +0200, Laurent Pinchart wrote: > > > > On

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-22 Thread Laurent Pinchart
Hi Hans, On Thursday, 22 February 2018 09:38:46 EET Hans Verkuil wrote: > On 02/21/2018 09:16 PM, Laurent Pinchart wrote: > > On Tuesday, 20 February 2018 10:37:22 EET Hans Verkuil wrote: > >> On 02/19/2018 11:28 PM, Niklas Söderlund wrote: > >>> Hi Hans, > >>> > >>> Thanks for your feedback. >

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-22 Thread Laurent Pinchart
Hi Jacopo, On Thursday, 22 February 2018 14:36:00 EET jacopo mondi wrote: > On Thu, Feb 22, 2018 at 02:14:53PM +0200, Laurent Pinchart wrote: > > On Thursday, 22 February 2018 14:04:12 EET jacopo mondi wrote: > >> On Wed, Feb 21, 2018 at 10:28:06PM +0200, Laurent Pinchart wrote: > >>> On Tuesday,

Re: [PATCH v2] videodev2.h: add helper to validate colorspace

2018-02-22 Thread Laurent Pinchart
Hi Hans, On Thursday, 22 February 2018 10:01:13 EET Hans Verkuil wrote: > On 02/21/2018 10:01 PM, Sakari Ailus wrote: > > On Wed, Feb 21, 2018 at 10:16:25PM +0200, Laurent Pinchart wrote: > >> No, I'm sorry, for MC-based drivers this isn't correct. The media entity > >> that symbolizes the DMA

Re: [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 4:38 PM, Simon Horman wrote: > On Thu, Feb 22, 2018 at 02:28:46PM +0100, Geert Uytterhoeven wrote: >> Removing the .dts file removes the ability to boot the newly added board... >> >> The issue here is that we are sharing board .dtsi for boards that

Re: [PATCH v3] vsp1: fix video output on R8A77970

2018-02-22 Thread Laurent Pinchart
Hi Sergei, On Thursday, 22 February 2018 18:26:20 EET Laurent Pinchart wrote: > On Thursday, 18 January 2018 16:05:51 EET Sergei Shtylyov wrote: > > Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, > > and VSP2-D instances") added support for the VSP2-D found in the R-Car >

Re: [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support

2018-02-22 Thread Simon Horman
On Thu, Feb 22, 2018 at 02:28:46PM +0100, Geert Uytterhoeven wrote: > Hi Arnd, > > On Thu, Feb 22, 2018 at 12:39 PM, Arnd Bergmann wrote: > > On Wed, Feb 21, 2018 at 6:15 PM, Simon Horman wrote: > >> On Tue, Feb 20, 2018 at 04:46:23PM +0100, Geert Uytterhoeven

Re: [PATCH 1/4] v4l: vsp1: fix mask creation for MULT_ALPHA_RATIO

2018-02-22 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Monday, 5 February 2018 22:09:58 EET Wolfram Sang wrote: > Due to a typo, the mask was destroyed by a comparison instead of a bit > shift. No regression since the mask has not been used yet. > > Signed-off-by: Wolfram Sang

Re: [PATCH v3] vsp1: fix video output on R8A77970

2018-02-22 Thread Laurent Pinchart
Hi Sergei, Thank you for the patch. On Thursday, 18 January 2018 16:05:51 EET Sergei Shtylyov wrote: > Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, > and VSP2-D instances") added support for the VSP2-D found in the R-Car > V3M (R8A77970) but the video output that VSP2-D

Re: [PATCH v4] v4l: vsp1: Fix video output on R8A77970

2018-02-22 Thread Sergei Shtylyov
On 02/22/2018 07:32 PM, Laurent Pinchart wrote: > From: Sergei Shtylyov > > Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, > and VSP2-D instances") added support for the VSP2-D found in the R-Car > V3M (R8A77970) but the video output

Re: [PATCH v4] v4l: vsp1: Fix video output on R8A77970

2018-02-22 Thread Laurent Pinchart
Hi Sergei, On Thursday, 22 February 2018 20:34:37 EET Sergei Shtylyov wrote: > On 02/22/2018 07:32 PM, Laurent Pinchart wrote: > > From: Sergei Shtylyov > > > > Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, > > and VSP2-D instances")

Re: [PATCH v3] vsp1: fix video output on R8A77970

2018-02-22 Thread Sergei Shtylyov
On 02/22/2018 07:26 PM, Laurent Pinchart wrote: > Hi Sergei, > > Thank you for the patch. > > On Thursday, 18 January 2018 16:05:51 EET Sergei Shtylyov wrote: >> Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, >> and VSP2-D instances") added support for the VSP2-D found in

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-22 Thread Simon Horman
On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote: > On 02/21/2018 09:23 PM, Simon Horman wrote: > > > ... > > > +clocks = < CPG_MOD 812>; > +power-domains = < 32>; > +resets = < 812>; >

[PATCH v4] v4l: vsp1: Fix video output on R8A77970

2018-02-22 Thread Laurent Pinchart
From: Sergei Shtylyov Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, and VSP2-D instances") added support for the VSP2-D found in the R-Car V3M (R8A77970) but the video output that VSP2-D sends to DU has a greenish garbage-like line

Re: [PATCH v6 0/4] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Frank Rowand
On 02/22/18 05:13, Laurent Pinchart wrote: > Hello, > > This patch series addresses a design mistake that dates back from the initial > DU support. Support for the LVDS encoders, which are IP cores separate from > the DU, was bundled in the DU driver. Worse, both the DU and LVDS were > described

Re: [PATCH v6 0/4] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Laurent Pinchart
Hi Frank, On Thursday, 22 February 2018 22:23:20 EET Frank Rowand wrote: > On 02/22/18 05:13, Laurent Pinchart wrote: > > Hello, > > > > This patch series addresses a design mistake that dates back from the > > initial DU support. Support for the LVDS encoders, which are IP cores > > separate

[PATCH 2/6] arm64: dts: renesas: r8a77965: Add #address-cells and #size-cells

2018-02-22 Thread Jacopo Mondi
Add "#address-cells" and "#size-cells" properties to all place-holder nodes that have children nodes defined by salvator-x[s].dtsi device tree. This silences the following DTC compiler warnings: Warning (reg_format): "reg" property in /soc/.. has invalid length (4 bytes) (#address-cells == 2,

[PATCH 1/6] arm64: dts: renesas: r8a77965: Add "reg" properties

2018-02-22 Thread Jacopo Mondi
Add "reg" properties to place-holder nodes with unit address defined for R-Car M3-N SoC. This silences the following DTC compiler warning: Warning (unit_address_vs_reg): Node /soc/... has a unit name, but no reg property Signed-off-by: Jacopo Mondi ---

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-22 Thread Sergei Shtylyov
Hello! On 02/22/2018 06:54 PM, Simon Horman wrote: >>> ... >>> >> +clocks = < CPG_MOD 812>; >> +power-domains = < 32>; >> +resets = < 812>; >> +phy-mode = "rgmii-txid"; >

Re: [PATCH v4] v4l: vsp1: Fix video output on R8A77970

2018-02-22 Thread Sergei Shtylyov
On 02/22/2018 09:46 PM, Laurent Pinchart wrote: >>> From: Sergei Shtylyov >>> >>> Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, >>> and VSP2-D instances") added support for the VSP2-D found in the R-Car >>> V3M (R8A77970) but the video

[PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

2018-02-22 Thread Jacopo Mondi
Add "#interrupt-cells" property and "interrupt-controller" label to "interrupt-controller@e61c" device node. This silences the following DTC compiler warnings: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/interrupt-controller@e61c Warning

[PATCH 5/6] arm64: dts: renesas: r8a77965: Add #pwm-cells property

2018-02-22 Thread Jacopo Mondi
Add "#pwm-cells" property to "pwm@e6e31000" device node. This silences the following DTC compiler warning: Warning (pwms_property): Missing property '#pwm-cells' in node /soc/pwm@e6e31000 or bad phandle (referred from /backlight:pwms[0]) Signed-off-by: Jacopo Mondi

[PATCH 4/6] arm64: dts: renesas: r8a77965: Add #phy-cells property

2018-02-22 Thread Jacopo Mondi
Add "#phy-cells" property to "usb-phy@e65ee000" device node. This silences the following DTC compiler warning: Warning (phys_property): Missing property '#phy-cells' in node /soc/usb-phy@e65ee000 or bad phandle (referred from /soc/usb@ee02:phys[0]) Signed-off-by: Jacopo Mondi

[PATCH 3/6] arm64: dts: renesas: r8a77965: Remove stale reg property

2018-02-22 Thread Jacopo Mondi
Remove "reg" property from cache-controller-0 device node as it does not have any unit address. This silences the following DTC compiler warning: Warning (unit_address_vs_reg): Node /cpus/cache-controller-0 has a reg or ranges property, but no unit name Signed-off-by: Jacopo Mondi

[PATCH 0/6] R-Car M3-N DTS fixes

2018-02-22 Thread Jacopo Mondi
Hello Simon, Arnd, The recently introduced Renesas R-Car M3-N SoC device tree source file is included from salvator-x[s]-$SOC.dts, and it thus needs place holders for devices not yet enabled but whose nodes are referenced by those common files. When first submitted r8a77965.dtsi I ignored

[PATCH v2] v4l: vsp1: Print the correct blending unit name in debug messages

2018-02-22 Thread Laurent Pinchart
The DRM pipelines can use either the BRU or the BRS for blending. Make sure the right name is used in debugging messages to avoid confusion. Signed-off-by: Laurent Pinchart --- Changes since v1: - Create a macro to get the right entity name instead of

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-22 Thread Laurent Pinchart
Hi Frank, On Friday, 23 February 2018 00:10:17 EET Frank Rowand wrote: > Hi Laurent, Rob, > > Thanks for the prompt spin to address my concerns. There are some small > technical issues. > > I did not read the v3 patch until today. v3 through v6 are still using the > old overlay apply method

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-22 Thread Frank Rowand
Hi Laurent, Rob, Thanks for the prompt spin to address my concerns. There are some small technical issues. I did not read the v3 patch until today. v3 through v6 are still using the old overlay apply method which uses an expanded device tree as input. Rob, I don't see my overlay patches in

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-22 Thread Frank Rowand
On 02/22/18 14:10, Frank Rowand wrote: > Hi Laurent, Rob, > > Thanks for the prompt spin to address my concerns. There are some small > technical issues. > > I did not read the v3 patch until today. v3 through v6 are still using the > old overlay apply method which uses an expanded device tree

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Frank Rowand
Hi Laurent, On 02/22/18 02:25, Laurent Pinchart wrote: > Hi Frank, > > On Thursday, 22 February 2018 08:07:14 EET Frank Rowand wrote: >> On 02/20/18 15:10, Laurent Pinchart wrote: >>> Hello, >>> >>> This patch series addresses a design mistake that dates back from the >>> initial DU support.

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

2018-02-22 Thread Geert Uytterhoeven
Hi Simon, On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman wrote: > On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote: >> On 02/21/2018 09:23 PM, Simon Horman wrote: >> >> > ... >> > >> +clocks = < CPG_MOD 812>; >> +

Re: [PATCH/RFT v4] gpio: gpio-rcar: Support S2RAM

2018-02-22 Thread Linus Walleij
On Sun, Feb 4, 2018 at 8:15 PM, Yoshihiro Kaneko wrote: > From: Hien Dang > > This patch adds an implementation that saves and restores the state of > GPIO configuration on suspend and resume. > > Signed-off-by: Hien Dang

Re: [PATCH/RFT v4] gpio: gpio-rcar: Support S2RAM

2018-02-22 Thread Simon Horman
On Thu, Feb 22, 2018 at 03:51:27PM +0100, Linus Walleij wrote: > On Sun, Feb 4, 2018 at 8:15 PM, Yoshihiro Kaneko > wrote: > > > From: Hien Dang > > > > This patch adds an implementation that saves and restores the state of > > GPIO

Re: [PATCH v6 4/4] drm: rcar-du: Convert LVDS encoder code to bridge driver

2018-02-22 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-02-22 15:13:36 +0200, Laurent Pinchart wrote: > The LVDS encoders used to be described in DT as part of the DU. They now > have their own DT node, linked to the DU using the OF graph bindings. > This allows moving internal LVDS encoder support to a

Re: [PATCH v3 3/3] gpio: rcar: Use wakeup_path i.s.o. explicit clock handling

2018-02-22 Thread Linus Walleij
On Mon, Feb 12, 2018 at 2:55 PM, Geert Uytterhoeven wrote: > Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable > when wake-up is enabled"), when a GPIO is used for wakeup, the GPIO > block's module clock (if exists) is manually kept running during

Re: [PATCH v9 11/11] media: i2c: ov7670: Fully set mbus frame fmt

2018-02-22 Thread jacopo mondi
Hi Laurent, On Thu, Feb 22, 2018 at 02:47:06PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Thursday, 22 February 2018 14:36:00 EET jacopo mondi wrote: > > On Thu, Feb 22, 2018 at 02:14:53PM +0200, Laurent Pinchart wrote: > > > On Thursday, 22 February 2018 14:04:12 EET jacopo mondi wrote:

Re: [PATCH v3 3/3] gpio: rcar: Use wakeup_path i.s.o. explicit clock handling

2018-02-22 Thread Geert Uytterhoeven
Hi Linus, On Thu, Feb 22, 2018 at 3:23 PM, Linus Walleij wrote: > On Mon, Feb 12, 2018 at 2:55 PM, Geert Uytterhoeven > wrote: > >> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable >> when wake-up is enabled"), when a