Re: [PATCH v2] v4l: vsp1: Print the correct blending unit name in debug messages

Hi Laurent, Thanks for your patch. On 2018-02-22 22:52:26 +0200, Laurent Pinchart wrote: > The DRM pipelines can use either the BRU or the BRS for blending. Make > sure the right name is used in debugging messages to avoid confusion. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v5 00/26] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

On Thu, Feb 22, 2018 at 09:38:39AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Feb 21, 2018 at 7:32 PM, Simon Horman wrote: > > On Wed, Feb 21, 2018 at 05:30:12PM +0100, Geert Uytterhoeven wrote: > >> On Wed, Feb 21, 2018 at 5:13 PM, Simon Horman

Overlay sugar syntax (was: Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes)

Hi Frank, On Fri, Feb 23, 2018 at 3:38 AM, Frank Rowand wrote: > I was hoping to be able to convert the .dts files to use sugar syntax > instead of hand coding the fragment nodes, but for this specific set > of files I failed, since the labels that would have been

Re: [PATCH v11 04/10] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

On Thu, Feb 22, 2018 at 11:37:20AM +0100, Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Laurent Pinchart

[PATCH] arm64: renesas_defconfig: enable R8A77965 SoC

Enable the Renesas R-Car M3-W (R8A77965) SoC in the ARM64 renesas_defconfig. Signed-off-by: Simon Horman --- arch/arm64/configs/renesas_defconfig | 1 + 1 file changed, 1 insertion(+) Not for upstream merge diff --git a/arch/arm64/configs/renesas_defconfig

[PATCH] arm64: defconfig: enable R8A77965 SoC

Enable the Renesas R-Car M3-W (R8A77965) SoC in the ARM64 defconfig. Signed-off-by: Simon Horman --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index

Re: [PATCH v2] arm64: dts: renesas: Add support for Salvator-XS with R-Car M3-N

On Mon, Feb 19, 2018 at 07:20:55PM +0100, Geert Uytterhoeven wrote: > From: Takeshi Kihara > > Add initial support for the Renesas Salvator-XS (Salvator-X 2nd version) > development board equipped with an R-Car M3-N SiP. > > Most features are enabled through the

Re: [PATCH] ARM: dts: marzen: Add SDHI0 VCCQ Regulator

On Mon, Feb 19, 2018 at 09:37:58PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Add support for the on-board voltage regulator hooked up to GPIO3_20 > on r8a7779 Marzen. The board schematics describes the regulator as U4 > TPS2110A. Input wise, U4 has D0 fixed to

Re: [PATCH 00/02] ARM: dts: silk: Add EEPROM and GPIO keys

On Mon, Feb 19, 2018 at 08:49:33PM +0900, Magnus Damm wrote: > ARM: dts: silk: Add EEPROM and GPIO keys > > [PATCH 01/02] ARM: dts: silk: Add r1ex24002 EEPROM to DT > [PATCH 02/02] ARM: dts: silk: Add GPIO keys to DT > > This series updates the DTS for the R-Car E2-based Silk board to support an

Re: [PATCH] ARM: dts: porter: Add missing PMIC nodes

On Sun, Feb 18, 2018 at 04:07:51PM +0100, Geert Uytterhoeven wrote: > Hi Marek, > > CC Steve Twiss > > On Sat, Feb 17, 2018 at 3:07 AM, Marek Vasut wrote: > > Add PMIC nodes to Porter and connect CPU DVFS supply. There is > > one DA9063 and one DA9210 on Porter, the only

Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node

On Fri, Feb 23, 2018 at 08:06:11AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Feb 22, 2018 at 4:54 PM, Simon Horman wrote: > > On Wed, Feb 21, 2018 at 09:53:58PM +0300, Sergei Shtylyov wrote: > >> On 02/21/2018 09:23 PM, Simon Horman wrote: > >> > >> > ... > >>

Re: [PATCH] arm64: defconfig: enable R8A77965 SoC

Hi Simon, On 02/23/2018 10:51 AM, Simon Horman wrote: > Enable the Renesas R-Car M3-W (R8A77965) SoC in the ARM64 defconfig. If I'm not mistaken in my tardy note, then M3-W is R8A7796 and R8A77965 is M3-N, no? -- With best wishes, Vladimir

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

On 02/23/18 01:25, Laurent Pinchart wrote: > Hi Frank, > > On Friday, 23 February 2018 05:20:43 EET Frank Rowand wrote: >> On 02/22/18 02:25, Laurent Pinchart wrote: >>> On Thursday, 22 February 2018 08:07:14 EET Frank Rowand wrote: On 02/20/18 15:10, Laurent Pinchart wrote: > Hello,

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

On 02/23/18 01:00, Laurent Pinchart wrote: > Hi Frank, > > On Friday, 23 February 2018 04:38:06 EET Frank Rowand wrote: >> On 02/22/18 14:10, Frank Rowand wrote: >>> Hi Laurent, Rob, >>> >>> Thanks for the prompt spin to address my concerns. There are some small >>> technical issues. >>> >>> I

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

Hi Frank, On Friday, 23 February 2018 21:43:17 EET Frank Rowand wrote: > On 02/23/18 01:00, Laurent Pinchart wrote: > > On Friday, 23 February 2018 04:38:06 EET Frank Rowand wrote: > >> On 02/22/18 14:10, Frank Rowand wrote: > >>> Hi Laurent, Rob, > >>> > >>> Thanks for the prompt spin to

Re: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

On Fri, Feb 23, 2018 at 11:06:07AM +0100, jacopo mondi wrote: > Hi Geert, > > On Fri, Feb 23, 2018 at 10:27:16AM +0100, Geert Uytterhoeven wrote: > > On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi > > wrote: > > > Add "#interrupt-cells" property and

Re: [PATCH v2] v4l: vsp1: Print the correct blending unit name in debug messages

Hi Laurent, Thankyou for the patch (update). On 22/02/18 20:52, Laurent Pinchart wrote: > The DRM pipelines can use either the BRU or the BRS for blending. Make > sure the right name is used in debugging messages to avoid confusion. > > Signed-off-by: Laurent Pinchart

Re: [PATCH 1/6] arm64: dts: renesas: r8a77965: Add "reg" properties

Hi Geert, On Fri, Feb 23, 2018 at 10:19:21AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi > wrote: > > Add "reg" properties to place-holder nodes with unit address defined for > > R-Car M3-N SoC. > > > > This silences

Re: [PATCH 1/6] arm64: dts: renesas: r8a77965: Add "reg" properties

Hi Jacopo, On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > Add "reg" properties to place-holder nodes with unit address defined for > R-Car M3-N SoC. > > This silences the following DTC compiler warning: > Warning (unit_address_vs_reg): Node /soc/... has a unit

Re: [PATCH] arm64: renesas_defconfig: enable R8A77965 SoC

On Fri, Feb 23, 2018 at 9:51 AM, Simon Horman wrote: > Enable the Renesas R-Car M3-W (R8A77965) SoC in the ARM64 renesas_defconfig. > > Signed-off-by: Simon Horman Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [PATCH 5/6] arm64: dts: renesas: r8a77965: Add #pwm-cells property

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > Add "#pwm-cells" property to "pwm@e6e31000" device node. > > This silences the following DTC compiler warning: > Warning (pwms_property): Missing property '#pwm-cells' in node > /soc/pwm@e6e31000 or bad phandle

Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings

Hi Sergei, On Friday, 23 February 2018 11:32:54 EET Sergei Shtylyov wrote: > On 2/21/2018 2:10 AM, Laurent Pinchart wrote: > > The internal LVDS encoder now has DT bindings separate from the DU. Port > > the device tree over to the new model. > > > > Signed-off-by: Laurent Pinchart > >

Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings

On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart [...] diff --git a/arch/arm/boot/dts/r8a7791.dtsi

Re: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

Hi Geert, On Fri, Feb 23, 2018 at 10:27:16AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi > wrote: > > Add "#interrupt-cells" property and "interrupt-controller" label to > > "interrupt-controller@e61c" device node. > > > > This

Re: [PATCH 4/4] arm64: dts: r8a7795: Add PWM device nodes

Hello! On 1/19/2016 3:18 PM, Ulrich Hecht wrote: From: Ryo Kodama Signed-off-by: Ryo Kodama Signed-off-by: Harunobu Kurokawa [uli: adapted to new MSTP clock scheme] Signed-off-by: Ulrich Hecht

Re: [PATCH 4/4] arm64: dts: r8a7795: Add PWM device nodes

On 2/23/2018 1:09 PM, Sergei Shtylyov wrote: From: Ryo Kodama Signed-off-by: Ryo Kodama Signed-off-by: Harunobu Kurokawa [uli: adapted to new MSTP clock scheme] Signed-off-by: Ulrich Hecht

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

Hi Frank, On Friday, 23 February 2018 04:38:06 EET Frank Rowand wrote: > On 02/22/18 14:10, Frank Rowand wrote: > > Hi Laurent, Rob, > > > > Thanks for the prompt spin to address my concerns. There are some small > > technical issues. > > > > I did not read the v3 patch until today. v3

Re: [PATCH 4/6] arm64: dts: renesas: r8a77965: Add #phy-cells property

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > Add "#phy-cells" property to "usb-phy@e65ee000" device node. > > This silences the following DTC compiler warning: > Warning (phys_property): Missing property '#phy-cells' in node > /soc/usb-phy@e65ee000 or bad

Re: [PATCH 2/6] arm64: dts: renesas: r8a77965: Add #address-cells and #size-cells

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > Add "#address-cells" and "#size-cells" properties to all place-holder nodes > that have children nodes defined by salvator-x[s].dtsi device tree. > > This silences the following DTC compiler warnings: > Warning

Re: [PATCH 3/6] arm64: dts: renesas: r8a77965: Remove stale reg property

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > Remove "reg" property from cache-controller-0 device node as it does not > have any unit address. > > This silences the following DTC compiler warning: > Warning (unit_address_vs_reg): Node /cpus/cache-controller-0

Re: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > Add "#interrupt-cells" property and "interrupt-controller" label to > "interrupt-controller@e61c" device node. > > This silences the following DTC compiler warnings: > Warning (interrupts_property): Missing

Re: [PATCH v4 11/16] ARM: dts: r8a7791: Convert to new LVDS DT bindings

Hello! On 2/21/2018 2:10 AM, Laurent Pinchart wrote: The internal LVDS encoder now has DT bindings separate from the DU. Port the device tree over to the new model. Signed-off-by: Laurent Pinchart --- Changes since v3: - Added power-domains and

[PATCH v2 8/9] serial: sirf: Fix out-of-bounds access through DT alias

The sirf_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: a6ffe8966acbb66b ("serial: sirf: use dynamic method allocate uart structure") Signed-off-by: Geert Uytterhoeven

[PATCH v2 0/9] serial: Fix out-of-bounds accesses through DT aliases

Hi all, Serial drivers used on DT platforms use the "serialN" alias in DT to obtain the serial port index for a specific port. Drivers typically use a fixed-size array for keeping track of all available serial ports. However, several drivers do not perform any validation on the index

[PATCH v2 6/9] serial: samsung: Fix out-of-bounds access through serial port index

The s3c24xx_serial_ports[] array is indexed using a value derived from the "serialN" alias in DT, or from an incrementing probe index, which may lead to an out-of-bounds access. Fix this by adding a range check. Note that the array size is defined by a Kconfig symbol

[PATCH v2 3/9] serial: imx: Fix out-of-bounds access through serial port index

The imx_ports[] array is indexed using a value derived from the "serialN" alias in DT, or from platform data, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: ff05967a07225ab6 ("serial/imx: add of_alias_get_id() reference back") Signed-off-by: Geert

[PATCH v2 2/9] serial: fsl_lpuart: Fix out-of-bounds access through DT alias

The lpuart_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: c9e2e946fb0ba5d2 ("tty: serial: add Freescale lpuart driver support") Signed-off-by: Geert Uytterhoeven

[PATCH v2 5/9] serial: pxa: Fix out-of-bounds access through serial port index

The serial_pxa_ports[] array is indexed using a value derived from the "serialN" alias in DT, or from platform data, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 699c20f3e6310aa2 ("serial: pxa: add OF support") Signed-off-by: Geert Uytterhoeven

[PATCH v2 7/9] serial: sh-sci: Fix out-of-bounds access through DT alias

The sci_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Note that the array size is defined by a Kconfig symbol (CONFIG_SERIAL_SH_SCI_NR_UARTS), so this can even be triggered using a

Re: [PATCH v2 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

On 23.2.2018 14:38, Geert Uytterhoeven wrote: > The cdns_uart_port[] array is indexed using a value derived from the > "serialN" alias in DT, which may lead to an out-of-bounds access. > > Fix this by adding a range check. > > Fixes: 928e9263492069ee ("tty: xuartps: Initialize ports according to

[PATCH v2 3/7] arm64: dts: renesas: r8a77965: Remove stale reg property

Remove "reg" property from cache-controller-0 device node as it does not have any unit address. This silences the following DTC compiler warning: Warning (unit_address_vs_reg): Node /cpus/cache-controller-0 has a reg or ranges property, but no unit name Signed-off-by: Jacopo Mondi

[PATCH v2 6/7] arm64: dts: renesas: r8a77965: Add #interrupt-cells property

Add "#interrupt-cells" property and "interrupt-controller" label to "interrupt-controller@e61c" device node. This silences the following DTC compiler warnings: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /soc/interrupt-controller@e61c Warning

[PATCH v2 2/7] arm64: dts: renesas: r8a77965: Add #address-cells and #size-cells

Add "#address-cells" and "#size-cells" properties to all place-holder nodes that have children nodes defined by salvator-x[s].dtsi device tree. This silences the following DTC compiler warnings: Warning (reg_format): "reg" property in /soc/.. has invalid length (4 bytes) (#address-cells == 2,

[PATCH v2 4/7] arm64: dts: renesas: r8a77965: Add #phy-cells property

Add "#phy-cells" property to "usb-phy@e65ee000" device node. This silences the following DTC compiler warning: Warning (phys_property): Missing property '#phy-cells' in node /soc/usb-phy@e65ee000 or bad phandle (referred from /soc/usb@ee02:phys[0]) Signed-off-by: Jacopo Mondi

[PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add #pwm-cells property

Add "#pwm-cells" property to "pwm@e6e31000" device node. This silences the following DTC compiler warning: Warning (pwms_property): Missing property '#pwm-cells' in node /soc/pwm@e6e31000 or bad phandle (referred from /backlight:pwms[0]) Signed-off-by: Jacopo Mondi

[PATCH v2 7/7] arm64: dts: renesas: r8a77965: Move usb2_phy1 up

Move "usb2_ph1" place-holder device node next to "usb2_phy0" one. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi

[PATCH v2 1/7] arm64: dts: renesas: r8a77965: Add "reg" properties

Add "reg" properties to place-holder nodes with unit address defined for R-Car M3-N SoC. This silences the following DTC compiler warning: Warning (unit_address_vs_reg): Node /soc/... has a unit name, but no reg property Signed-off-by: Jacopo Mondi Reviewed-by: Geert

[PATCH v2 4/9] serial: mxs-auart: Fix out-of-bounds access through serial port index

The auart_port[] array is indexed using a value derived from the "serialN" alias in DT, or from platform data, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 1ea6607d4cdc9179 ("serial: mxs-auart: Allow device tree probing") Signed-off-by: Geert Uytterhoeven

[PATCH v2 0/7] R-Car M3-N DTS fixes

Hello, in this second iteration I have fixed two remarks from Geert received on v1: - Extend "du" address length to include third channel - Move usb2_phy1 device node next to usb2_phy0 Two minor nits were not addressed: - "placeholder" comment position not changed to maintain consistency with

[PATCH v2 1/9] serial: arc_uart: Fix out-of-bounds access through DT alias

The arc_uart_ports[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Note that the array size is defined by a Kconfig symbol (CONFIG_SERIAL_ARC_NR_PORTS), so this can even be triggered using a

[PATCH v2 9/9] serial: xuartps: Fix out-of-bounds access through DT alias

The cdns_uart_port[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 928e9263492069ee ("tty: xuartps: Initialize ports according to aliases") Signed-off-by: Geert Uytterhoeven

Re: [PATCH v2 3/9] serial: imx: Fix out-of-bounds access through serial port index

On Fri, Feb 23, 2018 at 02:38:31PM +0100, Geert Uytterhoeven wrote: > The imx_ports[] array is indexed using a value derived from the > "serialN" alias in DT, or from platform data, which may lead to an > out-of-bounds access. > > Fix this by adding a range check. > > Fixes: ff05967a07225ab6

Re: [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT

On Fri, Feb 23, 2018 at 12:29:49PM +, Colin King wrote: > From: Colin Ian King > > Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice; > remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT. > > Signed-off-by: Colin Ian King >

Re: [PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT

On Fri, Feb 23, 2018 at 1:29 PM, Colin King wrote: > From: Colin Ian King > > Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice; > remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT. > > Signed-off-by: Colin Ian King

[PATCH] PCI: rcar-gen2: remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT

From: Colin Ian King Bit pattern RCAR_PCI_INT_SIGRETABORT is being bit-wise or'd twice; remove the redundant 2nd RCAR_PCI_INT_SIGRETABORT. Signed-off-by: Colin Ian King --- drivers/pci/host/pci-rcar-gen2.c | 1 - 1 file changed, 1

Re: [PATCH 1/6] arm64: dts: renesas: r8a77965: Add "reg" properties

Hi Jacopo, On Fri, Feb 23, 2018 at 1:22 PM, jacopo mondi wrote: > On Fri, Feb 23, 2018 at 10:19:21AM +0100, Geert Uytterhoeven wrote: >> On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi >> wrote: >> > Add "reg" properties to place-holder nodes with

Re: [PATCH v2 0/7] R-Car M3-N DTS fixes

On Fri, Feb 23, 2018 at 02:40:52PM +0100, Jacopo Mondi wrote: > Hello, >in this second iteration I have fixed two remarks from Geert received on > v1: > - Extend "du" address length to include third channel > - Move usb2_phy1 device node next to usb2_phy0 > > Two minor nits were not

Re: [PATCH] arm64: defconfig: enable R8A77965 SoC

On Fri, Feb 23, 2018 at 10:19:45AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 23, 2018 at 9:51 AM, Simon Horman > wrote: > > Enable the Renesas R-Car M3-W (R8A77965) SoC in the ARM64 defconfig. > > > > Signed-off-by: Simon Horman > >

Re: [PATCH] arm64: defconfig: enable R8A77965 SoC

On Fri, Feb 23, 2018 at 10:19:45AM +0100, Geert Uytterhoeven wrote: > On Fri, Feb 23, 2018 at 9:51 AM, Simon Horman > wrote: > > Enable the Renesas R-Car M3-W (R8A77965) SoC in the ARM64 defconfig. > > > > Signed-off-by: Simon Horman > >